Skip to content

Commit 6e1c9f2

Browse files
edgarfgpedgarfgp
authored
Merge branch 'main' into fix-16343
2 parents 0c8a0a4 + 5065f5b commit 6e1c9f2

File tree

27 files changed

+100
-62
lines changed

27 files changed

+100
-62
lines changed

‎.github/copilot-instructions.md

Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
# GitHub Copilot Instructions for F# Compiler
2+
3+
## Language and Environment
4+
- Use modern F# with functional-first approach
5+
- Target .NET Standard 2.0 for compatibility
6+
- Avoid external dependencies - the codebase is self-contained
7+
8+
## Code Style and Standards
9+
- Follow [coding standards](docs/coding-standards.md), especially:
10+
- Prefer immutability and pure functions
11+
- Use consistent naming (see abbreviation guide)
12+
- Process complex types recursively with pattern matching
13+
- Avoid single-character identifiers except in established patterns
14+
- This project uses .fsi signature files. When adding a new public API to a namespace/module which will be consumed from other file, add it to the respective .fsi signature file as well
15+
- Follow [overview](docs/overview.md) for key compiler data formats and representations
16+
17+
## Type System Handling
18+
- When working with `TType` instances, use appropriate stripping functions:
19+
- `stripTyparEqns` - Removes inference equations from type parameters
20+
- `stripTyEqns` - Removes type equations and type abbreviations
21+
- `stripTyEqnsAndErase` - Also erases compilation representations
22+
- Match the appropriate stripper to the context (e.g., display vs compilation)
23+
- Check equality with `typeEquiv` after stripping rather than direct comparison
24+
25+
## Core Data Structures
26+
- Use F# discriminated unions for type representations
27+
- Respect representation hiding through access control
28+
- Use `remapX` functions when transforming types across boundaries
29+
- Be aware of performance implications for recursive type operations
30+
31+
## Documentation and Naming
32+
- Document public APIs with XML comments
33+
- Use descriptive function names that indicate transformation direction
34+
- Follow established naming conventions in error messages

‎FSharp.Profiles.props

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,16 @@
66
<DefineConstants>BUILDING_WITH_LKG;$(DefineConstants)</DefineConstants>
77
</PropertyGroup>
88

9+
<PropertyGroup Condition="'$(MSBuildProjectExtension)' == '.fsproj' and $(TolerateUnusedBindings) != 'true'">
10+
<WarningsAsErrors>1182;$(WarningsAsErrors)</WarningsAsErrors>
11+
<WarnOn>1182;$(WarnOn)</WarnOn>
12+
</PropertyGroup>
13+
14+
<PropertyGroup Condition="'$(MSBuildProjectExtension)' == '.fsproj' and $(TolerateUnusedBindings) == 'true'">
15+
<WarningsNotAsErrors>1182;$(WarningsNotAsErrors)</WarningsNotAsErrors>
16+
<NoWarn>1182;$(NoWarn)</NoWarn>
17+
</PropertyGroup>
18+
919
<PropertyGroup Condition="'$(Configuration)' != 'Proto' and '$(BUILDING_USING_DOTNET)' != 'true' and '$(MSBuildProjectExtension)' == '.fsproj'"> <!-- VB.NET does not understand "preview". It only knows "old","older" and "boomer" :-)) (jk)-->
1020
<LangVersion>preview</LangVersion>
1121
</PropertyGroup>

‎FSharpBuild.Directory.Build.props

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,7 @@
2727
<SymStoreDirectory>$(ArtifactsDir)\SymStore</SymStoreDirectory>
2828
<ProtoOutputPath>$(ArtifactsDir)\Bootstrap</ProtoOutputPath>
2929
<ValueTupleImplicitPackageVersion>4.4.0</ValueTupleImplicitPackageVersion>
30-
<WarnOn>$(WarnOn);1182</WarnOn>
31-
<WarningsAsErrors>1182;0025;$(WarningsAsErrors)</WarningsAsErrors>
30+
<WarningsAsErrors>0025;$(WarningsAsErrors)</WarningsAsErrors>
3231
<OtherFlags>$(OtherFlags) --nowarn:3384</OtherFlags>
3332
<OtherFlags>$(OtherFlags) --times --nowarn:75</OtherFlags>
3433
<OtherFlags Condition="$(AdditionalFscCmdFlags) != ''">$(OtherFlags) $(AdditionalFscCmdFlags)</OtherFlags>

‎azure-pipelines-PR.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -208,6 +208,11 @@ stages:
208208
enablePublishBuildAssets: true
209209
enablePublishUsingPipelines: $(_PublishUsingPipelines)
210210
enableSourceBuild: true
211+
sourceBuildParameters:
212+
platforms:
213+
- name: 'Managed'
214+
container: 'mcr.microsoft.com/dotnet-buildtools/prereqs:centos-stream9'
215+
buildArguments: '--source-build'
211216
enableTelemetry: true
212217
helixRepo: dotnet/fsharp
213218
jobs:

‎azure-pipelines.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,11 @@ extends:
103103
enablePublishBuildAssets: true
104104
enablePublishUsingPipelines: $(_PublishUsingPipelines)
105105
enableSourceBuild: true
106+
sourceBuildParameters:
107+
platforms:
108+
- name: 'Managed'
109+
container: 'mcr.microsoft.com/dotnet-buildtools/prereqs:centos-stream9'
110+
buildArguments: '--source-build'
106111
enableTelemetry: true
107112
helixRepo: dotnet/fsharp
108113
jobs:

‎buildtools/fslex/fslex.fsproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
<TargetFramework>$(FSharpNetCoreProductTargetFramework)</TargetFramework>
66
<DisableImplicitFSharpCoreReference>true</DisableImplicitFSharpCoreReference>
77
<RollForward Condition="'$(BUILDING_USING_DOTNET)' == 'true'">LatestMajor</RollForward>
8-
<NoWarn>$(NoWarn);64;1204;1182</NoWarn> <!--Temporary fix for sourcebuild -->
9-
<OtherFlags>$(OtherFlags) --warnaserror-:1182</OtherFlags>
8+
<NoWarn>$(NoWarn);64;1204</NoWarn> <!--Temporary fix for sourcebuild -->
9+
<TolerateUnusedBindings>true</TolerateUnusedBindings>
1010
</PropertyGroup>
1111

1212
<PropertyGroup>

‎buildtools/fsyacc/fsyacc.fsproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
<TargetFramework>$(FSharpNetCoreProductTargetFramework)</TargetFramework>
66
<DisableImplicitFSharpCoreReference>true</DisableImplicitFSharpCoreReference>
77
<RollForward Condition="'$(BUILDING_USING_DOTNET)' == 'true'">LatestMajor</RollForward>
8-
<NoWarn>$(NoWarn);64;1204;1182</NoWarn> <!--Temporary fix for sourcebuild -->
9-
<OtherFlags>$(OtherFlags) --warnaserror-:1182</OtherFlags>
8+
<NoWarn>$(NoWarn);64;1204</NoWarn> <!--Temporary fix for sourcebuild -->
9+
<TolerateUnusedBindings>true</TolerateUnusedBindings>
1010
</PropertyGroup>
1111

1212
<PropertyGroup>

‎eng/Build.ps1

Lines changed: 8 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ param (
6868
[switch]$testBenchmarks,
6969
[string]$officialSkipTests = "false",
7070
[switch]$noVisualStudio,
71-
[switch]$sourceBuild,
71+
[switch][Alias('pb')]$productBuild,
7272
[switch]$skipBuild,
7373
[switch]$compressAllMetadata,
7474
[switch]$buildnorealsig = $true,
@@ -133,7 +133,7 @@ function Print-Usage() {
133133
Write-Host " -prepareMachine Prepare machine for CI run, clean up processes after build"
134134
Write-Host " -dontUseGlobalNuGetCache Do not use the global NuGet cache"
135135
Write-Host " -noVisualStudio Only build fsc and fsi as .NET Core applications. No Visual Studio required. '-configuration', '-verbosity', '-norestore', '-rebuild' are supported."
136-
Write-Host " -sourceBuild Simulate building for source-build."
136+
Write-Host " -productBuild Build the repository in product-build mode."
137137
Write-Host " -skipbuild Skip building product"
138138
Write-Host " -compressAllMetadata Build product with compressed metadata"
139139
Write-Host " -buildnorealsig Build product with realsig- (default use realsig+, where necessary)"
@@ -218,10 +218,6 @@ function Process-Arguments() {
218218
$script:pack = $True;
219219
}
220220

221-
if ($sourceBuild) {
222-
$script:testpack = $False;
223-
}
224-
225221
if ($noBinaryLog) {
226222
$script:binaryLog = $False;
227223
}
@@ -278,7 +274,7 @@ function Update-Arguments() {
278274
}
279275

280276

281-
function BuildSolution([string] $solutionName, $nopack) {
277+
function BuildSolution([string] $solutionName, $packSolution) {
282278
Write-Host "${solutionName}:"
283279

284280
$bl = if ($binaryLog) { "/bl:" + (Join-Path $LogDir "Build.$solutionName.binlog") } else { "" }
@@ -292,13 +288,11 @@ function BuildSolution([string] $solutionName, $nopack) {
292288
# Do not set the property to true explicitly, since that would override value projects might set.
293289
$suppressExtensionDeployment = if (!$deployExtensions) { "/p:DeployExtension=false" } else { "" }
294290

295-
$sourceBuildArgs = if ($sourceBuild) { "/p:DotNetBuildSourceOnly=true /p:DotNetBuildRepo=true" } else { "" }
296-
297291
$BUILDING_USING_DOTNET_ORIG = $env:BUILDING_USING_DOTNET
298292

299293
$env:BUILDING_USING_DOTNET="false"
300294

301-
$pack = if ($nopack -eq $False) {""} else {$pack}
295+
$pack = if ($packSolution -eq $False) {""} else {$pack}
302296

303297
MSBuild $toolsetBuildProj `
304298
$bl `
@@ -307,6 +301,7 @@ function BuildSolution([string] $solutionName, $nopack) {
307301
/p:RepoRoot=$RepoRoot `
308302
/p:Restore=$restore `
309303
/p:Build=$build `
304+
/p:DotNetBuildRepo=$productBuild `
310305
/p:Rebuild=$rebuild `
311306
/p:Pack=$pack `
312307
/p:Sign=$sign `
@@ -319,7 +314,6 @@ function BuildSolution([string] $solutionName, $nopack) {
319314
/p:CompressAllMetadata=$CompressAllMetadata `
320315
/p:BuildNoRealsig=$buildnorealsig `
321316
/v:$verbosity `
322-
$sourceBuildArgs `
323317
$suppressExtensionDeployment `
324318
@properties
325319

@@ -567,7 +561,7 @@ try {
567561
}
568562

569563
$script:BuildMessage = "Failure building product"
570-
if ($restore -or $build -or $rebuild -or $pack -or $sign -or $publish -and -not $skipBuild -and -not $sourceBuild) {
564+
if ($restore -or $build -or $rebuild -or $pack -or $sign -or $publish -and -not $skipBuild -and -not $productBuild) {
571565
$originalSignValue = $sign
572566
if ($msbuildEngine -eq "dotnet") {
573567
# Building FSharp.sln and VisualFSharp.sln with .NET Core MSBuild
@@ -587,7 +581,8 @@ try {
587581
BuildSolution "FSharp.Benchmarks.sln" $False
588582
}
589583

590-
if ($pack) {
584+
# When building in product build mode, only build the compiler solution.
585+
if ($pack -or $productBuild) {
591586
$properties_storage = $properties
592587
BuildSolution "Microsoft.FSharp.Compiler.sln" $True
593588
$properties = $properties_storage

‎eng/DotNetBuild.props

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,11 @@
11
<!-- When altering this file, include @dotnet/product-construction as a reviewer. -->
2-
32
<Project>
43

54
<PropertyGroup>
65
<GitHubRepositoryName>fsharp</GitHubRepositoryName>
76
<SourceBuildManagedOnly>true</SourceBuildManagedOnly>
87
</PropertyGroup>
98

10-
<!--
11-
The build script passes in the full path of the sln to build. This must be overridden in order to build
12-
the cloned source in the inner build.
13-
-->
14-
<Target Name="ConfigureInnerBuildArg"
15-
BeforeTargets="GetSourceBuildCommandConfiguration">
16-
<PropertyGroup>
17-
<InnerBuildArgs>$(InnerBuildArgs) /p:Projects="$(InnerSourceBuildRepoRoot)\Microsoft.FSharp.Compiler.sln"</InnerBuildArgs>
18-
</PropertyGroup>
19-
</Target>
20-
219
<!--
2210
The build script bootstraps some tooling for the build. Since the inner build is triggerred via msbuild,
2311
trigger the bootstrapping for the inner build.
@@ -26,7 +14,6 @@
2614
DependsOnTargets="PrepareInnerSourceBuildRepoRoot"
2715
BeforeTargets="RunInnerSourceBuildCommand"
2816
Condition="'$(DotNetBuildSourceOnly)' == 'true'">
29-
3017
<PropertyGroup>
3118
<SourceBuildBootstrapTfmArg Condition="$(SourceBuildBootstrapTfm) != ''">--tfm $(SourceBuildBootstrapTfm)</SourceBuildBootstrapTfmArg>
3219
<DotNetBuildUseMonoRuntime Condition="'$(DotNetBuildUseMonoRuntime)' == ''">false</DotNetBuildUseMonoRuntime>

‎eng/build.sh

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,8 @@ usage()
3535
echo " --skipAnalyzers Do not run analyzers during build operations"
3636
echo " --skipBuild Do not run the build"
3737
echo " --prepareMachine Prepare machine for CI run, clean up processes after build"
38-
echo " --sourceBuild Simulate building for source-build"
38+
echo " --sourceBuild Build the repository in source-only mode."
39+
echo " --productBuild Build the repository in product-build mode."
3940
echo " --buildnorealsig Build product with realsig- (default use realsig+ where necessary)"
4041
echo " --tfm Override the default target framework"
4142
echo ""
@@ -73,6 +74,7 @@ skip_analyzers=false
7374
skip_build=false
7475
prepare_machine=false
7576
source_build=false
77+
product_build=false
7678
buildnorealsig=true
7779
properties=""
7880

@@ -161,8 +163,12 @@ while [[ $# > 0 ]]; do
161163
--docker)
162164
docker=true
163165
;;
164-
--sourcebuild)
166+
--sourcebuild|--source-build|-sb)
165167
source_build=true
168+
product_build=true
169+
;;
170+
--productbuild|--product-build|-pb)
171+
product_build=true
166172
;;
167173
--buildnorealsig)
168174
buildnorealsig=true
@@ -238,6 +244,9 @@ function BuildSolution {
238244
fi
239245

240246
local projects="$repo_root/FSharp.sln"
247+
if [[ "$product_build" = true ]]; then
248+
projects="$repo_root/Microsoft.FSharp.Compiler.sln"
249+
fi
241250

242251
echo "$projects:"
243252

@@ -247,11 +256,6 @@ function BuildSolution {
247256
if [[ "$UNAME" == "Darwin" ]]; then
248257
enable_analyzers=false
249258
fi
250-
251-
local source_build_args=""
252-
if [[ "$source_build" == true ]]; then
253-
source_build_args="/p:DotNetBuildRepo=true /p:DotNetBuildSourceOnly=true"
254-
fi
255259

256260
# NuGet often exceeds the limit of open files on Mac and Linux
257261
# https://github.com/NuGet/Home/issues/2163
@@ -285,7 +289,7 @@ function BuildSolution {
285289
fi
286290

287291
BuildMessage="Error building tools"
288-
local args=" publish $repo_root/proto.proj $blrestore $bltools /p:Configuration=Proto $source_build_args $properties"
292+
local args=" publish $repo_root/proto.proj $blrestore $bltools /p:Configuration=Proto /p:DotNetBuildRepo=$product_build /p:DotNetBuildSourceOnly=$source_build $properties"
289293
echo $args
290294
"$DOTNET_INSTALL_DIR/dotnet" $args #$args || exit $?
291295
fi
@@ -309,7 +313,8 @@ function BuildSolution {
309313
/p:QuietRestore=$quiet_restore \
310314
/p:QuietRestoreBinaryLog="$binary_log" \
311315
/p:BuildNoRealsig=$buildnorealsig \
312-
$source_build_args \
316+
/p:DotNetBuildRepo=$product_build \
317+
/p:DotNetBuildSourceOnly=$source_build \
313318
$properties
314319
fi
315320
}

‎eng/common/core-templates/job/source-build.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,8 @@ parameters:
2626
# Specifies the build script to invoke to perform the build in the repo. The default
2727
# './build.sh' should work for typical Arcade repositories, but this is customizable for
2828
# difficult situations.
29+
# buildArguments: ''
30+
# Specifies additional build arguments to pass to the build script.
2931
# jobProperties: {}
3032
# A list of job properties to inject at the top level, for potential extensibility beyond
3133
# container and pool.

‎eng/common/core-templates/steps/source-build.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@ steps:
7979
${{ coalesce(parameters.platform.buildScript, './build.sh') }} --ci \
8080
--configuration $buildConfig \
8181
--restore --build --pack $publishArgs -bl \
82+
${{ parameters.platform.buildArguments }} \
8283
$officialBuildArgs \
8384
$internalRuntimeDownloadArgs \
8485
$internalRestoreArgs \

‎src/FSharp.Core/FSharp.Core.fsproj

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,6 @@
1313
<DefineConstants>$(DefineConstants);FSHARP_CORE</DefineConstants>
1414
<!-- 3218: ArgumentsInSigAndImplMismatch -->
1515
<OtherFlags>$(OtherFlags) --warnon:3218</OtherFlags>
16-
<!-- 1182: Unused variables -->
17-
<OtherFlags>$(OtherFlags) --warnon:1182</OtherFlags>
1816
<!-- 3390: xmlDocBadlyFormed -->
1917
<OtherFlags>$(OtherFlags) --warnon:3390</OtherFlags>
2018
<!-- 3520: invalidXmlDocPosition -->

‎src/fsi/fsi.targets

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
<Configurations>Debug;Release;Proto</Configurations>
88
<NoWarn>$(NoWarn);44</NoWarn> <!-- Obsolete -->
99
<AllowCrossTargeting>true</AllowCrossTargeting>
10-
<OtherFlags>$(OtherFlags) --warnon:1182</OtherFlags>
1110
<Win32Resource>$(MSBuildThisFileDirectory)fsi.res</Win32Resource>
1211
</PropertyGroup>
1312

‎tests/FSharp.Compiler.ComponentTests/FSharp.Compiler.ComponentTests.fsproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
<ExcludeFromSourceOnlyBuild>true</ExcludeFromSourceOnlyBuild>
1414
<Optimize>false</Optimize>
1515
<Tailcalls>false</Tailcalls>
16-
<OtherFlags>$(OtherFlags) --warnon:1182</OtherFlags>
1716
<NoWarn>$(NoWarn);FS0988</NoWarn> <!-- "program does nothing" warning -->
1817
<DefineConstants Condition="'$(Configuration)'=='release'">$(DefineConstants);RELEASE</DefineConstants>
1918
<DefineConstants Condition="'$(Configuration)'=='debug'">$(DefineConstants);DEBUG</DefineConstants>

‎tests/FSharp.Compiler.Service.Tests/FSharp.Compiler.Service.Tests.fsproj

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,7 @@
55
<TargetFrameworks>net472;$(FSharpNetCoreProductTargetFramework)</TargetFrameworks>
66
<TargetFrameworks Condition="'$(OS)' == 'Unix' or '$(BUILDING_USING_DOTNET)' == 'true'">$(FSharpNetCoreProductTargetFramework)</TargetFrameworks>
77
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
8-
<NoWarn>$(NoWarn);1182</NoWarn> <!-- suppress warning for unused values in FSharp.Compiler.Service.Tests tests, very often checker results are needed, but not used -->
9-
<OtherFlags>$(OtherFlags) --warnaserror-:1182</OtherFlags>
8+
<TolerateUnusedBindings>true</TolerateUnusedBindings>
109
<DisableImplicitFSharpCoreReference>true</DisableImplicitFSharpCoreReference>
1110
<UnitTestType>xunit</UnitTestType>
1211
</PropertyGroup>

‎tests/FSharp.Core.UnitTests/FSharp.Core.UnitTests.fsproj

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,7 @@
1212
<PackageVersion>$(FSCoreUnitTestsPackageVersion)</PackageVersion>
1313
<PreRelease>true</PreRelease>
1414
<LangVersion>preview</LangVersion>
15-
<NoWarn>$(NoWarn);1182</NoWarn> <!-- suppress warning for unused values in FSharp.Core tests, there are way too many of edge case scenarios tested -->
16-
<OtherFlags>$(OtherFlags) --warnaserror-:1182</OtherFlags>
15+
<TolerateUnusedBindings>true</TolerateUnusedBindings>
1716
<DisableImplicitFSharpCoreReference>true</DisableImplicitFSharpCoreReference>
1817
<UnitTestType>xunit</UnitTestType>
1918
<IsTestProject>true</IsTestProject>

‎tests/FSharp.Test.Utilities/FSharp.Test.Utilities.fsproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
<Tailcalls>false</Tailcalls>
1313
<UnitTestType>xunit</UnitTestType>
1414
<IsTestProject>true</IsTestProject>
15-
<OtherFlags>$(OtherFlags) --warnon:1182 --realsig-</OtherFlags>
15+
<OtherFlags>$(OtherFlags) --realsig-</OtherFlags>
1616
<CopyLocalLockFileAssemblies>true</CopyLocalLockFileAssemblies>
1717
<!--Extra xUnit customizations, not required for the test suite to work, but can speed up local test runs and help with debugging.-->
1818
<DefineConstants>XUNIT_EXTRAS</DefineConstants>

‎tests/fsharp/FSharpSuite.Tests.fsproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
<DisableImplicitFSharpCoreReference>true</DisableImplicitFSharpCoreReference>
1212
<Optimize>false</Optimize>
1313
<Tailcalls>false</Tailcalls>
14-
<OtherFlags>$(OtherFlags) --warnon:1182 --langversion:preview</OtherFlags>
14+
<OtherFlags>$(OtherFlags) --langversion:preview</OtherFlags>
1515
<UnitTestType>xunit</UnitTestType>
1616
<NoWarn>3186</NoWarn>
1717
</PropertyGroup>

‎vsintegration/src/FSharp.Editor/FSharp.Editor.fsproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
<NoWarn>$(NoWarn);75</NoWarn>
88
<NoWarn>$(NoWarn);44</NoWarn><!-- warning about Roslyn API only for F# and TypeScript -->
99
<DisableImplicitFSharpCoreReference>true</DisableImplicitFSharpCoreReference>
10-
<OtherFlags>$(OtherFlags) --warnon:1182 --subsystemversion:6.00</OtherFlags>
10+
<OtherFlags>$(OtherFlags) --subsystemversion:6.00</OtherFlags>
1111
<EnableDefaultEmbeddedResourceItems>false</EnableDefaultEmbeddedResourceItems>
1212
</PropertyGroup>
1313

‎vsintegration/src/FSharp.LanguageService/FSharp.LanguageService.fsproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
<NoWarn>$(NoWarn);75</NoWarn>
88
<NoWarn>$(NoWarn);44</NoWarn><!-- warning about Roslyn API only for F# and TypeScript -->
99
<DisableImplicitFSharpCoreReference>true</DisableImplicitFSharpCoreReference>
10-
<OtherFlags>$(OtherFlags) --warnon:1182 --subsystemversion:6.00</OtherFlags>
10+
<OtherFlags>$(OtherFlags) --subsystemversion:6.00</OtherFlags>
1111
<EnableDefaultEmbeddedResourceItems>false</EnableDefaultEmbeddedResourceItems>
1212
</PropertyGroup>
1313

0 commit comments

Comments
 (0)