Skip to content

Installer repo should explore using arcade tasks for msi generation #12101

Open
@mmitche

Description

The installer repo uses a series of powershell scripts for msi generation right now. These then have to be kept in line with the light command package drop creation (if inputs change). They're also generally hard to understand (from a command line standpoint) since they pull in about 20 unnamed parameters. For example:

    <Exec Command="powershell -NoProfile -NoLogo $(SdkGenerateBundlePowershellScript) ^
                      '$(SdkMSIInstallerFile)' ^
                      '$(DownloadsFolder)$(DownloadedAspNetCoreSharedFxWixLibFileName)' ^
                      '$(DownloadsFolder)$(DownloadedSharedFrameworkInstallerFileName)' ^
                      '$(DownloadsFolder)$(DownloadedHostFxrInstallerFileName)' ^
                      '$(DownloadsFolder)$(DownloadedSharedHostInstallerFileName)' ^
                      '$(DownloadsFolder)$(DownloadedWinFormsAndWpfSharedFrameworkInstallerFileName)' ^
                      '$(DownloadsFolder)$(DownloadedNetCoreAppTargetingPackInstallerFileName)' ^
                      '$(DownloadsFolder)$(DownloadedNetStandardTargetingPackInstallerFileName)' ^
                      '$(DownloadsFolder)$(DownloadedNetCoreAppHostPackInstallerFileName)' ^
                      '$(DownloadsFolder)$(DownloadedAlternateNetCoreAppHostPackInstallerFileName)' ^
                      '$(DownloadsFolder)$(DownloadedArmNetCoreAppHostPackInstallerFileName)' ^
                      '$(DownloadsFolder)$(DownloadedArm64NetCoreAppHostPackInstallerFileName)' ^
                      '$(DownloadsFolder)$(DownloadedAspNetTargetingPackInstallerFileName)' ^
                      '$(DownloadsFolder)$(DownloadedWindowsDesktopTargetingPackInstallerFileName)' ^
                      '$(FinalizerExe)' ^
                      '$(LatestTemplateMsiInstallerFile)' ^
                      '$(ManifestsMsiInstallerFile)' ^
                      '$(CombinedFrameworkSdkHostMSIInstallerFile)' ^
                      '$(WixRoot)' ^
                      '$(SdkBrandName)' ^
                      '$(MsiVersion)' ^
                      '$(SDKBundleVersion)' ^
                      '$(Version)' ^
                      '$(MicrosoftWindowsDesktopAppRuntimePackageVersion)' ^
                      '$(CombinedFrameworkSDKHostInstallerUpgradeCode)' ^
                      '$(SdkDependencyKeyName)' ^
                      '$(Architecture)' ^
                      '$(MicrosoftNETCoreAppRuntimePackageVersion)' ^
                      '$(MicrosoftAspNetCoreAppRuntimePackageVersion)' ^
                      '$(CliProductBandVersion)' ^
                      -InformationAction Continue " />

It would be much better to use the built in tasks (and improve them if necessary), for the following reasons:

  • Central versioning of the WiX tooling
  • Automatic light package generation
  • Less custom code.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions