Skip to content

Commit 9c867ff

Browse files
authored
LibGpiodV2 is no longer experimental (#2482)
* Remove some strange Unicode characters from file * Remove some obsolete error messages * LibGpiodV2Driver and all it's subclasses are no longer experimental * Remove some more experimental flags, update documentation
1 parent f8d124f commit 9c867ff

35 files changed

Lines changed: 59 additions & 168 deletions

Documentation/DiagnosticIDs.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@ Some of the APIs in this repository are still in development and may be changed
66

77
| Diagnostic ID | Description |
88
| :---------------- | :---------- |
9-
| `SDGPIO0001` | Experimental APIs related to LibGpiod v2 driver used by newer versions of the library |
9+
| `SDGPIO0001` | Experimental APIs that might be removed or changed in future |

src/System.Device.Gpio.Tests/LibGpiodV1DriverTests.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@
99

1010
namespace System.Device.Gpio.Tests;
1111

12-
#pragma warning disable SDGPIO0001
13-
1412
[Trait("feature", "gpio")]
1513
[Trait("feature", "gpio-libgpiod")]
1614
[Trait("SkipOnTestRun", "Windows_NT")]

src/System.Device.Gpio.Tests/LibGpiodV2DriverTests.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
using Xunit;
99
using Xunit.Abstractions;
1010

11-
#pragma warning disable SDGPIO0001
1211
namespace System.Device.Gpio.Tests;
1312

1413
[Trait("feature", "gpio")]
@@ -117,6 +116,5 @@ public void InputPullResistorsWork()
117116
}
118117
}
119118

120-
#pragma warning disable SDGPIO0001
121119
protected override GpioDriver GetTestDriver() => new LibGpiodV2Driver(ChipNumber);
122120
}

src/System.Device.Gpio.Tests/SysFsDriverTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
using Xunit;
77
using Xunit.Abstractions;
88

9-
#pragma warning disable SDGPIO0001
109
namespace System.Device.Gpio.Tests;
1110

1211
[Trait("requirement", "root")]

src/System.Device.Gpio/Interop/Unix/libgpiod/V2/Proxies/Chip.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ namespace System.Device.Gpio.Libgpiod.V2;
1414
/// allows callers to retrieve information about each line, watch lines for state changes and make line requests.
1515
/// </summary>
1616
/// <seealso href="https://libgpiod.readthedocs.io/en/latest/group__chips.html"/>
17-
[Experimental(DiagnosticIds.SDGPIO0001, UrlFormat = DiagnosticIds.UrlFormat)]
1817
internal class Chip : LibGpiodProxyBase
1918
{
2019
private readonly int _chipNumber;

src/System.Device.Gpio/Interop/Unix/libgpiod/V2/Proxies/EdgeEvent.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ namespace System.Device.Gpio.Libgpiod.V2;
1414
/// of events are being read.
1515
/// </summary>
1616
/// <seealso href="https://libgpiod.readthedocs.io/en/latest/group__edge__event.html"/>
17-
[Experimental(DiagnosticIds.SDGPIO0001, UrlFormat = DiagnosticIds.UrlFormat)]
1817
internal class EdgeEvent : LibGpiodProxyBase
1918
{
2019
private readonly EdgeEventSafeHandle _handle;

src/System.Device.Gpio/Interop/Unix/libgpiod/V2/Proxies/EdgeEventBuffer.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ namespace System.Device.Gpio.Libgpiod.V2;
1414
/// of events are being read.
1515
/// </summary>
1616
/// <seealso href="https://libgpiod.readthedocs.io/en/latest/group__edge__event.html"/>
17-
[Experimental(DiagnosticIds.SDGPIO0001, UrlFormat = DiagnosticIds.UrlFormat)]
1817
internal class EdgeEventBuffer : LibGpiodProxyBase
1918
{
2019
internal EdgeEventBufferSafeHandle Handle { get; }

src/System.Device.Gpio/Interop/Unix/libgpiod/V2/Proxies/LibGpiodChipInfo.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ namespace System.Device.Gpio.Libgpiod.V2;
1212
/// The chip info contains all the publicly available information about a chip.
1313
/// </summary>
1414
/// <seealso href="https://libgpiod.readthedocs.io/en/latest/group__chip__info.html"/>
15-
[Experimental(DiagnosticIds.SDGPIO0001, UrlFormat = DiagnosticIds.UrlFormat)]
1615
internal class LibGpiodChipInfo : LibGpiodProxyBase
1716
{
1817
private readonly int _chipNumber;
@@ -69,7 +68,6 @@ public int GetNumLines()
6968
/// Helper function for capturing information and creating an immutable snapshot instance.
7069
/// </summary>
7170
/// <exception cref="GpiodException">Unexpected error when invoking native function</exception>
72-
[Experimental(DiagnosticIds.SDGPIO0001, UrlFormat = DiagnosticIds.UrlFormat)]
7371
public GpioChipInfo MakeSnapshot()
7472
{
7573
return new GpioChipInfo(_chipNumber, GetName(), GetLabel(), GetNumLines());

src/System.Device.Gpio/Interop/Unix/libgpiod/V2/Proxies/LibGpiodProxyBase.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77

88
namespace System.Device.Gpio.Libgpiod.V2;
99

10-
[Experimental(DiagnosticIds.SDGPIO0001, UrlFormat = DiagnosticIds.UrlFormat)]
1110
internal abstract class LibGpiodProxyBase : IDisposable
1211
{
1312
/// <remarks>

src/System.Device.Gpio/Interop/Unix/libgpiod/V2/Proxies/LibGpiodProxyFactory.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88

99
namespace System.Device.Gpio.Libgpiod.V2;
1010

11-
[Experimental(DiagnosticIds.SDGPIO0001, UrlFormat = DiagnosticIds.UrlFormat)]
1211
internal static class LibGpiodProxyFactory
1312
{
1413
/// <summary>

0 commit comments

Comments
 (0)