Resize image transformer cannot handle images with unknown pixel format. (#3612)

* Detect invalid pixel format.

* Add test.

* Force convert pixel format to Format32bppArgb in ImageResize transform.

* Fix comment..

* Convert image pixel format to Format32bppArgb in ImagePixelExtractor transform if there is a need.

* fix test.

* Update taco image license information.

* cleanup.

Author: codemzs

src/Microsoft.ML.ImageAnalytics/ImagePixelExtractor.cs

@@ -5,6 +5,7 @@
 using System;
 using System.Collections.Generic;
 using System.Drawing;
+using System.Drawing.Imaging;
 using System.Linq;
 using System.Runtime.InteropServices;
 using System.Text;
@@ -346,11 +347,15 @@ private ValueGetter<VBuffer<TValue>> GetGetterCore<TValue>(DataViewRow input, in
                             return;
                         }
 
-                        Host.Check(src.PixelFormat == System.Drawing.Imaging.PixelFormat.Format32bppArgb
-                            || src.PixelFormat == System.Drawing.Imaging.PixelFormat.Format24bppRgb,
-                            "Transform only supports pixel formats Format24bppRgb and Format32bppArgb");
                         Host.Check(src.Height == height && src.Width == width);
 
+                        if (src.PixelFormat != PixelFormat.Format32bppArgb && src.PixelFormat != PixelFormat.Format24bppRgb)
+                        {
+                            var clone = src.Clone(new Rectangle(0, 0, src.Width, src.Height), PixelFormat.Format32bppArgb);
+                            src.Dispose();
+                            src = clone;
+                        }
+
                         var editor = VBufferEditor.Create(ref dst, size);
                         var values = editor.Values;
 

src/Microsoft.ML.ImageAnalytics/ImageResizer.cs

@@ -384,8 +384,16 @@ protected override Delegate MakeGetter(DataViewRow input, int iinfo, Func<int, b
 
                         // Graphics.DrawImage() does not support PixelFormat.Indexed. Hence convert the
                         // pixel format to Format32bppArgb as described here https://stackoverflow.com/questions/17313285/graphics-on-indexed-image
-                        if ((src.PixelFormat & PixelFormat.Indexed) != 0)
+                        // For images with invalid pixel format also use Format32bppArgb to draw the resized image.
+                        // For images with Format16bppGrayScale or Format16bppArgb1555 GDI+ does not
+                        // support these formats, ref: https://bytes.com/topic/c-sharp/answers/278572-out-memory-graphics-fromimage
+                        if ((src.PixelFormat & PixelFormat.Indexed) != 0 ||
+                            src.PixelFormat == PixelFormat.Format16bppGrayScale ||
+                            src.PixelFormat == PixelFormat.Format16bppArgb1555 ||
+                            !Enum.IsDefined(typeof(PixelFormat), src.PixelFormat))
+                        {
                             dst = new Bitmap(info.ImageWidth, info.ImageHeight);
+                        }
                         else
                             dst = new Bitmap(info.ImageWidth, info.ImageHeight, src.PixelFormat);
 

test/Microsoft.ML.Tests/ScenariosWithDirectInstantiation/TensorflowTests.cs

@@ -874,7 +874,7 @@ public void TensorFlowTransformCifar()
                     Assert.Equal(10, buffer.Length);
                     numRows += 1;
                 }
-                Assert.Equal(5, numRows);
+                Assert.Equal(7, numRows);
             }
         }
 

test/data/README.md

@@ -112,4 +112,6 @@ The dataset is distributed under [GPLv2](https://www.gnu.org/licenses/old-licens
 >
 > "[Hot dog with mustard](https://visualsonline.cancer.gov/details.cfm?imageid=2669)" by Renee Comet is in the public domain - this image was released by the [National Cancer Institute](https://visualsonline.cancer.gov/details.cfm?imageid=2669)
 >
-> "[Bright red tomato and cross section02](https://upload.wikimedia.org/wikipedia/commons/8/88/Bright_red_tomato_and_cross_section02.jpg)" by [fir0002](https://en.wikipedia.org/wiki/User:Fir0002) is licensed under the [CC BY-NC](https://creativecommons.org/licenses/by/2.0/)
+> "[Bright red tomato and cross section02](https://upload.wikimedia.org/wikipedia/commons/8/88/Bright_red_tomato_and_cross_section02.jpg)" by [fir0002](https://en.wikipedia.org/wiki/User:Fir0002) is licensed under the [CC BY-NC](https://creativecommons.org/licenses/by/2.0/)
+>
+> "[Grilled Portabella and Poblano Tacos](https://www.foodista.com/sites/default/files/78307aH.jpg)" by [foodista](https://www.foodista.com) is licensed under the [CC BY-NC](https://creativecommons.org/licenses/by/2.0/) as per [Bing Images search using All Creative Commons license filter](https://www.bing.com/images/search?q=78307aH&qs=n&form=QBIR&qft=%20filterui%3AlicenseType-Any&sp=-1&pq=78307ah&sc=8-7&sk=&cvid=C44379B4A4FA42C09D7629976997390C)

test/data/images/imagesmixedpixelformat.tsv

@@ -2,4 +2,6 @@ tomato.bmp	tomato
 banana.jpg	banana
 hotdog.jpg	hotdog
 tomato.jpg	tomato
-tomato_indexedpixelformat.gif	tomato
+tomato_indexedpixelformat.gif	tomato
+tomato_format32bppPArgb.jpg	tomato
+taco_invalidpixelformat.jpg	taco