Skip to content

Commit 35daa31

Browse files
committed
Merge remote-tracking branch 'origin/net11.0' into darc-net11.0-3e74f8e9-3f00-4c8f-9965-537c03a27a5a
2 parents 39ffbb6 + fbf9398 commit 35daa31

File tree

2 files changed

+10
-14
lines changed

2 files changed

+10
-14
lines changed

dotnet/targets/Xamarin.Shared.Sdk.targets

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1211,12 +1211,13 @@
12111211
<_IsDedupEnabled Condition="'$(_IsDedupEnabled)' == '' And '$(_RunAotCompiler)' == 'true' And '$(IsMacEnabled)' == 'true' And '$(TargetArchitectures)' == 'ARM64' And '$(MtouchInterpreter)' != 'all'">true</_IsDedupEnabled>
12121212
<_DedupAssembly Condition="'$(_IsDedupEnabled)' == 'true'">$(IntermediateOutputPath)aot-instances.dll</_DedupAssembly>
12131213

1214-
<!-- This property isn't accurate with CoreCLR, it should probably be renamed to something like '_LibRuntimeLinkMode' at some point -->
1215-
<_LibMonoLinkMode Condition="'$(_LibMonoLinkMode)' == '' And '$(UseMonoRuntime)' == 'false'">dylib</_LibMonoLinkMode>
12161214
<!-- default to 'static' for Mac Catalyst to work around https://github.com/dotnet/macios/issues/14686 -->
1217-
<_LibMonoLinkMode Condition="'$(_LibMonoLinkMode)' == '' And '$(_PlatformName)' == 'MacCatalyst'">static</_LibMonoLinkMode>
1218-
<_LibMonoLinkMode Condition="'$(_LibMonoLinkMode)' == '' And '$(ComputedPlatform)' != 'iPhone'">dylib</_LibMonoLinkMode>
1219-
<_LibMonoLinkMode Condition="'$(_LibMonoLinkMode)' == ''">static</_LibMonoLinkMode>
1215+
<_LibMonoLinkMode Condition="'$(_LibMonoLinkMode)' == '' And '$(_PlatformName)' == 'MacCatalyst' And '$(UseMonoRuntime)' == 'true'">static</_LibMonoLinkMode>
1216+
<!-- temporarily use 'dylib' for CoreCLR on mobile because we need to implement .dylib -> .framework conversion to use 'static' -->
1217+
<_LibMonoLinkMode Condition="'$(_LibMonoLinkMode)' == '' And ('$(_PlatformName)' == 'iOS' Or '$(_PlatformName)' == 'tvOS') And '$(_XamarinRuntime)' == 'CoreCLR'">dylib</_LibMonoLinkMode>
1218+
<!-- we can't use dylibs for mobile apps when building for device, because the App Store won't allow it -->
1219+
<_LibMonoLinkMode Condition="'$(_LibMonoLinkMode)' == '' And '$(ComputedPlatform)' == 'iPhone'">static</_LibMonoLinkMode>
1220+
<_LibMonoLinkMode Condition="'$(_LibMonoLinkMode)' == ''">dylib</_LibMonoLinkMode>
12201221
<_LibMonoExtension Condition="'$(_LibMonoLinkMode)' == 'dylib'">dylib</_LibMonoExtension>
12211222
<_LibMonoExtension Condition="'$(_LibMonoLinkMode)' == 'static'">a</_LibMonoExtension>
12221223

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,8 @@
1-
AppBundleSize: 3,909,630 bytes (3,818.0 KB = 3.7 MB)
1+
AppBundleSize: 2,483,703 bytes (2,425.5 KB = 2.4 MB)
22
# The following list of files and their sizes is just informational / for review, and isn't used in the test:
3-
_CodeSignature/CodeResources: 3,879 bytes (3.8 KB = 0.0 MB)
3+
_CodeSignature/CodeResources: 2,589 bytes (2.5 KB = 0.0 MB)
44
archived-expanded-entitlements.xcent: 384 bytes (0.4 KB = 0.0 MB)
5-
Info.plist: 1,167 bytes (1.1 KB = 0.0 MB)
6-
libSystem.Globalization.Native.dylib: 110,512 bytes (107.9 KB = 0.1 MB)
7-
libSystem.IO.Compression.Native.dylib: 891,856 bytes (871.0 KB = 0.9 MB)
8-
libSystem.Native.dylib: 163,696 bytes (159.9 KB = 0.2 MB)
9-
libSystem.Net.Security.Native.dylib: 88,336 bytes (86.3 KB = 0.1 MB)
10-
libSystem.Security.Cryptography.Native.Apple.dylib: 218,256 bytes (213.1 KB = 0.2 MB)
5+
Info.plist: 1,138 bytes (1.1 KB = 0.0 MB)
116
PkgInfo: 8 bytes (0.0 KB = 0.0 MB)
127
runtimeconfig.bin: 1,808 bytes (1.8 KB = 0.0 MB)
13-
SizeTestApp: 2,429,728 bytes (2,372.8 KB = 2.3 MB)
8+
SizeTestApp: 2,477,776 bytes (2,419.7 KB = 2.4 MB)

0 commit comments

Comments
 (0)