Skip to content

Commit dd844b5

Browse files
committed
Don't pass -buildVersion ... -architectureVariant ... quite yet.
1 parent c952dad commit dd844b5

File tree

1 file changed

+14
-9
lines changed

1 file changed

+14
-9
lines changed

system-dependencies.sh

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -319,6 +319,7 @@ function xcodebuild_download_selected_platforms ()
319319
local XCODE_DEVELOPER_ROOT
320320
local XCODE_NAME
321321
local XCODE_IS_STABLE
322+
local XCODE_VERSION
322323
local IOS_NUGET_OS_VERSION
323324
local IOS_BUILD_VERSION
324325
local TVOS_NUGET_OS_VERSION
@@ -328,19 +329,23 @@ function xcodebuild_download_selected_platforms ()
328329
XCODE_NAME=$(basename "$(dirname "$(dirname "$XCODE_DEVELOPER_ROOT")")")
329330
# we use the same logic here as in Make.config to determine whether we're using a stable version of Xcode or not (search for XCODE_IS_STABLE/XCODE_IS_PREVIEW)
330331
XCODE_IS_STABLE=$(echo "$XCODE_NAME" | sed -e 's@^Xcode[_0-9.]*[.]app$@YES@')
332+
XCODE_VERSION=$(grep ^XCODE_VERSION= Make.config | sed 's/.*=//')
331333

332334
IOS_BUILD_VERSION=
333335
TVOS_BUILD_VERSION=
334-
if [[ "$XCODE_IS_STABLE" == "YES" ]]; then
335-
if [[ "$(arch)" == "arm64" ]]; then
336-
ARCHITECTURE_VARIANT=arm64
337-
else
338-
ARCHITECTURE_VARIANT=universal
336+
if is_at_least_version "$XCODE_VERSION" 26.1; then
337+
# passing -buildVersion .. --architectureVariant .. doesn't quite work in Xcode 26.0 (it works the first time, but then it always thinks it's the first time, tries to download and install, and gets confused), let's see if they fix it in Xcode 26.1
338+
if [[ "$XCODE_IS_STABLE" == "YES" ]]; then
339+
if [[ "$(arch)" == "arm64" ]]; then
340+
ARCHITECTURE_VARIANT=arm64
341+
else
342+
ARCHITECTURE_VARIANT=universal
343+
fi
344+
IOS_NUGET_OS_VERSION=$(grep '^IOS_NUGET_OS_VERSION=' Make.versions | sed 's/.*=//')
345+
IOS_BUILD_VERSION=" -buildVersion $IOS_NUGET_OS_VERSION -architectureVariant $ARCHITECTURE_VARIANT"
346+
TVOS_NUGET_OS_VERSION=$(grep '^TVOS_NUGET_OS_VERSION=' Make.versions | sed 's/.*=//')
347+
TVOS_BUILD_VERSION=" -buildVersion $TVOS_NUGET_OS_VERSION -architectureVariant $ARCHITECTURE_VARIANT"
339348
fi
340-
IOS_NUGET_OS_VERSION=$(grep '^IOS_NUGET_OS_VERSION=' Make.versions | sed 's/.*=//')
341-
IOS_BUILD_VERSION=" -buildVersion $IOS_NUGET_OS_VERSION -architectureVariant $ARCHITECTURE_VARIANT"
342-
TVOS_NUGET_OS_VERSION=$(grep '^TVOS_NUGET_OS_VERSION=' Make.versions | sed 's/.*=//')
343-
TVOS_BUILD_VERSION=" -buildVersion $TVOS_NUGET_OS_VERSION -architectureVariant $ARCHITECTURE_VARIANT"
344349
fi
345350

346351
log "Executing '$XCODE_DEVELOPER_ROOT/usr/bin/xcodebuild -downloadPlatform iOS$IOS_BUILD_VERSION' $1"

0 commit comments

Comments
 (0)