-
Notifications
You must be signed in to change notification settings - Fork 554
[GLKit] Fix nullability for GLKMesh.FromAssets. #24498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Also add a missing [return: Release] attribute.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes nullability annotations and adds a missing memory management attribute for the GLKMesh.FromAsset method.
Changes:
- Added
[return: Release]attribute to the internalFromAssetbinding to properly handle memory management for Objective-C "new" family methods - Updated nullability annotations on out parameters in both the binding definition and wrapper method to be nullable
- Removed the corresponding warnings from xtro-sharpie ignore files for iOS, macOS, and tvOS
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/glkit.cs | Added [return: Release] attribute and [NullAllowed] attributes to out parameters for the internal FromAsset binding |
| src/GLKit/GLKMesh.cs | Updated public wrapper method signature to use nullable out parameters and simplified variable declaration |
| tests/xtro-sharpie/api-annotations-dotnet/iOS-GLKit.ignore | Removed the now-fixed missing-release-attribute warning |
| tests/xtro-sharpie/api-annotations-dotnet/macOS-GLKit.ignore | Removed the now-fixed missing-release-attribute warning |
| tests/xtro-sharpie/api-annotations-dotnet/tvOS-GLKit.ignore | Removed the now-fixed missing-release-attribute warning |
This comment has been minimized.
This comment has been minimized.
✅ [CI Build #0bcb486] Build passed (Build packages) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
✅ [CI Build #0bcb486] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build #0bcb486] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #0bcb486] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #0bcb486] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [CI Build #0bcb486] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
✅ [PR Build #0bcb486] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💻 [CI Build #0bcb486] Tests on macOS arm64 - Mac Tahoe (26) passed 💻✅ All tests on macOS arm64 - Mac Tahoe (26) passed. Pipeline on Agent |
🚀 [CI Build #0bcb486] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 119 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
Also add a missing [return: Release] attribute.