Skip to content

Conversation

@rolfbjarne
Copy link
Member

Also add a missing [return: Release] attribute.

Also add a missing [return: Release] attribute.
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes nullability annotations and adds a missing memory management attribute for the GLKMesh.FromAsset method.

Changes:

  • Added [return: Release] attribute to the internal FromAsset binding to properly handle memory management for Objective-C "new" family methods
  • Updated nullability annotations on out parameters in both the binding definition and wrapper method to be nullable
  • Removed the corresponding warnings from xtro-sharpie ignore files for iOS, macOS, and tvOS

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/glkit.cs Added [return: Release] attribute and [NullAllowed] attributes to out parameters for the internal FromAsset binding
src/GLKit/GLKMesh.cs Updated public wrapper method signature to use nullable out parameters and simplified variable declaration
tests/xtro-sharpie/api-annotations-dotnet/iOS-GLKit.ignore Removed the now-fixed missing-release-attribute warning
tests/xtro-sharpie/api-annotations-dotnet/macOS-GLKit.ignore Removed the now-fixed missing-release-attribute warning
tests/xtro-sharpie/api-annotations-dotnet/tvOS-GLKit.ignore Removed the now-fixed missing-release-attribute warning

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #0bcb486] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 0bcb48692d4bf8a768c9bb1f989d69399d078a3a [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #0bcb486] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 0bcb48692d4bf8a768c9bb1f989d69399d078a3a [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #0bcb486] Tests on macOS X64 - Mac Sonoma (14) passed 💻

All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 0bcb48692d4bf8a768c9bb1f989d69399d078a3a [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #0bcb486] Tests on macOS M1 - Mac Monterey (12) passed 💻

All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 0bcb48692d4bf8a768c9bb1f989d69399d078a3a [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #0bcb486] Tests on macOS M1 - Mac Ventura (13) passed 💻

All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 0bcb48692d4bf8a768c9bb1f989d69399d078a3a [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #0bcb486] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 0bcb48692d4bf8a768c9bb1f989d69399d078a3a [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@rolfbjarne rolfbjarne enabled auto-merge (squash) January 13, 2026 07:55
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #0bcb486] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 0bcb48692d4bf8a768c9bb1f989d69399d078a3a [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

NET (empty diffs)

✅ API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 0bcb48692d4bf8a768c9bb1f989d69399d078a3a [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

2 similar comments
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #0bcb486] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: 0bcb48692d4bf8a768c9bb1f989d69399d078a3a [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build #0bcb486] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 119 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 11 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 0bcb48692d4bf8a768c9bb1f989d69399d078a3a [PR build]

@rolfbjarne rolfbjarne merged commit 5f14a13 into main Jan 14, 2026
50 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants