[release/9.0.1xx] [dotnet] Fix handling binding frameworks embedded in binding assemblies remotely. #24548
Conversation
…es remotely. Adjust the FilterStaticFrameworks and GetFullPaths tasks to not copy any empty files from Windows to Mac, because that would most likely overwrite an existing non-empty file on the Mac. Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2679691.
This reverts commit d79b463. wrong branch
There was a problem hiding this comment.
Pull request overview
This pull request backports a fix from #24518 to the release/9.0.1xx branch that addresses an issue with handling binding frameworks embedded in binding assemblies when building remotely from Windows to Mac. The problem occurred when empty placeholder files created on Windows would overwrite actual framework files on the Mac during remote builds.
Changes:
- Modified FilterStaticFrameworks and GetFullPaths MSBuild tasks to skip copying empty files from Windows to Mac
- Added comprehensive test projects to verify the fix works correctly for binding projects with embedded frameworks
- Updated bindings-framework-test project to allow NoBindingEmbedding property to be overridden for testing purposes
Reviewed changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| msbuild/Xamarin.MacDev.Tasks/Tasks/GetFullPaths.cs | Added empty file check in ShouldCopyToBuildServer to prevent overwriting Mac files with empty Windows placeholders |
| msbuild/Xamarin.MacDev.Tasks/Tasks/FilterStaticFrameworks.cs | Added empty file check in GetAdditionalItemsToBeCopied to skip copying empty framework files to Mac |
| tests/dotnet/UnitTests/WindowsTest.cs | Added BuildEmbeddedFrameworkInBindingProjectApp test case to verify the fix works in remote build scenarios |
| tests/dotnet/BindingWithEmbeddedFramework/* | New binding project with embedded framework for testing, created for iOS, macOS, tvOS, and MacCatalyst platforms |
| tests/dotnet/EmbeddedFrameworkInBindingProjectApp/* | New test app that consumes the binding project to validate the complete scenario works end-to-end |
| tests/bindings-framework-test/dotnet/shared.csproj | Made NoBindingEmbedding property conditional to allow override in test scenarios |
✅ [PR Build #1dbc548] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ [CI Build #1dbc548] Build passed (Build packages) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [CI Build #1dbc548] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build #1dbc548] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #1dbc548] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #1dbc548] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
💻 [CI Build #1dbc548] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [CI Build #1dbc548] Tests on macOS arm64 - Mac Tahoe (26) passed 💻✅ All tests on macOS arm64 - Mac Tahoe (26) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
🔥 [CI Build #1dbc548] Test results 🔥Test results❌ Tests failed on VSTS: test results 0 tests crashed, 1 tests failed, 112 tests passed. Failures❌ windows tests [attempt 4]DetailsHtml Report (VSDrops) Download Successes✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
Adjust the FilterStaticFrameworks and GetFullPaths tasks to not copy any empty files
from Windows to Mac, because that would most likely overwrite an existing non-empty
file on the Mac.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2679691.
Backport of #24518.