[msbuild] Add support for ACToolPath, IBToolPath and TextureAtlasPath. #24549
Conversation
Add support for ACToolPath, IBToolPath and TextureAtlasPath to specify the location of the corresponding executables. And if not specified, then locate these executables using `xcrun`. Also make these process invocations cancellable.
There was a problem hiding this comment.
Pull request overview
This pull request refactors the Xcode tool invocation mechanism for ACTool, IBTool, and TextureAtlas tasks to support custom tool paths and use xcrun as the default tool locator.
Changes:
- Replaced the
ToolExeproperty mechanism with theGetExecutablehelper that usesxcrunby default or a custom path when specified - Added cancellation support to the tool execution by implementing
ICancelableTaskin base classes - Simplified the tool location logic by removing the
DefaultBinDirand related directory properties
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| msbuild/Xamarin.Shared/Xamarin.Shared.targets | Removed ToolExe parameters from IBTool, ACTool, and TextureAtlas task invocations |
| msbuild/Xamarin.MacDev.Tasks/Tasks/XcodeTool.cs | Removed ToolExe property and directory-based tool location logic; added ICancelableTask implementation with cancellation support; updated to use GetExecutable helper |
| msbuild/Xamarin.MacDev.Tasks/Tasks/XcodeCompilerToolTask.cs | Removed ToolExe property and directory properties; added ICancelableTask implementation; refactored arch workaround to work with GetExecutable; fixed typo "looged" → "logged" |
| msbuild/Xamarin.MacDev.Tasks/Tasks/TextureAtlas.cs | Removed DefaultBinDir property, redundant ICancelableTask interface, and Cancel() method (now inherited from base class) |
| msbuild/Xamarin.MacDev.Tasks/Tasks/IBTool.cs | Removed DefaultBinDir property, redundant ICancelableTask interface, and Cancel() method (now inherited from base class) |
| msbuild/Xamarin.MacDev.Tasks/Tasks/ACTool.cs | Removed DefaultBinDir property, redundant ICancelableTask interface, and Cancel() method (now inherited from base class) |
| docs/building-apps/build-properties.md | Added documentation for ACToolPath, IBToolPath, and TextureAtlasPath properties |
✅ [CI Build #309d553] Build passed (Build packages) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ [CI Build #309d553] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build #309d553] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #309d553] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [CI Build #309d553] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
💻 [CI Build #309d553] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #309d553] Tests on macOS arm64 - Mac Tahoe (26) passed 💻✅ All tests on macOS arm64 - Mac Tahoe (26) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
✅ [PR Build #309d553] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build #309d553] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 126 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
Add support for ACToolPath, IBToolPath and TextureAtlasPath to specify the location
of the corresponding executables.
And if not specified, then locate these executables using
xcrun.Also make these process invocations cancellable.