[tests] Cover NSCoding generic registrar signatures. Fixes #21256 - #26499
[tests] Cover NSCoding generic registrar signatures. Fixes #21256#26499rolfbjarne wants to merge 2 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the bindings-test fixture bindings to add registrar coverage for NSDictionary<NSString, NSCoding> in both method and property signatures, targeting the device-build registrar/header generation failure described in #21256.
Changes:
- Add
NSDictionary<NSString, NSCoding>getter/setter method signatures to the registrar test interface. - Add a
NSDictionary<NSString, NSCoding>property to broaden coverage of generic NSCoding dictionary signatures.
Suppressed comments (1)
tests/bindings-test/ApiDefinition.cs:261
⚠️ The new NSCoding dictionary property is currently non-nullable; the real-world signature in #21256 is nullable, and other test properties here are marked [NullAllowed] when they can be nil. Marking this one [NullAllowed] would better cover the problematic registrar output.
[Export ("nscodingSessionDictionary")]
NSDictionary<NSString, NSCoding> NSCodingSessionDictionary { get; set; }
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: d5a9e01b-aa72-4c86-bf6b-7943a38b0f39
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
🔥 [CI Build #d67f4bb] Test results 🔥Test results❌ Tests failed on VSTS: test results 0 tests crashed, 62 tests failed, 143 tests passed. Failures❌ dotnettests tests (iOS)1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ dotnettests tests (MacCatalyst)1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ dotnettests tests (macOS)1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ dotnettests tests (tvOS)1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ linker tests (MacCatalyst)3 tests failed, 12 tests passed.Failed tests
Html Report (VSDrops) Download ❌ linker tests (macOS)7 tests failed, 14 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (iOS)8 tests failed, 11 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (MacCatalyst)14 tests failed, 4 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (macOS)18 tests failed, 3 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (tvOS)8 tests failed, 11 tests passed.Failed tests
Html Report (VSDrops) Download Successes✅ assembly-processing: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download Linux Build VerificationPipeline on Agent |
|
Trying another approach. |
Fixes the issue where NSCoding generic bindings cause linker-cache compile errors in device builds.
Adds registrar binding coverage for
NSDictionary<NSString, NSCoding>method and property signatures.Fixes #21256.
🤖 Pull request created by Copilot