Using latest ValueTuple package in .NET 4.7.1 or later in a project that has source authored bindingRedirects results in warning MSB3836 or FileNotFoundException

[ericstj]

If a project already has a source-authored bindingRedirects in app.config that downgrade the ValueTuple assembly version, the following warning may be emitted:

warning MSB3836: The explicit binding redirect on "System.ValueTuple, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51" conflicts with an autogenerated binding redirect. Consider removing it from the application configuration file or disabling autogenerated binding redirects. The build will replace it with: "<bindingRedirect oldVersion="0.0.0.0-4.0.5.0" newVersion="4.0.5.0" xmlns="urn:schemas-microsoft-com:asm.v1" />".

If that project is then run after the redirects are rewritten, or if other redirects (not downgrade) existed, a runtime error like the following will occur.

Unhandled Exception: System.IO.FileNotFoundException: Could not load file or assembly 'System.ValueTuple, Version=4.0.5.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' or one of its dependencies. The system cannot find the file specified.

In both cases the fix is to remove the bindingRedirectm for System.ValueTuple. System.ValueTuple is present in .NET 4.7.1 and later and does not require bindingRedirects.

[specture]

@ericstj We do have met the same issue, but we cannot remove the binding redirect directly since it would throw warning. So, we have a temp solution to redirect the version to 4.0.0.0

			<dependentAssembly>
				<assemblyIdentity name="System.ValueTuple" publicKeyToken="CC7B13FFCD2DDD51" culture="neutral"/>
				<bindingRedirect oldVersion="0.0.0.0-4.0.5.0" newVersion="4.0.0.0"/>
			</dependentAssembly>

I don't know if it would break something, could you please help give us some advice about it. Is there a way to remove the warning and don't break anything.

[ericstj]

You need to remove the redirect. There should be no warning when using the latest package.

[specture]

Thanks @ericstj the issue is gone after I install 4.6.2 version.

[simonlampen]

Thanks @ericstj is this same advice true for the other packages in this project, eg System.Memory or is System.ValueTuple the only inbox reference that should not have bindingRedirects?

[ericstj]

System.Memory was never added to .NETFramework. Only the assemblies which were eventually inboxed in .NETFramework should not have bindingRedirects when targeting the latest framework which contains the assembly. I think that's only ValueTuple of the set that remains in this repo. https://github.com/search?q=repo%3Adotnet%2Fmaintenance-packages+%2FIsPlaceholderTargetFramework.*%28net4%7CNETFramework%29%2F+&type=code

Plenty of other assemblies we shipped in nuget packages in the past were this way - System.Net.Http, System.IO.Compression, etc. Most of those don't live on in this repo since they are inbox in the oldest supported .NETFramework version. System.ValueTuple is a bit "special" since it didn't get fully inboxed until .NET 4.7.1. The other assemblies in this repo remain out-of-box in the latest .NETFramework (and thus, require servicing maintenance of the nuget packages).