Check if RefreshControl is enabled on iOS (#28360)

Author: PureWeen

Diff for: src/Controls/tests/TestCases.Android.Tests/snapshots/android/Issue28343_ProgressSpinnerDisabled.png

@@ -0,0 +1,85 @@
+using System.ComponentModel;
+
+namespace Maui.Controls.Sample.Issues
+{
+
+	[Issue(IssueTracker.Github, 28343, "Progress spinner is not disabled after setting content on disabled RefreshView.", PlatformAffected.iOS)]
+	public class Issue28343 : ContentPage
+	{
+		public Issue28343()
+		{
+			var refreshView = new RefreshView
+			{
+				IsEnabled = false,
+				Content = CreateContent(),				
+			};
+
+			Grid grid = new Grid
+			{
+				{ 
+					new Label 
+					{ 
+						Text = "Refresh Not Triggered",
+						AutomationId = "RefreshNotTriggered"
+					}, 0, 0 },
+				{ 
+					new Button 
+					{ 
+						Text = "Set To Enabled", 
+						AutomationId = "SetToEnabled", 
+						Command = new Command(() => 
+						{
+							refreshView.IsEnabled = true;
+						})
+					}, 0, 1 },
+				{ 
+					new Button 
+					{ 
+						Text = "Reset Content", 
+						AutomationId = "ResetContent", 
+						Command = new Command(() => 
+						{
+							refreshView.Content = CreateContent();
+						})
+					}, 0, 2 },
+				{ refreshView, 0, 3 }
+			};
+
+			refreshView.Command = new Command(() =>
+			{
+				grid.RemoveAt(0);
+				grid.Insert(0, new Label() { Text = "Refresh Triggered", AutomationId = "RefreshTriggered" });
+			});
+
+			Content = grid;
+
+			grid.RowDefinitions[0].Height = GridLength.Auto;
+			grid.RowDefinitions[1].Height = GridLength.Auto;
+			grid.RowDefinitions[2].Height = GridLength.Auto;
+			grid.RowDefinitions[3].Height = GridLength.Star;
+		}
+
+		View CreateContent()
+		{
+			return new CollectionView
+			{
+				AutomationId = "CollectionView",
+				ItemsSource = Enumerable.Range(0, 100).Select(x=> $"ListItem{x}"),
+				ItemTemplate = new DataTemplate(() =>
+				{
+					var label =  new Label
+					{
+						HeightRequest = 100,
+						BackgroundColor = Colors.Green,
+						TextColor = Colors.White
+					};
+
+					label.SetBinding(Label.TextProperty, ".");
+					label.SetBinding(Label.AutomationIdProperty, ".");
+					
+					return label;
+				})
+			};
+		}
+	}
+}

Diff for: src/Controls/tests/TestCases.HostApp/Issues/Issue28343.cs

@@ -26,7 +26,7 @@ public void BindingUpdatesFromProgrammaticRefresh()
 		App.Tap("StopRefreshing");
 		App.WaitForElement("IsNotRefreshing");
 	}
-#if TEST_FAILS_ON_CATALYST || TEST_FAILS_ON_WINDOWS //Scroll actions cannot be performed on the macOS test server
+#if TEST_FAILS_ON_CATALYST && TEST_FAILS_ON_WINDOWS //Scroll actions cannot be performed on the macOS test server
 	[Test]
 	public void BindingUpdatesFromInteractiveRefresh()
 	{

Diff for: src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue16910.cs

@@ -0,0 +1,53 @@
+using NUnit.Framework;
+using UITest.Appium;
+using UITest.Core;
+
+namespace Microsoft.Maui.TestCases.Tests.Issues
+{
+#if TEST_FAILS_ON_CATALYST && TEST_FAILS_ON_WINDOWS
+	[Category(UITestCategories.RefreshView)]
+	public class Issue28343 : _IssuesUITest
+	{
+		public Issue28343(TestDevice testDevice) : base(testDevice)
+		{
+		}
+
+		protected override bool ResetAfterEachTest => true;
+
+		public override string Issue => "Progress spinner is not disabled after setting content on disabled RefreshView.";
+
+		[Test]
+		public void ProgressSpinnerNotDisabledOnStartup()
+		{
+			App.WaitForElement("RefreshNotTriggered");
+			App.WaitForElement("ListItem0");
+			App.ScrollUp("CollectionView");
+			App.WaitForElement("RefreshNotTriggered");
+			VerifyScreenshot("Issue28343_ProgressSpinnerDisabled");
+
+		}
+
+		#if TEST_FAILS_ON_ANDROID // https://github.com/dotnet/maui/issues/28361
+		[Test]
+		public void ProgressSpinnerRemainsDisabledAfterSwappingContent()
+		{
+			App.WaitForElement("RefreshNotTriggered");
+			App.WaitForElement("ListItem0");
+			App.Tap("ResetContent");
+			App.WaitForElement("ListItem0");
+			App.ScrollUp("CollectionView");
+			App.WaitForElement("RefreshNotTriggered");
+			VerifyScreenshot("Issue28343_ProgressSpinnerDisabled");
+		}
+		#endif
+
+		[Test]
+		public void ProgressSpinnerWorksWhenReEnabled()
+		{
+			App.WaitForElement("SetToEnabled").Tap();
+			App.ScrollUp("CollectionView");
+			App.WaitForElement("RefreshTriggered");
+		}
+	}
+#endif
+}

Diff for: src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue28343.cs

@@ -132,6 +132,11 @@ bool TryRemoveRefresh(UIView view, int index = 0)
 
 		bool TryInsertRefresh(UIView view, int index = 0)
 		{
+			if(!_refreshControl.Enabled)
+			{
+				return false;
+			}
+
 			_refreshControlParent = view;
 
 			if (view is UIScrollView scrollView)