Skip to content

Commit abf0a5f

Browse files
[Testing] Fixed Build error on inflight/ candidate PR 35716 (#35730)
This pull request makes layout adjustments to the `Issue7814` test case to improve clarity and maintainability. The main changes involve explicitly setting the grid positions of UI elements instead of using extension methods, which helps make the layout logic more transparent. **Layout adjustments:** * Explicitly set the column for `_horizontalOffsetLabel` using `Grid.SetColumn` instead of the `.Column(1)` extension method. [[1]](diffhunk://#diff-a564b2a91bf588cf9e13398f6e1dcfac2f9345c027b39d5accbc02f9792360daR17-R26) [[2]](diffhunk://#diff-a564b2a91bf588cf9e13398f6e1dcfac2f9345c027b39d5accbc02f9792360daL45-R51) * Explicitly set the row for `outerScrollView` using `Grid.SetRow` instead of the `.Row(1)` extension method. [[1]](diffhunk://#diff-a564b2a91bf588cf9e13398f6e1dcfac2f9345c027b39d5accbc02f9792360daR17-R26) [[2]](diffhunk://#diff-a564b2a91bf588cf9e13398f6e1dcfac2f9345c027b39d5accbc02f9792360daL45-R51)
1 parent 84345dc commit abf0a5f

1 file changed

Lines changed: 5 additions & 2 deletions

File tree

src/Controls/tests/TestCases.HostApp/Issues/Issue7814.cs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,16 @@ protected override void Init()
1414
_verticalOffsetLabel = CreateOffsetLabel("Issue7814VerticalScrollYLabel", VerticalOffsetPrefix);
1515
_horizontalOffsetLabel = CreateOffsetLabel("Issue7814HorizontalScrollXLabel", HorizontalOffsetPrefix);
1616

17+
Grid.SetColumn(_horizontalOffsetLabel, 1);
18+
1719
var outerScrollView = new ScrollView
1820
{
1921
AutomationId = "Issue7814OuterScrollView",
2022
Orientation = ScrollOrientation.Vertical,
2123
Content = CreateScrollableContent()
2224
};
2325
outerScrollView.Scrolled += (_, e) => UpdateOffset(_verticalOffsetLabel, VerticalOffsetPrefix, e.ScrollY);
26+
Grid.SetRow(outerScrollView, 1);
2427

2528
Content = new Grid
2629
{
@@ -42,10 +45,10 @@ protected override void Init()
4245
Children =
4346
{
4447
_verticalOffsetLabel,
45-
_horizontalOffsetLabel.Column(1)
48+
_horizontalOffsetLabel
4649
}
4750
},
48-
outerScrollView.Row(1)
51+
outerScrollView
4952
}
5053
};
5154
}

0 commit comments

Comments
 (0)