Commit ba1ffb8
authored
[release/11.0.1xx-preview1] Merge net11.0 to release preview1 (#33924)
### Description of Change
This pull request introduces major improvements to the PR agent workflow
documentation and process, focusing on stricter enforcement of critical
rules, clearer separation of reusable rules, and enhanced guidance for
multi-model fix exploration. The changes include extracting shared rules
into a dedicated file, updating workflow steps to emphasize saving (not
committing) state files, and providing a comprehensive reusable plan
template. Additionally, the documentation for multi-model try-fix and
platform selection is significantly expanded and clarified.
**Key changes:**
### Shared Rules Extraction and Enforcement
- Introduced `.github/agents/pr/SHARED-RULES.md` to centralize all
critical rules such as phase completion protocol, template adherence,
prohibition of direct git commands, strict handling of environment
blockers, multi-model configuration, and platform selection. All main
workflow docs now reference this file for consistency.
[[1]](diffhunk://#diff-ba3c55793886d2bb8d017dd23547f45d14ae24f43c3d7ac1ce1018aa479f28b6R1-R167)
[[2]](diffhunk://#diff-f68adeaf7e902d0ee39123f55180696a6c103d1631856c26a14e3cce95c82757L44-R60)
[[3]](diffhunk://#diff-638499c1b015c0699708079207ad709e0428226bab9857fda0f0a7e9454cf380L18-R25)
### Improved Workflow Guidance and Templates
- Added `.github/agents/pr/PLAN-TEMPLATE.md`, a reusable checklist and
quick reference for the 5-phase PR agent workflow, summarizing critical
rules and providing step-by-step actions and blocker responses for each
phase.
- Updated `.github/agents/pr.md` and `.github/agents/pr/post-gate.md` to
reference shared rules, clarify steps, and emphasize saving (not
committing) state files throughout the process.
[[1]](diffhunk://#diff-f68adeaf7e902d0ee39123f55180696a6c103d1631856c26a14e3cce95c82757L236-R228)
[[2]](diffhunk://#diff-f68adeaf7e902d0ee39123f55180696a6c103d1631856c26a14e3cce95c82757L354-R341)
[[3]](diffhunk://#diff-f68adeaf7e902d0ee39123f55180696a6c103d1631856c26a14e3cce95c82757L421-R408)
[[4]](diffhunk://#diff-f68adeaf7e902d0ee39123f55180696a6c103d1631856c26a14e3cce95c82757L489-R505)
[[5]](diffhunk://#diff-638499c1b015c0699708079207ad709e0428226bab9857fda0f0a7e9454cf380L18-R25)
### Multi-Model Try-Fix and Platform Selection Enhancements
- Expanded and clarified instructions for Phase 4 (Fix) to require
sequential try-fix runs with five specified models, including a
mandatory cross-pollination loop to ensure all models are queried for
new ideas until exhaustion.
[[1]](diffhunk://#diff-f68adeaf7e902d0ee39123f55180696a6c103d1631856c26a14e3cce95c82757L44-R60)
[[2]](diffhunk://#diff-638499c1b015c0699708079207ad709e0428226bab9857fda0f0a7e9454cf380L51-L105)
- Added detailed platform selection rules to ensure tests are only run
on platforms both affected by the bug and available on the host, with
explicit examples and host/platform mapping tables.
[[1]](diffhunk://#diff-f68adeaf7e902d0ee39123f55180696a6c103d1631856c26a14e3cce95c82757R431-R466)
[[2]](diffhunk://#diff-ba3c55793886d2bb8d017dd23547f45d14ae24f43c3d7ac1ce1018aa479f28b6R1-R167)
### Consistency and Clarity Improvements
- Replaced all references to "commit state file" with "save state file"
to match the workflow's use of a gitignored directory and avoid
confusion.
[[1]](diffhunk://#diff-f68adeaf7e902d0ee39123f55180696a6c103d1631856c26a14e3cce95c82757L236-R228)
[[2]](diffhunk://#diff-f68adeaf7e902d0ee39123f55180696a6c103d1631856c26a14e3cce95c82757L354-R341)
[[3]](diffhunk://#diff-f68adeaf7e902d0ee39123f55180696a6c103d1631856c26a14e3cce95c82757L421-R408)
[[4]](diffhunk://#diff-f68adeaf7e902d0ee39123f55180696a6c103d1631856c26a14e3cce95c82757L489-R505)
- Updated bash workflow snippets and instructions to clarify that the
agent is always on the correct branch and should never run git
checkout/switch commands.
[[1]](diffhunk://#diff-f68adeaf7e902d0ee39123f55180696a6c103d1631856c26a14e3cce95c82757L245-R237)
[[2]](diffhunk://#diff-f68adeaf7e902d0ee39123f55180696a6c103d1631856c26a14e3cce95c82757L259)
[[3]](diffhunk://#diff-ba3c55793886d2bb8d017dd23547f45d14ae24f43c3d7ac1ce1018aa479f28b6R1-R167)
### Additional Documentation and Process Refinements
- Improved documentation for environment blocker handling, retry limits,
and mandatory STOP/report/ask-user protocol when blockers are
encountered.
[[1]](diffhunk://#diff-ba3c55793886d2bb8d017dd23547f45d14ae24f43c3d7ac1ce1018aa479f28b6R1-R167)
[[2]](diffhunk://#diff-638499c1b015c0699708079207ad709e0428226bab9857fda0f0a7e9454cf380L18-R25)
- Clarified the process for applying selected fixes, emphasizing that
agents should apply changes but not commit them (user handles git).
These changes collectively enforce stricter process discipline, improve
clarity for both human and agent contributors, and ensure that the
multi-model approach and environment safety protocols are followed
rigorously.File tree
233 files changed
+7303
-1192
lines changed- .github
- agents
- pr
- instructions
- scripts
- skills
- ai-summary-comment
- scripts
- pr-finalize
- try-fix
- docs
- design
- specs
- eng
- automation/cspell
- pipelines
- arcade
- src
- BlazorWebView/tests/DeviceTests/Elements
- Controls
- samples
- Controls.Sample.Embedding
- Controls.Sample.Profiling
- Controls.Sample
- Pages
- Compatibility
- ListViewGalleries
- Controls
- CollectionViewGalleries
- CarouselViewGalleries
- DataTemplateSelectorGalleries
- EmptyViewGalleries
- ScrollModeGalleries
- SelectionGalleries
- MapsGalleries
- RadioButtonGalleries
- ShapesGalleries
- SwipeViewGalleries
- WebViewGalleries
- Core
- BorderGalleries
- PanGestureGalleries
- ShadowGalleries
- ShellGalleries
- Layouts
- ScrollViewPages
- Others
- PlatformSpecifics
- Android
- Windows
- iOS
- UserInterface
- src
- Build.Tasks
- nuget/buildTransitive/netstandard2.0
- SourceGen
- Visitors
- xlf
- Xaml
- tests
- DeviceTests/Xaml
- SourceGen.UnitTests
- InitializeComponent
- TestCases.Android.Tests/snapshots/android
- TestCases.HostApp
- Issues
- Resources/Images
- TestCases.Mac.Tests/snapshots/mac
- TestCases.WinUI.Tests/snapshots/windows
- TestCases.iOS.Tests/snapshots/ios
- Xaml.UnitTests
- Issues
- MSBuild
- Core/src/Platform/Android
- Essentials/samples/Samples
- Templates/src/templates
- maui-blazor-solution/MauiApp.1
- maui-blazor
- maui-lib
- maui-mobile
- maui-multiproject
- MauiApp.1.Droid
- MauiApp.1.Mac
- MauiApp.1.WinUI
- MauiApp.1.iOS
- MauiApp.1
- TestUtils/src
- DeviceTests.Runners
- VisualRunner
- Microsoft.Maui.IntegrationTests
- Apple
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
233 files changed
+7303
-1192
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
44 | | - | |
| 44 | + | |
45 | 45 | | |
46 | | - | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
47 | 54 | | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
54 | 59 | | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
| 60 | + | |
69 | 61 | | |
70 | 62 | | |
71 | 63 | | |
| |||
233 | 225 | | |
234 | 226 | | |
235 | 227 | | |
236 | | - | |
| 228 | + | |
237 | 229 | | |
238 | 230 | | |
239 | 231 | | |
| |||
242 | 234 | | |
243 | 235 | | |
244 | 236 | | |
245 | | - | |
246 | | - | |
247 | | - | |
248 | | - | |
249 | | - | |
| 237 | + | |
250 | 238 | | |
251 | 239 | | |
252 | 240 | | |
| |||
256 | 244 | | |
257 | 245 | | |
258 | 246 | | |
259 | | - | |
260 | 247 | | |
261 | 248 | | |
262 | 249 | | |
| |||
351 | 338 | | |
352 | 339 | | |
353 | 340 | | |
354 | | - | |
| 341 | + | |
355 | 342 | | |
356 | 343 | | |
357 | 344 | | |
| |||
418 | 405 | | |
419 | 406 | | |
420 | 407 | | |
421 | | - | |
| 408 | + | |
422 | 409 | | |
423 | 410 | | |
424 | 411 | | |
| |||
441 | 428 | | |
442 | 429 | | |
443 | 430 | | |
| 431 | + | |
| 432 | + | |
| 433 | + | |
| 434 | + | |
| 435 | + | |
| 436 | + | |
| 437 | + | |
| 438 | + | |
| 439 | + | |
| 440 | + | |
| 441 | + | |
| 442 | + | |
| 443 | + | |
| 444 | + | |
| 445 | + | |
| 446 | + | |
| 447 | + | |
| 448 | + | |
| 449 | + | |
| 450 | + | |
| 451 | + | |
| 452 | + | |
| 453 | + | |
| 454 | + | |
| 455 | + | |
| 456 | + | |
| 457 | + | |
| 458 | + | |
| 459 | + | |
444 | 460 | | |
445 | 461 | | |
446 | 462 | | |
447 | 463 | | |
448 | 464 | | |
449 | 465 | | |
450 | | - | |
| 466 | + | |
451 | 467 | | |
452 | 468 | | |
453 | 469 | | |
| |||
486 | 502 | | |
487 | 503 | | |
488 | 504 | | |
489 | | - | |
| 505 | + | |
490 | 506 | | |
491 | 507 | | |
492 | 508 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
0 commit comments