[Testing] Refactoring Feature Matrix UITest Cases for Entry Control by LogishaSelvarajSF4525 · Pull Request #34632 · dotnet/maui

LogishaSelvarajSF4525 · 2026-03-25T07:49:55Z

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

This pull request updates the EntryControlPage and its code-behind to improve testability and maintainability of the Entry control's feature matrix. The main changes include adding new bindable properties, improving event handling, and simplifying the options navigation logic.

Enhancements to Entry control testability and UI:

Added bindings for WidthRequest, BackgroundColor, and Opacity to the Entry control in EntryControlPage.xaml to allow more comprehensive property testing.
Changed the AutomationId of the options button from "OptionsButton" to "Options" for consistency with test automation.
Added the TextChanged event handler (CursorPositionButton_Clicked) to the CursorPositionEntry control, enabling dynamic updates to cursor position via UI interaction.

Code simplification and maintainability:

Replaced manual property resets in NavigateToOptionsPage_Clicked with a call to the new _viewModel.Reset() method, making the reset logic more maintainable and centralized.
Minor cleanup in the code-behind by removing unnecessary whitespace.

Issue Identified:

[iOS, Maccatalyst] Entry & Editor BackgroundColor not reset to Null #34611

github-actions · 2026-03-25T07:50:04Z

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 34632

Or

Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 34632"

dotnet-policy-service · 2026-03-25T07:51:34Z

Hey there @@LogishaSelvarajSF4525! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

sheiksyedm · 2026-03-26T10:54:46Z

/azp run maui-pr-uitests

azure-pipelines · 2026-03-26T10:54:59Z

Azure Pipelines successfully started running 1 pipeline(s).

Copilot

Pull request overview

This PR refactors the Entry Feature Matrix page and options UI to be more testable and easier to reset between scenarios, while updating platform snapshot baselines to reflect the UI/test behavior changes.

Changes:

Add new bindable properties to the Entry feature matrix (WidthRequest, BackgroundColor, Opacity) and centralize state reset via EntryViewModel.Reset().
Simplify the options UI event handling (e.g., using AutomationId to select colors; new handlers for width/opacity/height inputs; updated font attributes handling).
Update WinUI/macOS/iOS snapshot images to match the updated UI/test baselines.

Reviewed changes

Copilot reviewed 6 out of 148 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/Controls/tests/TestCases.HostApp/FeatureMatrix/EntryControl/EntryViewModel.cs	Adds new properties (BackgroundColor/Opacity/WidthRequest) and a `Reset()` method to restore defaults for test runs.
src/Controls/tests/TestCases.HostApp/FeatureMatrix/EntryControl/EntryOptionsPage.xaml.cs	Refactors option handlers (color selection by AutomationId, numeric input handlers, font-attributes checkbox aggregation).
src/Controls/tests/TestCases.HostApp/FeatureMatrix/EntryControl/EntryControlPage.xaml.cs	Uses `_viewModel.Reset()` instead of re-instantiating the view model when navigating to options.
src/Controls/tests/TestCases.HostApp/FeatureMatrix/EntryControl/EntryControlPage.xaml	Binds new properties to the Entry, updates Options AutomationId, and wires CursorPositionEntry TextChanged for better interactivity.
src/Controls/tests/TestCases.iOS.Tests/snapshots/ios/VerifyClearButtonVisiblityWhenTextAlignedVertically.png	Updated iOS snapshot baseline.
src/Controls/tests/TestCases.iOS.Tests/snapshots/ios/VerifyClearButtonVisiblityWhenTextAlignedHorizontally.png	Updated iOS snapshot baseline.
src/Controls/tests/TestCases.iOS.Tests/snapshots/ios/ClearButtonVisiblityButton_TextPresent.png	Updated iOS snapshot baseline.
src/Controls/tests/TestCases.iOS.Tests/snapshots/ios/ClearButtonVisiblityButton_TextEmpty.png	Updated iOS snapshot baseline.
src/Controls/tests/TestCases.iOS.Tests/snapshots/ios-26/VerifyTextWhenAlingnedVertically.png	Updated iOS 26 snapshot baseline.
src/Controls/tests/TestCases.iOS.Tests/snapshots/ios-26/VerifyTextWhenAlingnedHorizontally.png	Updated iOS 26 snapshot baseline.
src/Controls/tests/TestCases.iOS.Tests/snapshots/ios-26/VerifyClearVisiblityButtonWhenTextColorChanged.png	Updated iOS 26 snapshot baseline.
src/Controls/tests/TestCases.iOS.Tests/snapshots/ios-26/VerifyClearButtonVisiblityWhenTextAlignedVertically.png	Updated iOS 26 snapshot baseline.
src/Controls/tests/TestCases.iOS.Tests/snapshots/ios-26/VerifyClearButtonVisiblityWhenTextAlignedHorizontally.png	Updated iOS 26 snapshot baseline.
src/Controls/tests/TestCases.iOS.Tests/snapshots/ios-26/ClearButtonVisiblityButton_TextPresent.png	Updated iOS 26 snapshot baseline.
src/Controls/tests/TestCases.iOS.Tests/snapshots/ios-26/ClearButtonVisiblityButton_TextEmpty.png	Updated iOS 26 snapshot baseline.
src/Controls/tests/TestCases.WinUI.Tests/snapshots/windows/VerifyTextWhenAlignedVertically.png	Updated WinUI snapshot baseline.
src/Controls/tests/TestCases.WinUI.Tests/snapshots/windows/VerifyTextWhenAlignedHorizontally.png	Updated WinUI snapshot baseline.
src/Controls/tests/TestCases.WinUI.Tests/snapshots/windows/VerifyIsPasswordWhenMaxLengthSetValue.png	Updated WinUI snapshot baseline.
src/Controls/tests/TestCases.WinUI.Tests/snapshots/windows/VerifyClearVisibilityButtonWhenTextColorChanged.png	Updated WinUI snapshot baseline.
src/Controls/tests/TestCases.WinUI.Tests/snapshots/windows/VerifyClearButtonVisibilityWhenTextAlignedVertically.png	Updated WinUI snapshot baseline.
src/Controls/tests/TestCases.WinUI.Tests/snapshots/windows/VerifyClearButtonVisibilityWhenTextAlignedHorizontally.png	Updated WinUI snapshot baseline.
src/Controls/tests/TestCases.WinUI.Tests/snapshots/windows/VerifyClearButtonVisibilityWhenIsPasswordTrueOrFalse.png	Updated WinUI snapshot baseline.
src/Controls/tests/TestCases.WinUI.Tests/snapshots/windows/ClearButtonVisibilityButton_TextPresent.png	Updated WinUI snapshot baseline.
src/Controls/tests/TestCases.WinUI.Tests/snapshots/windows/ClearButtonVisibilityButton_TextEmpty.png	Updated WinUI snapshot baseline.
src/Controls/tests/TestCases.Mac.Tests/snapshots/mac/VerifyTextWhenAlignedVertically.png	Updated macOS snapshot baseline.
src/Controls/tests/TestCases.Mac.Tests/snapshots/mac/VerifyTextWhenAlignedHorizontally.png	Updated macOS snapshot baseline.
src/Controls/tests/TestCases.Mac.Tests/snapshots/mac/VerifyIsPasswordWhenMaxLengthSetValue.png	Updated macOS snapshot baseline.
src/Controls/tests/TestCases.Mac.Tests/snapshots/mac/VerifyClearVisibilityButtonWhenTextColorChanged.png	Updated macOS snapshot baseline.
src/Controls/tests/TestCases.Mac.Tests/snapshots/mac/VerifyClearButtonVisibilityWhenTextAlignedHorizontally.png	Updated macOS snapshot baseline.
src/Controls/tests/TestCases.Mac.Tests/snapshots/mac/VerifyClearButtonVisibilityWhenIsPasswordTrueOrFalse.png	Updated macOS snapshot baseline.
src/Controls/tests/TestCases.Mac.Tests/snapshots/mac/ClearButtonVisibilityButton_TextPresent.png	Updated macOS snapshot baseline.
src/Controls/tests/TestCases.Mac.Tests/snapshots/mac/ClearButtonVisibilityButton_TextEmpty.png	Updated macOS snapshot baseline.

Copilot · 2026-03-26T11:00:22Z

src/Controls/tests/TestCases.HostApp/FeatureMatrix/EntryControl/EntryOptionsPage.xaml.cs

+	private void HeightRequestEntry_TextChanged(object sender, TextChangedEventArgs e)
+	{
+		if (double.TryParse(e.NewTextValue, out double heightRequest))
 		{
-			_viewModel.FontAttributes = FontAttributes.Italic;
+			_viewModel.HeightRequest = heightRequest;
 		}
 	}


HeightRequestEntry_TextChanged sets HeightRequest directly from user input without validating range. Given HeightRequest uses “-1 = unset, otherwise non-negative”, consider coercing values < 0 to -1 (or ignoring them) to avoid applying invalid heights via the options UI.

Copilot · 2026-03-26T11:00:22Z

src/Controls/tests/TestCases.HostApp/FeatureMatrix/EntryControl/EntryControlPage.xaml

                     <local:UITestEntry x:Name="CursorPositionEntry"
                                        Text="{Binding CursorPosition}"
                                        AutomationId="CursorPositionEntry"
+                                        TextChanged="CursorPositionButton_Clicked"
                                        IsCursorVisible="False"


CursorPositionEntry is wired to TextChanged but the handler is named CursorPositionButton_Clicked (and takes EventArgs). Renaming the handler (and parameter type) to reflect it’s a TextChanged handler would make the intent clearer and reduce confusion when navigating the code.

Copilot · 2026-03-26T11:00:23Z

src/Controls/tests/TestCases.HostApp/FeatureMatrix/EntryControl/EntryOptionsPage.xaml.cs

+	private void WidthRequestEntry_TextChanged(object sender, TextChangedEventArgs e)
 	{
-		if (sender == FontAttributesBold)
+		if (double.TryParse(e.NewTextValue, out double widthRequest))
 		{
-			_viewModel.FontAttributes = FontAttributes.Bold;
+			_viewModel.WidthRequest = widthRequest;
 		}
-		else if (sender == FontAttributesNone)
+	}


WidthRequestEntry_TextChanged currently accepts any parsed double (including negative values other than -1). Since WidthRequest semantics are “-1 = unset, otherwise non-negative”, consider coercing values < 0 to -1 (or ignoring them) so invalid widths can’t be applied via the options UI.

LogishaSelvarajSF4525 added 7 commits March 25, 2026 09:53

updated the sample and test cases

76a24c7

updated the snapshot

1ff88ec

updated the test cases

1d62db3

remove the snapshot

73d5fd6

updated the opacity

4641279

update the snapshot

f3af098

updated the test cases

93f6a21

dotnet-policy-service bot added the community ✨ Community Contribution label Mar 25, 2026

dotnet-policy-service bot added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Mar 25, 2026

NafeelaNazhir added area-testing Unit tests, device tests area-controls-entry Entry labels Mar 25, 2026

github-actions bot mentioned this pull request Mar 26, 2026

[repo-status] Daily Repo Status - March 26, 2026 #34665

Open

sheiksyedm marked this pull request as ready for review March 26, 2026 10:54

Copilot AI review requested due to automatic review settings March 26, 2026 10:54

Copilot started reviewing on behalf of sheiksyedm March 26, 2026 10:55 View session

Copilot AI reviewed Mar 26, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Testing] Refactoring Feature Matrix UITest Cases for Entry Control#34632

[Testing] Refactoring Feature Matrix UITest Cases for Entry Control#34632
LogishaSelvarajSF4525 wants to merge 7 commits intodotnet:mainfrom
LogishaSelvarajSF4525:refactoring-entry-feature

LogishaSelvarajSF4525 commented Mar 25, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 25, 2026

Uh oh!

dotnet-policy-service bot commented Mar 25, 2026

Uh oh!

sheiksyedm commented Mar 26, 2026

Uh oh!

azure-pipelines bot commented Mar 26, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 26, 2026

Uh oh!

Copilot AI Mar 26, 2026

Uh oh!

Copilot AI Mar 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

LogishaSelvarajSF4525 commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 25, 2026

Uh oh!

dotnet-policy-service bot commented Mar 25, 2026

Uh oh!

sheiksyedm commented Mar 26, 2026

Uh oh!

azure-pipelines bot commented Mar 26, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

LogishaSelvarajSF4525 commented Mar 25, 2026 •

edited

Loading