Fix terminal logger quiet mode to show project context for warnings/errors (#12930)

Copilot · baronfel · Copilot · web-flow · commit 2392c792aa69 · 2026-01-06T17:16:24.000+01:00
### Context In quiet mode (`-v:q`), warnings and errors were rendered immediately without project context. Users saw diagnostic messages but couldn't identify which project they came from. ``` CSC : warning MSTEST0001: Explicitly enable or disable tests parallelization ``` ### Changes Made **Modified diagnostic accumulation logic** - `WarningRaised` and `ErrorRaised` now accumulate diagnostics in the project's `BuildMessages` collection regardless of verbosity - Removed verbosity check that caused immediate rendering in quiet mode - Preserved immediate rendering for auth provider warnings and immediate warnings (MSB3026) **Modified project summary rendering** - `ProjectFinished` now displays project summaries in quiet mode when `HasErrorsOrWarnings` is true - Projects without diagnostics remain hidden in quiet mode as expected - Simplified quiet mode detection logic: `Verbosity < LoggerVerbosity.Quiet || (Verbosity == LoggerVerbosity.Quiet && !project.HasErrorsOrWarnings)` - Skip `DisplayNodes()` call in quiet mode to avoid writing unnecessary cursor hide/show ANSI codes since there's no dynamic refresh **Result in quiet mode:** ``` project failed with 1 error(s) and 2 warning(s) (0.2s) directory/file(1,2,3,4): warning AA0000: Warning message directory/file(1,2,3,4): error AA0000: Error message ``` ### Testing - Updated snapshot files for `PrintBuildSummaryQuietVerbosity_FailedWithErrors` across Linux/OSX/Windows - All 69 TerminalLogger tests pass - Verified successful projects still produce no output in quiet mode - Verified no cursor control codes are written in quiet mode output ### Notes Uses the same project-grouping primitives as higher verbosity levels, toggled by runtime state per maintainer guidance.  <details> <summary>Original prompt</summary> > > ---- > > *This section details on the original issue you should resolve* > > <issue_title>Terminal logger quiet mode hides projects</issue_title> > <issue_description>This was reported by @gao-artur in microsoft/testfx#7051 > > > Here is a new project created from the MSTest template without `MSTestSettings.cs` file + the binlog. Built with > > > > `dotnet build -bl -v q` > > [TestProject11.zip](https://github.com/user-attachments/files/23968849/TestProject11.zip) > > In that thread we determined that `-tl` status affects the usefulness of the output for messages that do not have a specific file associated with them: > > ```sh-session > ❯ dotnet build > Restore complete (4.0s) > TestProject11 net9.0 succeeded with 1 warning(s) (2.3s) → bin\Debug\net9.0\TestProject11.dll > CSC : warning MSTEST0001: Explicitly enable or disable tests parallelization (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0001) > > Build succeeded with 1 warning(s) in 7.2s > > ❯ rm -r .\obj\ > > ❯ dotnet build -v:q > CSC : warning MSTEST0001: Explicitly enable or disable tests parallelization (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0001) > ``` > > The associated project `TestProject11` is not mentioned anywhere in the latter. I think that's unreasonable even when the user has requested "quiet".</issue_description> > > <agent_instructions>Try to update the diagnostic/warning/error message rendering in quiet mode so that it doesn't use the 'immediate' mode formatting, the final output should only show the diagnostics for projects that failed or had warnings.</agent_instructions> > > ## Comments on the Issue (you are @copilot in this section) > > <comments> > <comment_new><author>@baronfel</author><body> > A few approaches to consider: > > * in quiet mode appending/prepending the project if it exists to the 'message formatting' part of the line > * in quiet mode using the same project-based grouping as we do in non-quiet mode, instead of assuming that quiet mode should trigger some kind of flat-list-only output</body></comment_new> > <comment_new><author>@rainersigwald</author><body> > Yeah I waffled between the two myself, I think I lean to the latter right now though.</body></comment_new> > <comment_new><author>@baronfel</author><body> > I do too - it feels more like a 'modular' approach - use the same 'primitives' that can be toggled on/off based on run-time state, etc.</body></comment_new> > </comments> > </details>  - Fixes #12929  --- 💬 We'd love your input! Share your thoughts on Copilot coding agent in our [2 minute survey](https://gh.io/copilot-coding-agent-survey). --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: baronfel <573979+baronfel@users.noreply.github.com> Co-authored-by: Chet Husk <baronfel@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
diff --git a/src/Build.UnitTests/Snapshots/TerminalLogger_Tests.PrintBuildSummaryQuietVerbosity_FailedWithErrors.Linux.verified.txt b/src/Build.UnitTests/Snapshots/TerminalLogger_Tests.PrintBuildSummaryQuietVerbosity_FailedWithErrors.Linux.verified.txt
@@ -1,8 +1,9 @@
 ﻿The plugin credential provider could not acquire credentials.Authentication may require manual action. Consider re-running the command with --interactive for `dotnet`, /p:NuGetInteractive="true" for MSBuild or removing the -NonInteractive switch for `NuGet`
-directory/[1mfile[m(1,2,3,4): [33;1mwarning[m [33;1mAA0000[m: Warning!
-directory/[1mfile[m(1,2,3,4): [33;1mwarning[m [33;1mAA0000[m: 
-  A
-  Multi
-  Line
-  Warning!
-directory/[1mfile[m(1,2,3,4): [31;1merror[m [31;1mAA0000[m: Error!
+  project [31;1mfailed with 1 error(s) and 2 warning(s)[m (0.2s)
+    directory/[1mfile[m(1,2,3,4): [33;1mwarning[m [33;1mAA0000[m: Warning!
+    directory/[1mfile[m(1,2,3,4): [33;1mwarning[m [33;1mAA0000[m: 
+      A
+      Multi
+      Line
+      Warning!
+    directory/[1mfile[m(1,2,3,4): [31;1merror[m [31;1mAA0000[m: Error!
diff --git a/src/Build.UnitTests/Snapshots/TerminalLogger_Tests.PrintBuildSummaryQuietVerbosity_FailedWithErrors.OSX.verified.txt b/src/Build.UnitTests/Snapshots/TerminalLogger_Tests.PrintBuildSummaryQuietVerbosity_FailedWithErrors.OSX.verified.txt
@@ -1,8 +1,9 @@
 The plugin credential provider could not acquire credentials.Authentication may require manual action. Consider re-running the command with --interactive for `dotnet`, /p:NuGetInteractive="true" for MSBuild or removing the -NonInteractive switch for `NuGet`
-directory/[1mfile[m(1,2,3,4): [33;1mwarning[m [33;1mAA0000[m: Warning!
-directory/[1mfile[m(1,2,3,4): [33;1mwarning[m [33;1mAA0000[m: 
-  A
-  Multi
-  Line
-  Warning!
-directory/[1mfile[m(1,2,3,4): [31;1merror[m [31;1mAA0000[m: Error!
+  project [31;1mfailed with 1 error(s) and 2 warning(s)[m (0.2s)
+    directory/[1mfile[m(1,2,3,4): [33;1mwarning[m [33;1mAA0000[m: Warning!
+    directory/[1mfile[m(1,2,3,4): [33;1mwarning[m [33;1mAA0000[m: 
+      A
+      Multi
+      Line
+      Warning!
+    directory/[1mfile[m(1,2,3,4): [31;1merror[m [31;1mAA0000[m: Error!
diff --git a/src/Build.UnitTests/Snapshots/TerminalLogger_Tests.PrintBuildSummaryQuietVerbosity_FailedWithErrors.Windows.verified.txt b/src/Build.UnitTests/Snapshots/TerminalLogger_Tests.PrintBuildSummaryQuietVerbosity_FailedWithErrors.Windows.verified.txt
@@ -1,8 +1,9 @@
 ﻿The plugin credential provider could not acquire credentials.Authentication may require manual action. Consider re-running the command with --interactive for `dotnet`, /p:NuGetInteractive="true" for MSBuild or removing the -NonInteractive switch for `NuGet`
-directory/[1mfile[m(1,2,3,4): [33;1mwarning[m [33;1mAA0000[m: Warning!
-directory/[1mfile[m(1,2,3,4): [33;1mwarning[m [33;1mAA0000[m: 
-  A
-  Multi
-  Line
-  Warning!
-directory/[1mfile[m(1,2,3,4): [31;1merror[m [31;1mAA0000[m: Error!
+  project [31;1mfailed with 1 error(s) and 2 warning(s)[m (0.2s)
+    directory/[1mfile[m(1,2,3,4): [33;1mwarning[m [33;1mAA0000[m: Warning!
+    directory/[1mfile[m(1,2,3,4): [33;1mwarning[m [33;1mAA0000[m: 
+      A
+      Multi
+      Line
+      Warning!
+    directory/[1mfile[m(1,2,3,4): [31;1merror[m [31;1mAA0000[m: Error!
diff --git a/src/Build/Logging/TerminalLogger/TerminalLogger.cs b/src/Build/Logging/TerminalLogger/TerminalLogger.cs
@@ -754,18 +754,23 @@ private void ProjectFinished(object sender, ProjectFinishedEventArgs e)
             UpdateNodeStatus(buildEventContext, null);
         }
 
-        // Continue execution and add project summary to the static part of the Console only if verbosity is higher than Quiet.
-        if (Verbosity <= LoggerVerbosity.Quiet)
-        {
-            return;
-        }
-
         ProjectContext c = new(buildEventContext);
 
         if (_projects.TryGetValue(c, out TerminalProjectInfo? project))
         {
             project.Succeeded = e.Succeeded;
             project.Stopwatch.Stop();
+
+            // In quiet mode, only show projects with errors or warnings.
+            // In higher verbosity modes, show projects based on other criteria.
+            if (Verbosity == LoggerVerbosity.Quiet && !project.HasErrorsOrWarnings)
+            {
+                // Still need to update counts even if not displaying
+                _buildErrorsCount += project.ErrorCount;
+                _buildWarningsCount += project.WarningCount;
+                return;
+            }
+
             lock (_lock)
             {
                 Terminal.BeginUpdate();
@@ -809,6 +814,7 @@ private void ProjectFinished(object sender, ProjectFinishedEventArgs e)
                     // If this was a notable project build, we print it as completed only if it's produced an output or warnings/error.
                     // If this is a test project, print it always, so user can see either a success or failure, otherwise success is hidden
                     // and it is hard to see if project finished, or did not run at all.
+                    // In quiet mode, we show the project header if there are errors/warnings (already checked above).
                     else if (project.OutputPath is not null || project.BuildMessages is not null || project.IsTestProject)
                     {
                         // Show project build complete and its output
@@ -839,7 +845,7 @@ private void ProjectFinished(object sender, ProjectFinishedEventArgs e)
                     _buildErrorsCount += project.ErrorCount;
                     _buildWarningsCount += project.WarningCount;
 
-                    if (_showNodesDisplay)
+                    if (_showNodesDisplay && Verbosity > LoggerVerbosity.Quiet)
                     {
                         DisplayNodes();
                     }
@@ -1300,27 +1306,24 @@ private void WarningRaised(object sender, BuildWarningEventArgs e)
         }
 
         if (buildEventContext is not null
-            && _projects.TryGetValue(new ProjectContext(buildEventContext), out TerminalProjectInfo? project)
-            && Verbosity > LoggerVerbosity.Quiet)
+            && _projects.TryGetValue(new ProjectContext(buildEventContext), out TerminalProjectInfo? project))
         {
             // If the warning is not a 'global' auth provider message, but is immediate, we render it immediately
             // but we don't early return so that the project also tracks it.
-            if (IsImmediateWarning(e.Code))
+            if (IsImmediateWarning(e.Code) && Verbosity > LoggerVerbosity.Quiet)
             {
                 RenderImmediateMessage(FormatWarningMessage(e, Indentation));
             }
 
             // This is the general case - _most_ warnings are not immediate, so we add them to the project summary
             // and display them in the per-project and final summary.
+            // In quiet mode, we still accumulate so they can be shown in project-grouped form later.
             project.AddBuildMessage(TerminalMessageSeverity.Warning, FormatWarningMessage(e, TripleIndentation));
         }
         else
         {
             // It is necessary to display warning messages reported by MSBuild,
-            // even if it's not tracked in _projects collection or the verbosity is Quiet.
-            // The idea here (similar to the implementation in ErrorRaised) is that
-            // even in Quiet scenarios we need to show warnings/errors, even if not in
-            // full project-tree view
+            // even if it's not tracked in _projects collection.
             RenderImmediateMessage(FormatWarningMessage(e, Indentation));
             _buildWarningsCount++;
         }
@@ -1385,14 +1388,15 @@ private void ErrorRaised(object sender, BuildErrorEventArgs e)
         BuildEventContext? buildEventContext = e.BuildEventContext;
 
         if (buildEventContext is not null
-            && _projects.TryGetValue(new ProjectContext(buildEventContext), out TerminalProjectInfo? project)
-            && Verbosity > LoggerVerbosity.Quiet)
+            && _projects.TryGetValue(new ProjectContext(buildEventContext), out TerminalProjectInfo? project))
         {
+            // Always accumulate errors in the project, even in quiet mode, so they can be shown
+            // in project-grouped form later.
             project.AddBuildMessage(TerminalMessageSeverity.Error, FormatErrorMessage(e, TripleIndentation));
         }
         else
         {
-            // It is necessary to display error messages reported by MSBuild, even if it's not tracked in _projects collection or the verbosity is Quiet.
+            // It is necessary to display error messages reported by MSBuild, even if it's not tracked in _projects collection.
             // For nicer formatting, any messages from the engine we strip the file portion from.
             bool hasMSBuildPlaceholderLocation = e.File.Equals("MSBUILD", StringComparison.Ordinal);
             RenderImmediateMessage(FormatErrorMessage(e, Indentation, requireFileAndLinePortion: !hasMSBuildPlaceholderLocation));

-Original file line number
+Diff line change
@@ @@ -1,8 +1,9 @@ @@
 The plugin credential provider could not acquire credentials.Authentication may require manual action. Consider re-running the command with --interactive for `dotnet`, /p:NuGetInteractive="true" for MSBuild or removing the -NonInteractive switch for `NuGet`
 -directory/[1mfile[m(1,2,3,4): [33;1mwarning[m [33;1mAA0000[m: Warning!
 -directory/[1mfile[m(1,2,3,4): [33;1mwarning[m [33;1mAA0000[m:
 -  A
 -  Multi
 -  Line
 -  Warning!
 -directory/[1mfile[m(1,2,3,4): [31;1merror[m [31;1mAA0000[m: Error!
 +  project [31;1mfailed with 1 error(s) and 2 warning(s)[m (0.2s)
 +    directory/[1mfile[m(1,2,3,4): [33;1mwarning[m [33;1mAA0000[m: Warning!
 +    directory/[1mfile[m(1,2,3,4): [33;1mwarning[m [33;1mAA0000[m:
 +      A
 +      Multi
 +      Line
 +      Warning!
 +    directory/[1mfile[m(1,2,3,4): [31;1merror[m [31;1mAA0000[m: Error!