Address code review feedback - improve Features.cs implementation

- Keep _featureStatusMap as readonly for safety
- Extract default feature map to CreateDefaultFeatureStatusMap method
- Avoid duplication between initialization and reset
- Use Clear() and re-populate in ResetFeatureStatusForTests
- All tests still passing

Co-authored-by: YuliiaKovalova <[email protected]>

Author: Copilot

src/Framework/Features.cs

@@ -36,14 +36,19 @@ public enum FeatureStatus
     /// </summary>
     public static class Features
     {
-        private static Dictionary<string, FeatureStatus> _featureStatusMap = new Dictionary<string, FeatureStatus>
+        private static readonly Dictionary<string, FeatureStatus> _featureStatusMap = CreateDefaultFeatureStatusMap();
+
+        private static Dictionary<string, FeatureStatus> CreateDefaultFeatureStatusMap()
         {
-            { "BuildCheck.Beta", FeatureStatus.Preview },
-            { "CachePlugins", FeatureStatus.Available }, // Project cache plugins (e.g., Quickbuild) are enabled by default but can be remotely disabled.
-            { "EvaluationContext_SharedSDKCachePolicy", FeatureStatus.Available }, // EvaluationContext supports the SharingPolicy.SharedSDKCache flag.
-            { "TerminalLogger_MultiLineHandler", FeatureStatus.Available }, // TerminalLogger has better explicit support for rendering multi-line messages
-            // Add more features here.
-        };
+            return new Dictionary<string, FeatureStatus>
+            {
+                { "BuildCheck.Beta", FeatureStatus.Preview },
+                { "CachePlugins", FeatureStatus.Available }, // Project cache plugins (e.g., Quickbuild) are enabled by default but can be remotely disabled.
+                { "EvaluationContext_SharedSDKCachePolicy", FeatureStatus.Available }, // EvaluationContext supports the SharingPolicy.SharedSDKCache flag.
+                { "TerminalLogger_MultiLineHandler", FeatureStatus.Available }, // TerminalLogger has better explicit support for rendering multi-line messages
+                // Add more features here.
+            };
+        }
 
         /// <summary>
         /// Checks if a feature is available or not.
@@ -72,13 +77,11 @@ internal static void SetFeatureAvailability(string featureName, FeatureStatus st
         /// </summary>
         internal static void ResetFeatureStatusForTests()
         {
-            _featureStatusMap = new Dictionary<string, FeatureStatus>
+            _featureStatusMap.Clear();
+            foreach (var kvp in CreateDefaultFeatureStatusMap())
             {
-                { "BuildCheck.Beta", FeatureStatus.Preview },
-                { "CachePlugins", FeatureStatus.Available },
-                { "EvaluationContext_SharedSDKCachePolicy", FeatureStatus.Available },
-                { "TerminalLogger_MultiLineHandler", FeatureStatus.Available },
-            };
+                _featureStatusMap[kvp.Key] = kvp.Value;
+            }
         }
 #endif
     }