Polyfill clean up and source package organization (#12977)

DustinCampbell · web-flow · commit dc7f357173d3 · 2026-01-07T18:02:21.000+01:00
This pull request represents a bit of clean up and should have no product impact. - a342950: I noticed that the `StringSyntaxAttribute` polyfill is declared in the wrong namespace. This attribute is only for IDE tooling support and probably doesn't actually work in non-.NET, since it was declared in the `System` namespace rather than `System.Diagnostics.CodeAnalysis`. I've fixed the polyfill and updated all of the files that had used conditional compilation gymnastics to deal with the incorrect namespace. - df61bee: Small changes to the `CallerArgumentExpressionAttribute` polyfill to match best practices. - 68b8bf2: Update links to the Compile and Content items in the `Microsoft.CodeAnalysis.*` source packages to display the items in separate folders rather than dumping them into the project root. This separates them in the Solution Explorer. <img width="300" height="620" alt="image" src="https://github.com/user-attachments/assets/012c9d54-db85-49bb-8eb5-266b20704741" />
diff --git a/src/Build/Microsoft.Build.csproj b/src/Build/Microsoft.Build.csproj
@@ -38,14 +38,36 @@
 
     <PackageReference Include="Microsoft.IO.Redist" Condition="'$(FeatureMSIORedist)' == 'true'" />
 
-    <PackageReference Include="Microsoft.CodeAnalysis.Collections" PrivateAssets="all" />
-    <PackageReference Include="Microsoft.CodeAnalysis.PooledObjects" PrivateAssets="all" />
     <PackageReference Include="Microsoft.BuildXL.Processes" Condition="'$(FeatureReportFileAccesses)' == 'true'" PrivateAssets="all" />
     <!-- Remove the direct NETStandard.Library dependency when Microsoft.BuildXL.Processes stops bringing in netstandard1.x dependencies
          or when a .NET 10 SDK is used (NuGet Package Pruning eliminates netstandard1.x dependencies). -->
     <PackageReference Include="NETStandard.Library" VersionOverride="2.0.3" PrivateAssets="all" Condition="'$(FeatureReportFileAccesses)' == 'true'" />
   </ItemGroup>
 
+  <ItemGroup>
+    <PackageReference Include="Microsoft.CodeAnalysis.Collections" PrivateAssets="all" />
+
+    <!-- Display files included by the Microsoft.CodeAnalysis.Collections source package in a 'SourcePackages\Collections' folder -->
+    <Content Update="@(Content)">
+      <Link Condition="'%(NuGetPackageId)' == 'Microsoft.CodeAnalysis.Collections'">SourcePackages\Collections\%(Link)</Link>
+    </Content>
+    <Compile Update="@(Compile)">
+      <Link Condition="'%(NuGetPackageId)' == 'Microsoft.CodeAnalysis.Collections'">SourcePackages\Collections\%(Link)</Link>
+    </Compile>
+  </ItemGroup>
+
+  <ItemGroup>
+    <PackageReference Include="Microsoft.CodeAnalysis.PooledObjects" PrivateAssets="all" />
+
+    <!-- Display files included by the Microsoft.CodeAnalysis.PooledObjects source package in a 'SourcePackages\PooledObjects' folder -->
+    <Content Update="@(Content)">
+      <Link Condition="'%(NuGetPackageId)' == 'Microsoft.CodeAnalysis.PooledObjects'">SourcePackages\PooledObjects\%(Link)</Link>
+    </Content>
+    <Compile Update="@(Compile)">
+      <Link Condition="'%(NuGetPackageId)' == 'Microsoft.CodeAnalysis.PooledObjects'">SourcePackages\PooledObjects\%(Link)</Link>
+    </Compile>
+  </ItemGroup>
+
   <ItemGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETFramework' and '$(DotNetBuildSourceOnly)' != 'true'">
     <PackageReference Include="Microsoft.VisualStudio.Setup.Configuration.Interop" PrivateAssets="all" />
   </ItemGroup>
diff --git a/src/Framework/BuildErrorEventArgs.cs b/src/Framework/BuildErrorEventArgs.cs
@@ -2,9 +2,7 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 
 using System;
-#if NET
 using System.Diagnostics.CodeAnalysis;
-#endif
 using System.IO;
 using Microsoft.Build.Shared;
 
diff --git a/src/Framework/BuildMessageEventArgs.cs b/src/Framework/BuildMessageEventArgs.cs
@@ -2,9 +2,7 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 
 using System;
-#if NET
 using System.Diagnostics.CodeAnalysis;
-#endif
 using System.IO;
 using System.Runtime.Serialization;
 using Microsoft.Build.Shared;
diff --git a/src/Framework/BuildWarningEventArgs.cs b/src/Framework/BuildWarningEventArgs.cs
@@ -2,9 +2,7 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 
 using System;
-#if NET
 using System.Diagnostics.CodeAnalysis;
-#endif
 using System.IO;
 using Microsoft.Build.Shared;
 
diff --git a/src/Framework/CriticalBuildMessageEventArgs.cs b/src/Framework/CriticalBuildMessageEventArgs.cs
@@ -2,9 +2,7 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 
 using System;
-#if NET
 using System.Diagnostics.CodeAnalysis;
-#endif
 
 #nullable disable
 
diff --git a/src/Framework/CustomBuildEventArgs.cs b/src/Framework/CustomBuildEventArgs.cs
@@ -2,9 +2,7 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 
 using System;
-#if NET
 using System.Diagnostics.CodeAnalysis;
-#endif
 
 #nullable disable
 
diff --git a/src/Framework/ExtendedBuildErrorEventArgs.cs b/src/Framework/ExtendedBuildErrorEventArgs.cs
@@ -3,9 +3,7 @@
 
 using System;
 using System.Collections.Generic;
-#if NET
 using System.Diagnostics.CodeAnalysis;
-#endif
 using System.IO;
 using Microsoft.Build.Shared;
 
diff --git a/src/Framework/ExtendedBuildWarningEventArgs.cs b/src/Framework/ExtendedBuildWarningEventArgs.cs
@@ -3,9 +3,7 @@
 
 using System;
 using System.Collections.Generic;
-#if NET
 using System.Diagnostics.CodeAnalysis;
-#endif
 using System.IO;
 using Microsoft.Build.Shared;
 
diff --git a/src/Framework/LazyFormattedBuildEventArgs.cs b/src/Framework/LazyFormattedBuildEventArgs.cs
@@ -2,9 +2,7 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 
 using System;
-#if NET
 using System.Diagnostics.CodeAnalysis;
-#endif
 using System.Globalization;
 using System.IO;
 
diff --git a/src/Framework/Microsoft.Build.Framework.csproj b/src/Framework/Microsoft.Build.Framework.csproj
@@ -16,6 +16,14 @@
 
   <ItemGroup>
     <PackageReference Include="Microsoft.CodeAnalysis.Contracts" PrivateAssets="all" />
+
+    <!-- Display files included by the Microsoft.CodeAnalysis.Contracts source package in a 'SourcePackages\Contracts' folder -->
+    <Content Update="@(Content)">
+      <Link Condition="'%(NuGetPackageId)' == 'Microsoft.CodeAnalysis.Contracts'">SourcePackages\Contracts\%(Link)</Link>
+    </Content>
+    <Compile Update="@(Compile)">
+      <Link Condition="'%(NuGetPackageId)' == 'Microsoft.CodeAnalysis.Contracts'">SourcePackages\Contracts\%(Link)</Link>
+    </Compile>
   </ItemGroup>
 
   <ItemGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETFramework'">
diff --git a/src/Framework/Polyfills/CallerArgumentExpressionAttribute.cs b/src/Framework/Polyfills/CallerArgumentExpressionAttribute.cs
@@ -1,9 +1,17 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
+#if NETCOREAPP3_0_OR_GREATER
+
+using System.Runtime.CompilerServices;
+
+// This is a supporting forwarder for an internal polyfill API
+[assembly: TypeForwardedTo(typeof(CallerArgumentExpressionAttribute))]
+
+#else
+
 namespace System.Runtime.CompilerServices;
 
-#if !NET
 [AttributeUsage(AttributeTargets.Parameter, AllowMultiple = false, Inherited = false)]
 internal sealed class CallerArgumentExpressionAttribute : Attribute
 {
@@ -14,4 +22,5 @@ public CallerArgumentExpressionAttribute(string parameterName)
 
     public string ParameterName { get; }
 }
+
 #endif
diff --git a/src/Framework/Polyfills/StringSyntaxAttribute.cs b/src/Framework/Polyfills/StringSyntaxAttribute.cs
@@ -1,9 +1,16 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
-#if !NET
+#if NET7_0_OR_GREATER
 
-using System;
+using System.Runtime.CompilerServices;
+
+// This is a supporting forwarder for an internal polyfill API
+[assembly: TypeForwardedTo(typeof(System.Diagnostics.CodeAnalysis.StringSyntaxAttribute))]
+
+#else
+
+namespace System.Diagnostics.CodeAnalysis;
 
 [AttributeUsage(AttributeTargets.Parameter | AttributeTargets.Field | AttributeTargets.Property, AllowMultiple = false, Inherited = false)]
 internal sealed class StringSyntaxAttribute : Attribute
@@ -67,4 +74,5 @@ public StringSyntaxAttribute(string syntax, params object?[] arguments)
     /// <summary>The syntax identifier for strings containing XML.</summary>
     public const string Xml = nameof(Xml);
 }
+
 #endif
diff --git a/src/Framework/ProjectImportedEventArgs.cs b/src/Framework/ProjectImportedEventArgs.cs
@@ -2,9 +2,7 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 
 using System;
-#if NET
 using System.Diagnostics.CodeAnalysis;
-#endif
 using System.IO;
 using Microsoft.Build.Shared;
 
diff --git a/src/Framework/TargetSkippedEventArgs.cs b/src/Framework/TargetSkippedEventArgs.cs
@@ -2,9 +2,7 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 
 using System;
-#if NET
 using System.Diagnostics.CodeAnalysis;
-#endif
 using System.IO;
 using Microsoft.Build.Shared;
 
diff --git a/src/Shared/TaskLoggingHelper.cs b/src/Shared/TaskLoggingHelper.cs
@@ -4,9 +4,7 @@
 using System;
 using System.Collections.Generic;
 using System.Diagnostics;
-#if NET
 using System.Diagnostics.CodeAnalysis;
-#endif
 using System.Globalization;
 using System.IO;
 using System.Resources;
diff --git a/src/Tasks/Error.cs b/src/Tasks/Error.cs
@@ -3,9 +3,7 @@
 
 #nullable disable
 
-#if NET
 using System.Diagnostics.CodeAnalysis;
-#endif
 using Microsoft.Build.Framework;
 
 namespace Microsoft.Build.Tasks
diff --git a/src/Tasks/Exec.cs b/src/Tasks/Exec.cs
@@ -3,9 +3,7 @@
 
 using System;
 using System.Collections.Generic;
-#if NET
 using System.Diagnostics.CodeAnalysis;
-#endif
 using System.IO;
 using System.Text;
 using System.Text.RegularExpressions;
diff --git a/src/Tasks/Warning.cs b/src/Tasks/Warning.cs
@@ -3,9 +3,7 @@
 
 #nullable disable
 
-#if NET
 using System.Diagnostics.CodeAnalysis;
-#endif
 using Microsoft.Build.Framework;
 
 namespace Microsoft.Build.Tasks
