Corrupt binary log in some circumstances

[rainersigwald]

The build in question is Microsoft-internal, so I can't share the .binlog file, but I am in possession of a binary log file that appears to have been generated badly.

s:\msbuild>msbuild /flp:v=d /noconlog S:\VS\src\xmake\msbuild_ddbld572.binlog
Microsoft (R) Build Engine version 15.6.76.11871 for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

There was an exception while reading the log file: Parameter "BuildEventContext" cannot be null.

s:\msbuild>msbuild /flp:errorsonly;logfile=msbuild.err2 /noconlog S:\VS\src\xmake\msbuild_ddbld572.binlog
Microsoft (R) Build Engine version 15.6.76.11871 for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

There was an exception while reading the log file: BinaryReader encountered an invalid string length of -1053630578 characters.

It appears to be safe to ignore the BuildEventContext part (and just skip message events with no message or context), but the latter is fatal as far as I can tell.

[AArnott]

My first guess is that your (uncompressed) file is longer than int.MaxValue, and although .NET streams are tracked by long, MSBuild may have some casts to int lurking around assuming it will never exceed an int's capacity, resulting in the int overflow that appears to be in the error.

Perhaps this https://github.com/Microsoft/msbuild/blob/ef1c6b1cdc/src/Shared/InterningBinaryReader.cs#L103?

This issue is marked as stale because feedback has been requested for 30 days with no response. Please respond within 14 days or this issue will be closed due to inactivity.