RemoveDir Task should error or prompt for confirmation when provided Directories argument is empty

[shahabhijeet]

Steps to reproduce

<RemoveDir Directories="$(My_local_DirPath)\" />

If at runtime $(My_Local_DirPath) is empty

RemoveDir will actually execute and print this on console
Removing Directory "\" and will delete the entire root.

Suggestion:

1. Prompt user if they really want to delete in this particular scenario
2. Or introduce a new parameter for RemoveDir task
   NoPrompt
   or
   Force

[rainersigwald]

Personally, I lean toward "If the directory to be removed is / or \, error out with no force option". If you really need to obliterate a drive in your build, you can do it via Exec or something, and I expect that to be dramatically less likely than the "didn't define a variable" case.

[shahabhijeet]

I couldn't agree more. RemoveDir should never delete the entire root.
The reason for my suggestion was partly wondering "why this was allowed for such a long time" and hence thought of how best to introduce breaking change to the existing task.