DotNet Core 3.1 - Resources Files no longer being resolved.

[owlyowl]

Steps to reproduce

Please see dotnet/corefx#42209 (comment)

I've upgraded a DotNet Core 3.0 project to 3.1 and explicitly set build version in global.json and in the csproj files to make sure everything is built to the same target.

1. Open sln.
2. Clean & build
3. From cli dotnet run
4. Attach debugger and open site
5. Observe LocalisationController.cs line 67 - resourceManager.GetResourceSet(CultureInfo.GetCultureInfo("en-US"), true, true) throws

Previously in 3.0 ResX files were being resolved correctly, now they're not able to be loaded in.
Here's the ILSpy:

Referred to here by Eric StJohn,

Can someone please let me know what email address would be best to share a repo with?

[ericstj]

@owlyowl you can zip it up and drag/drop into a github comment, or if you prefer to keep it off github you can email me at ericstj at microsoft dot com and I will distill it to a minimal repro and share it.

[owlyowl]

Thanks Eric Ill do that :) I'll shoot off an email on Monday alas in the middle of moving house

…

On Sat., 7 Dec. 2019, 5:49 am Eric StJohn, ***@***.***> wrote: @owlyowl <https://github.com/owlyowl> you can zip it up and drag/drop into a github comment, or if you prefer to keep it off github you can email me at ericstj at microsoft dot com and I will distill it to a minimal repro and share it. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4962>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAOT4CTA5FL3YOJL4OKD52TQXKNDLANCNFSM4JWDHPSQ> .

[ericstj]

@owlyowl I didn't get anything in email, were you able to send it?

Also, if you're willing to share more broadly you should be able to attach the zip to the issue (simply drag-drop into comments).

[ericstj]

Just to add some context for MSBuild folks. As shown in the ILSpy screenshot this assembly has no resources embedded. The screenshot shared in the linked issue showed the project's resx files:

I thought this could be related to #4597 or #4740

[benvillalobos]

Closing. We've done a lot of work on resources since this issue was filed. One of those changes may have covered this. If it hasn't, please reopen 😁