Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match encoding when WriteOnlyWhenDifferent is set #8362

Closed
wants to merge 3 commits into from
Closed

Match encoding when WriteOnlyWhenDifferent is set #8362

wants to merge 3 commits into from

Conversation

stan-sz
Copy link
Contributor

@stan-sz stan-sz commented Jan 27, 2023

Fixes #8361

@stan-sz
Copy link
Contributor Author

stan-sz commented Jan 27, 2023

Because the code fix is trivial, I've first coded up UTs to prove it's really an issue.

@JanKrivanek
Copy link
Member

@stan-sz do you plan to update this PR to address the failure?

@stan-sz
Copy link
Contributor Author

stan-sz commented Feb 15, 2023

Yes, though I think this PR does not capture the problem with encoding from the issue I opened.

@AR-May
Copy link
Member

AR-May commented Oct 10, 2023

Team triage: it seems that you are not going to update the PR, so we close it. If we are wrong, feel free to reopen the PR.

@AR-May AR-May closed this Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WriteOnlyWhenDifferent should check with the same encoding
3 participants
@stan-sz @JanKrivanek @AR-May