Copy task errors when copying a non existent file on itself #9240
Conversation
|
|
||
| Assert.False(success); | ||
|
|
||
| ((MockEngine)t.BuildEngine).AssertLogDoesntContain("MSB3026"); // Didn't do retries, nothing to do |
There was a problem hiding this comment.
We should probably as well assert on presence of 'MSB3030' ("Could not copy the file "{0}" because it was not found.")
There was a problem hiding this comment.
would a hypothetical AssertLogDoesntContainAnyMSBCodes() be useful
There was a problem hiding this comment.
AssertLogDoesntContainAnyMSBCodes(List<string>? except = null) or AssertLogContainsOnlyMSBCodes(List<string>? allowedCodes = null)
There was a problem hiding this comment.
Isn't part of the point of this that MSB3030 should show up?
There was a problem hiding this comment.
Yes - I meant we should assert that the code is present.
| @@ -1406,6 +1406,32 @@ public void CopyFileOnItself2(bool isUseHardLinks, bool isUseSymbolicLinks) | |||
| } | |||
| } | |||
|
|
|||
| [Theory] | |||
| [MemberData(nameof(GetHardLinksSymLinks))] | |||
| public void CopyFileItselfNonExistentFile(bool isUseHardLinks, bool isUseSymbolicLinks) | |||
There was a problem hiding this comment.
This behavior doesn't care if you're using hard links or symlinks or neither, right? Why do you need to run it four times?
Also:
| public void CopyFileItselfNonExistentFile(bool isUseHardLinks, bool isUseSymbolicLinks) | |
| public void CopyNonexistentFileOntoItselfThrows(bool isUseHardLinks, bool isUseSymbolicLinks) |
Fixes #9148
Context
During the copy task, if the origin and destination file have the same path (are the same file), and that file does not exist, we do not get an error and the task succeeds. It was decided that an error should be thrown instead.
Changes Made
In the Copy Task, I added a check for file existence if the file paths are the same. The process now throws an error if the file does not exist.
Testing
Added a unit test for the case