Skip to content

.NET 5 TargetFramework usage #1545

Closed
@sfoslund

Description

@sfoslund

With .NET 5 we are introducing a new style of target framework that includes target platform information (for example, net5.0-windows). This repo contains logic that will break with these new target frameworks, specifically, see this line: https://github.com/dotnet/performance/blob/master/src/benchmarks/real-world/JitBench/Store/CreateStore/bugfix_sdk_1682/Microsoft.NET.ComposeStore.targets#L431.
The TargetFrameworkMoniker cannot be used in place of the TargetFramework as the target framework moniker does not contain required platform information and will likely fail with new .NET 5 target frameworks like net5.0-windows. Please test and ensure that this target does not break .NET 5 scenarios, thanks!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions