Handle diagnostic spans that cover an entire attribute value (#12302)

Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2596952

This is all my fault, in my previous PR I did not create good test data,
so missed some logic for when the diagnostic spans the entire attribute
value.

Author: davidwengier

src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/Diagnostics/RazorTranslateDiagnosticsService.cs

@@ -422,12 +422,31 @@ private static bool InAttributeContainingCSharp(
             return false;
         }
 
-        var owner = syntaxTree.FindInnermostNode(sourceText, diagnostic.Range.End);
+        if (!sourceText.TryGetAbsoluteIndex(diagnostic.Range.End, out var absoluteIndex))
+        {
+            return false;
+        }
+
+        var owner = syntaxTree.Root.FindInnermostNode(absoluteIndex);
         if (owner is null)
         {
             return false;
         }
 
+        // If the owner is the close quote of an attribute value, then we need to move to the previous position, as
+        // the closing quote is actually owned by the whole attribute node. This will put us in the actual attribute
+        // value node for sure, and as long as the diagnostic range isn't zero-width, shouldn't affect semantics.
+        if (absoluteIndex > 0 &&
+            diagnostic.Range.Start != diagnostic.Range.End &&
+            owner is MarkupTextLiteralSyntax { LiteralTokens: [{ Content: "\"" or "'" }], Parent: MarkupTagHelperAttributeSyntax or MarkupAttributeBlockSyntax })
+        {
+            owner = syntaxTree.Root.FindInnermostNode(absoluteIndex - 1);
+            if (owner is null)
+            {
+                return false;
+            }
+        }
+
         var markupAttributeValue = owner.FirstAncestorOrSelf<RazorSyntaxNode>(static n =>
             (n.Parent is MarkupAttributeBlockSyntax block && n == block.Value) ||
             n is MarkupTagHelperAttributeValueSyntax or MarkupMiscAttributeContentSyntax);

src/Razor/test/Microsoft.VisualStudio.LanguageServices.Razor.Test/Cohost/CohostDocumentPullDiagnosticsTest.cs

@@ -378,9 +378,10 @@ public Task FilterPropertyValueInCss()
     [Fact]
     public Task FilterPropertyNameInCss()
     {
-        TestCode input = """
-            <div style="{|CSS024:/|}****/"></div>
-            <div style="@(someBool ? "width: 100%" : "width: 50%")">
+        const string CSharpExpression = """@(someBool ? "width: 100%" : "width: 50%")""";
+        TestCode input = $$"""
+            <div style="{|CSS024:/****/|}"></div>
+            <div style="{{CSharpExpression}}">
 
             </div>
 
@@ -398,12 +399,51 @@ public Task FilterPropertyNameInCss()
                     new LspDiagnostic
                     {
                         Code = CSSErrorCodes.MissingPropertyName,
-                        Range = SourceText.From(input.Text).GetRange(new TextSpan(input.Text.IndexOf("/"), 1))
+                        Range = SourceText.From(input.Text).GetRange(new TextSpan(input.Text.IndexOf("/"), "/****/".Length))
                     },
                     new LspDiagnostic
                     {
                         Code = CSSErrorCodes.MissingPropertyName,
-                        Range = SourceText.From(input.Text).GetRange(new TextSpan(input.Text.IndexOf("@"), 1))
+                        Range = SourceText.From(input.Text).GetRange(new TextSpan(input.Text.IndexOf("@"), CSharpExpression.Length))
+                    },
+                ]
+            }]);
+    }
+
+    [Theory]
+    [InlineData("", "\"")]
+    [InlineData("", "'")]
+    [InlineData("@onclick=\"Send\"", "\"")] // The @onclick makes the disabled attribute a TagHelperAttributeSyntax
+    [InlineData("@onclick='Send'", "'")]
+    public Task FilterBadAttributeValueInHtml(string extraTagContent, string quoteChar)
+    {
+        TestCode input = $$"""
+            <button {{extraTagContent}} disabled={{quoteChar}}@(!EnableMyButton){{quoteChar}}>Send</button>
+            <button disabled={{quoteChar}}{|HTML0209:ThisIsNotValid|}{{quoteChar}} />
+
+            @code
+            {
+                private bool EnableMyButton => true;
+
+                Task Send() =>
+                    Task.CompletedTask;
+            }
+            """;
+
+        return VerifyDiagnosticsAsync(input,
+            htmlResponse: [new VSInternalDiagnosticReport
+            {
+                Diagnostics =
+                [
+                    new LspDiagnostic
+                    {
+                        Code = HtmlErrorCodes.UnknownAttributeValueErrorCode,
+                        Range = SourceText.From(input.Text).GetRange(new TextSpan(input.Text.IndexOf("@("), "@(!EnableMyButton)".Length))
+                    },
+                    new LspDiagnostic
+                    {
+                        Code = HtmlErrorCodes.UnknownAttributeValueErrorCode,
+                        Range = SourceText.From(input.Text).GetRange(new TextSpan(input.Text.IndexOf("T"), "ThisIsNotValid".Length))
                     },
                 ]
             }]);