Changes to our options, in Unified Settings at least, are delayed

[davidwengier]

Not sure if this is us, or a Unified Settings bug, but we're not handling changes correctly. @ryzngard do you know if this is expected to work yet?

[ryzngard]

hmm, I'm unsure. It's hard to tell exactly from the gif (without watching over and over again). I'll chat offline with you to understand the problem better.

I'm assuming if you go back to the traditional settings everything works as expected?

[davidwengier]

Debugged through this. When a setting changes in Unified settings, we get a call to OnUnifiedSettingsChanged which tells us which setting has changed, but when we fire events etc the Get methods call into _writableSettingsStore but it seems like that doesn't have the new value yet. Suspect this is either a bug in the Unified settings system, or we're supposed to be checking something different, but I don't think there is anything we can actually do explicitly to fix it. The event we get doesn't have the value of the setting, only the name, so we can't force it into the store at that point.

[ryzngard]

Yea, the only thing I can think of is that either it's a unified settings bug or our mapping for the setting is off. If it's eventually updated, I would say it's the former. The whole point in us providing a mapping is so that they know what "traditional" location to update.

There could also be changes in how we're supposed to be doing things. I can reach out to the team this week.