Ensure @model types have a mapping in razor pages #11844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet/razor-compiler For reviews please :) |
|
Can you please rename the PR for clarity? |
333fred
approved these changes
May 12, 2025
jjonescz
reviewed
May 13, 2025
| #nullable restore | ||
| public TestFiles_IntegrationTests_CodeGenerationIntegrationTest_IncompleteDirectives Model => ViewData.Model!; | ||
| #nullable disable | ||
| public TestFiles_IntegrationTests_CodeGenerationIntegrationTest_IncompleteDirectives Model => ViewData.Model; |
There was a problem hiding this comment.
This looks suspicious. Previously the Model property here was nullable-enabled, now it's nullable-disabled, isn't that a regression?
There was a problem hiding this comment.
The Model property in this case isn't coming from the user, if you look it's the type of name of the file which is generated code, declared outside of the users nullability annotations. So, it's correct that it shouldn't be nullable annotated.
jjonescz
approved these changes
May 14, 2025
This was referenced May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure we write out the mapping for
@modeltypes in razor pages.Commit by commit should hopefully make the fix pretty self-explanatory.
Fixes: #11329