Visual Studio 17.6.5: Broken Format Document in @section with closing brace character

[m-gallesio]

I have noticed the Format Document command (Ctrl + K,D) in Visual Studio (17.6.5) has problems when a @section contains a closing curly brace:

Note how the inner closing braces have the same colour of the section delimiters.
The code in the first section uses Aurelia 1's interpolation syntax.
I do not recall this happening with the legacy Razor editor, which does not seem available anymore.

[davidwengier]

I think this might be related to #7608 and what you see as a close brace in a section, is interpreted by the compiler as the close of the section. Unfortunately Razor does not do well with out-of-context JavaScript in a few ways.

[m-gallesio]

Note that our use case is the first, the second example is very artificial.
One more thing to note about the legacy Razor editor is that it did seem to give special treatment to ${} blocks by highlighting their content (in bright magenta in the default Dark theme).

[mbutler-qc]

Something similar going on here in Visual Studio 17.7.0.

Unwanted curly brace movement on document format. A slight twist is that depending on the type of variable being declared, the behaviour is different.

(CSHTML file with nothing else in it. Watch lines 15 & 26)

I noticed that when the closing curly braces move incorrectly on a "format document" command, they seem to move by two tabs.

[davidwengier]

Thanks @mbutler-qc ive moved your comment to #9119 as it's a separate issue

[csijake]

I don't know if this is related, but I've noticed a bug in this version as well - when you auto-format (Ctrl+K, Ctrl+D) a Razor page, the braces for @section directives are not correct.

Given this incorrect formatting:

@section mySection

   {
             <p>Content</p>
 }

When I run formatting, I expect it to do this:

@section mySection
{
    <p>Content</p>
}

But instead, it's doing this:

@section mySection
    {
    <p>Content</p>
 }

Why is it indenting the first brace? Can this be fixed in a future patch?

[davidwengier]

@csijake Based on those examples I think you are hitting a separate bug. Section indentation is surprisingly complicated, and is affected by the other code surrounding it. If you could log a new issue, and include the whole file contents where you run into it (preferably a minimal repro, and not one of your actual .razor files 😁), and which version of VS you're using, that would be very helpful.