Use flight experiment to allow skipping semantic token for html syntax #9372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
STEP 2: - Using IsCachedFlightEnabled to check for flight experiment - Adds SkipHtmlSyntaxSemanticTokens feature flag - Uses the feature flag to skip tokens for html syntax - Added for LanguageServerFeatureOptions - Defaults to false - No need for user toggle option - Only can get enabled via flight experiments TODO - [ ] Run instance see if the TextMate issues are still present
Reveals which semantic token test results would be affected when we start skipping semantic token generation for html syntax for razor documents
Comparisons (WIP - Will add more screenshots later)There would be some pretty noticable differences between having the html syntax skipping tokens (only TextMate) vs not: (TextMate on right hand side): Few examples from the above screenshot:
|
|
I assume these differences aren't easily captured in the textmate grammar. If not, it looks like textmate classification isn't an option. Given that, is there something that can be done to prevent the textmate grammar from contributing to colorization? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently the LSP semantic tokens call identifies html syntax rather than purely relying on TextMate.
This PR helps use flight experiments that would help understand whether or not we would regress performance when using only TextMate for html syntax.
Implementation Detail:
TODO (next)
IVsExperimentationService.IsCachedFlightEnabledw/out needing a feature flagTODO (After reviewing the flight experiment) we may decide to
Fixes #9256