From 1d97873d9f4e99a20e994e5ab77ad3dca09adb56 Mon Sep 17 00:00:00 2001 From: Andrew Hall Date: Fri, 21 Feb 2025 21:22:32 -0800 Subject: [PATCH 1/8] Upgrade to net9 --- Directory.Build.props | 2 +- .../Microsoft.AspNetCore.Razor.Microbenchmarks/Resources.cs | 5 +++++ .../Utilities/StreamExtensions.NetCore.cs | 2 +- .../RazorTestResources.cs | 5 +++++ 4 files changed, 12 insertions(+), 2 deletions(-) diff --git a/Directory.Build.props b/Directory.Build.props index 8c293b9a383..8940a653b7f 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -81,7 +81,7 @@ --> - net8.0 + net9.0 $(DefaultNetCoreTargetFramework) diff --git a/src/Razor/benchmarks/Microsoft.AspNetCore.Razor.Microbenchmarks/Resources.cs b/src/Razor/benchmarks/Microsoft.AspNetCore.Razor.Microbenchmarks/Resources.cs index 601d9fbfd4c..64139cc5f58 100644 --- a/src/Razor/benchmarks/Microsoft.AspNetCore.Razor.Microbenchmarks/Resources.cs +++ b/src/Razor/benchmarks/Microsoft.AspNetCore.Razor.Microbenchmarks/Resources.cs @@ -62,7 +62,12 @@ public static byte[] GetResourceBytes(string name, string? folder = null) using var stream = GetResourceStream(name, folder); value = new byte[stream.Length]; + +#if NET + stream.ReadExactly(value); +#else stream.Read(value, 0, value.Length); +#endif s_bytesMap.Add(key, value); diff --git a/src/Razor/src/Microsoft.AspNetCore.Razor.ProjectEngineHost/Utilities/StreamExtensions.NetCore.cs b/src/Razor/src/Microsoft.AspNetCore.Razor.ProjectEngineHost/Utilities/StreamExtensions.NetCore.cs index 81abc7a2a16..6e0897eafcc 100644 --- a/src/Razor/src/Microsoft.AspNetCore.Razor.ProjectEngineHost/Utilities/StreamExtensions.NetCore.cs +++ b/src/Razor/src/Microsoft.AspNetCore.Razor.ProjectEngineHost/Utilities/StreamExtensions.NetCore.cs @@ -103,7 +103,7 @@ public static void WriteSize(this Stream stream, int length) public unsafe static int ReadSize(this Stream stream) { Span bytes = stackalloc byte[4]; - stream.Read(bytes); + stream.ReadExactly(bytes); return BitConverter.ToInt32(bytes); } } diff --git a/src/Razor/test/Microsoft.AspNetCore.Razor.Test.Common.Tooling/RazorTestResources.cs b/src/Razor/test/Microsoft.AspNetCore.Razor.Test.Common.Tooling/RazorTestResources.cs index 48ceb0cdb85..f010154b432 100644 --- a/src/Razor/test/Microsoft.AspNetCore.Razor.Test.Common.Tooling/RazorTestResources.cs +++ b/src/Razor/test/Microsoft.AspNetCore.Razor.Test.Common.Tooling/RazorTestResources.cs @@ -69,7 +69,12 @@ public static byte[] GetResourceBytes(string name, string? folder = null) using var stream = GetResourceStream(name, folder); value = new byte[stream.Length]; + +#if NET + stream.ReadExactly(value); +#else stream.Read(value, 0, value.Length); +#endif s_bytesMap.Add(key, value); From 257460cf954617f28e1dc9d68e2ccb2f67495ece Mon Sep 17 00:00:00 2001 From: Andrew Hall Date: Mon, 24 Feb 2025 17:44:08 -0800 Subject: [PATCH 2/8] Use net8 and net9 --- Directory.Build.props | 8 ++++++-- .../Microsoft.VisualStudio.DevKit.Razor.csproj | 2 +- src/Razor/src/rzls/rzls.csproj | 2 +- 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/Directory.Build.props b/Directory.Build.props index 8940a653b7f..e8222df6bfe 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -45,6 +45,10 @@ net472 + net8.0 + net9.0 + net8.0;net9.0 + @@ -81,8 +85,8 @@ --> - net9.0 - $(DefaultNetCoreTargetFramework) + $(NetVS) + $(NetRazorAll) diff --git a/src/Razor/src/Microsoft.VisualStudio.DevKit.Razor/Microsoft.VisualStudio.DevKit.Razor.csproj b/src/Razor/src/Microsoft.VisualStudio.DevKit.Razor/Microsoft.VisualStudio.DevKit.Razor.csproj index 29b5acecb67..fb4eaa37e1f 100644 --- a/src/Razor/src/Microsoft.VisualStudio.DevKit.Razor/Microsoft.VisualStudio.DevKit.Razor.csproj +++ b/src/Razor/src/Microsoft.VisualStudio.DevKit.Razor/Microsoft.VisualStudio.DevKit.Razor.csproj @@ -1,7 +1,7 @@  - $(DefaultNetCoreTargetFramework) + $(NetVSCode) Library Razor is a markup syntax for adding server-side logic to web pages. This package contains the language server assets for C# DevKit. false diff --git a/src/Razor/src/rzls/rzls.csproj b/src/Razor/src/rzls/rzls.csproj index 917ff821743..b36f7f8bdd8 100644 --- a/src/Razor/src/rzls/rzls.csproj +++ b/src/Razor/src/rzls/rzls.csproj @@ -1,7 +1,7 @@  - $(DefaultNetCoreTargetFramework) + $(NetVSCode) Exe Razor is a markup syntax for adding server-side logic to web pages. This package contains a Razor language server. From 031c05a9da0e330c025e019b6d04a4ee68965866 Mon Sep 17 00:00:00 2001 From: Andrew Hall Date: Tue, 4 Mar 2025 10:57:06 -0800 Subject: [PATCH 3/8] Use IsVSCodeOnly to indicate --- Directory.Build.props | 9 +++------ .../Microsoft.VisualStudio.DevKit.Razor.csproj | 3 ++- src/Razor/src/rzls/rzls.csproj | 3 ++- 3 files changed, 7 insertions(+), 8 deletions(-) diff --git a/Directory.Build.props b/Directory.Build.props index e8222df6bfe..7ee885716e3 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -45,10 +45,6 @@ net472 - net8.0 - net9.0 - net8.0;net9.0 - @@ -85,8 +81,9 @@ --> - $(NetVS) - $(NetRazorAll) + net9.0 + net8.0 + $(DefaultNetCoreTargetFramework) diff --git a/src/Razor/src/Microsoft.VisualStudio.DevKit.Razor/Microsoft.VisualStudio.DevKit.Razor.csproj b/src/Razor/src/Microsoft.VisualStudio.DevKit.Razor/Microsoft.VisualStudio.DevKit.Razor.csproj index fb4eaa37e1f..1543709891a 100644 --- a/src/Razor/src/Microsoft.VisualStudio.DevKit.Razor/Microsoft.VisualStudio.DevKit.Razor.csproj +++ b/src/Razor/src/Microsoft.VisualStudio.DevKit.Razor/Microsoft.VisualStudio.DevKit.Razor.csproj @@ -1,12 +1,13 @@  - $(NetVSCode) + $(DefaultNetCoreTargetFramework) Library Razor is a markup syntax for adding server-side logic to web pages. This package contains the language server assets for C# DevKit. false true true + true $(NoWarn);NU5100 diff --git a/src/Razor/src/rzls/rzls.csproj b/src/Razor/src/rzls/rzls.csproj index b36f7f8bdd8..293c698111a 100644 --- a/src/Razor/src/rzls/rzls.csproj +++ b/src/Razor/src/rzls/rzls.csproj @@ -1,7 +1,7 @@  - $(NetVSCode) + $(DefaultNetCoreTargetFramework) Exe Razor is a markup syntax for adding server-side logic to web pages. This package contains a Razor language server. @@ -9,6 +9,7 @@ false true LatestMajor + true - net9.0 - net8.0 + net8.0 $(DefaultNetCoreTargetFramework) diff --git a/src/Razor/benchmarks/Microsoft.AspNetCore.Razor.Microbenchmarks/Resources.cs b/src/Razor/benchmarks/Microsoft.AspNetCore.Razor.Microbenchmarks/Resources.cs index 64139cc5f58..601d9fbfd4c 100644 --- a/src/Razor/benchmarks/Microsoft.AspNetCore.Razor.Microbenchmarks/Resources.cs +++ b/src/Razor/benchmarks/Microsoft.AspNetCore.Razor.Microbenchmarks/Resources.cs @@ -62,12 +62,7 @@ public static byte[] GetResourceBytes(string name, string? folder = null) using var stream = GetResourceStream(name, folder); value = new byte[stream.Length]; - -#if NET - stream.ReadExactly(value); -#else stream.Read(value, 0, value.Length); -#endif s_bytesMap.Add(key, value); diff --git a/src/Razor/src/Microsoft.AspNetCore.Razor.ProjectEngineHost/Utilities/StreamExtensions.NetCore.cs b/src/Razor/src/Microsoft.AspNetCore.Razor.ProjectEngineHost/Utilities/StreamExtensions.NetCore.cs index 6e0897eafcc..81abc7a2a16 100644 --- a/src/Razor/src/Microsoft.AspNetCore.Razor.ProjectEngineHost/Utilities/StreamExtensions.NetCore.cs +++ b/src/Razor/src/Microsoft.AspNetCore.Razor.ProjectEngineHost/Utilities/StreamExtensions.NetCore.cs @@ -103,7 +103,7 @@ public static void WriteSize(this Stream stream, int length) public unsafe static int ReadSize(this Stream stream) { Span bytes = stackalloc byte[4]; - stream.ReadExactly(bytes); + stream.Read(bytes); return BitConverter.ToInt32(bytes); } } diff --git a/src/Razor/src/Microsoft.VisualStudio.DevKit.Razor/Microsoft.VisualStudio.DevKit.Razor.csproj b/src/Razor/src/Microsoft.VisualStudio.DevKit.Razor/Microsoft.VisualStudio.DevKit.Razor.csproj index 1543709891a..29b5acecb67 100644 --- a/src/Razor/src/Microsoft.VisualStudio.DevKit.Razor/Microsoft.VisualStudio.DevKit.Razor.csproj +++ b/src/Razor/src/Microsoft.VisualStudio.DevKit.Razor/Microsoft.VisualStudio.DevKit.Razor.csproj @@ -7,7 +7,6 @@ false true true - true $(NoWarn);NU5100 diff --git a/src/Razor/src/rzls/rzls.csproj b/src/Razor/src/rzls/rzls.csproj index 293c698111a..917ff821743 100644 --- a/src/Razor/src/rzls/rzls.csproj +++ b/src/Razor/src/rzls/rzls.csproj @@ -9,7 +9,6 @@ false true LatestMajor - true - $(NetCurrent) - $(DefaultNetCoreTargetFramework);$(NetPrevious) + $(NetCurrent) + $(NetCurrent) + $(NetVS);$(NetVSCode);$(NetPrevious) @@ -74,8 +75,9 @@ --> - $(NetCurrent) - $(DefaultNetCoreTargetFramework) + $(NetCurrent) + $(NetCurrent) + $(NetVS);$(NetVSCode) @@ -84,8 +86,9 @@ --> - net8.0 - $(DefaultNetCoreTargetFramework) + net8.0 + net9.0 + $(NetVS);$(NetVSCode) diff --git a/src/Analyzers/Razor.Diagnostics.Analyzers.Test/Razor.Diagnostics.Analyzers.Test.csproj b/src/Analyzers/Razor.Diagnostics.Analyzers.Test/Razor.Diagnostics.Analyzers.Test.csproj index d8977ed8c0f..b2d80d5d9ca 100644 --- a/src/Analyzers/Razor.Diagnostics.Analyzers.Test/Razor.Diagnostics.Analyzers.Test.csproj +++ b/src/Analyzers/Razor.Diagnostics.Analyzers.Test/Razor.Diagnostics.Analyzers.Test.csproj @@ -1,7 +1,7 @@  - $(DefaultNetCoreTargetFrameworks) + $(NetVSAndVSCode) $(TargetFrameworks);$(DefaultNetFxTargetFramework) false diff --git a/src/Compiler/Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X/test/Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X.Test.csproj b/src/Compiler/Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X/test/Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X.Test.csproj index 2e08aafa62a..1bbd1e93456 100644 --- a/src/Compiler/Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X/test/Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X.Test.csproj +++ b/src/Compiler/Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X/test/Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X.Test.csproj @@ -1,7 +1,7 @@ - $(DefaultNetCoreTargetFrameworks) + $(NetVSAndVSCode) $(TargetFrameworks);$(DefaultNetFxTargetFramework) true $(DefaultItemExcludes);TestFiles\** diff --git a/src/Compiler/Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X/test/Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X.Test.csproj b/src/Compiler/Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X/test/Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X.Test.csproj index f6e46a90c51..cfce6b091fb 100644 --- a/src/Compiler/Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X/test/Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X.Test.csproj +++ b/src/Compiler/Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X/test/Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X.Test.csproj @@ -1,7 +1,7 @@ - $(DefaultNetCoreTargetFrameworks) + $(NetVSAndVSCode) $(TargetFrameworks);$(DefaultNetFxTargetFramework) true $(DefaultItemExcludes);TestFiles\** diff --git a/src/Compiler/Microsoft.AspNetCore.Mvc.Razor.Extensions/test/Microsoft.AspNetCore.Mvc.Razor.Extensions.Test.csproj b/src/Compiler/Microsoft.AspNetCore.Mvc.Razor.Extensions/test/Microsoft.AspNetCore.Mvc.Razor.Extensions.Test.csproj index cb0e17990ed..7f257ca6697 100644 --- a/src/Compiler/Microsoft.AspNetCore.Mvc.Razor.Extensions/test/Microsoft.AspNetCore.Mvc.Razor.Extensions.Test.csproj +++ b/src/Compiler/Microsoft.AspNetCore.Mvc.Razor.Extensions/test/Microsoft.AspNetCore.Mvc.Razor.Extensions.Test.csproj @@ -1,7 +1,7 @@ - $(DefaultNetCoreTargetFrameworks) + $(NetVSAndVSCode) $(TargetFrameworks);$(DefaultNetFxTargetFramework) true $(DefaultItemExcludes);TestFiles\** diff --git a/src/Compiler/Microsoft.AspNetCore.Razor.Language/legacyTest/Microsoft.AspNetCore.Razor.Language.Legacy.Test.csproj b/src/Compiler/Microsoft.AspNetCore.Razor.Language/legacyTest/Microsoft.AspNetCore.Razor.Language.Legacy.Test.csproj index de7e8dca499..4702f6f8c12 100644 --- a/src/Compiler/Microsoft.AspNetCore.Razor.Language/legacyTest/Microsoft.AspNetCore.Razor.Language.Legacy.Test.csproj +++ b/src/Compiler/Microsoft.AspNetCore.Razor.Language/legacyTest/Microsoft.AspNetCore.Razor.Language.Legacy.Test.csproj @@ -1,7 +1,7 @@  - $(DefaultNetCoreTargetFrameworks) + $(NetVSAndVSCode) $(TargetFrameworks);$(DefaultNetFxTargetFramework) $(DefaultItemExcludes);TestFiles\**\* diff --git a/src/Compiler/Microsoft.AspNetCore.Razor.Language/test/Microsoft.AspNetCore.Razor.Language.Test.csproj b/src/Compiler/Microsoft.AspNetCore.Razor.Language/test/Microsoft.AspNetCore.Razor.Language.Test.csproj index 5c51e9d6741..a2cb8de5fb8 100644 --- a/src/Compiler/Microsoft.AspNetCore.Razor.Language/test/Microsoft.AspNetCore.Razor.Language.Test.csproj +++ b/src/Compiler/Microsoft.AspNetCore.Razor.Language/test/Microsoft.AspNetCore.Razor.Language.Test.csproj @@ -1,7 +1,7 @@ - $(DefaultNetCoreTargetFrameworks) + $(NetVSAndVSCode) $(TargetFrameworks);$(DefaultNetFxTargetFramework) $(DefaultItemExcludes);TestFiles\**\* diff --git a/src/Compiler/Microsoft.CodeAnalysis.Razor.Compiler/src/Microsoft.CodeAnalysis.Razor.Compiler.csproj b/src/Compiler/Microsoft.CodeAnalysis.Razor.Compiler/src/Microsoft.CodeAnalysis.Razor.Compiler.csproj index 6428e0f55ed..6970f30055b 100644 --- a/src/Compiler/Microsoft.CodeAnalysis.Razor.Compiler/src/Microsoft.CodeAnalysis.Razor.Compiler.csproj +++ b/src/Compiler/Microsoft.CodeAnalysis.Razor.Compiler/src/Microsoft.CodeAnalysis.Razor.Compiler.csproj @@ -2,7 +2,7 @@ Razor is a markup syntax for adding server-side logic to web pages. This package contains the Razor compiler. - $(DefaultNetCoreTargetFramework);netstandard2.0 + $(NetVSAndVSCode);netstandard2.0 false true true diff --git a/src/Compiler/Microsoft.CodeAnalysis.Razor/test/Microsoft.CodeAnalysis.Razor.Test.csproj b/src/Compiler/Microsoft.CodeAnalysis.Razor/test/Microsoft.CodeAnalysis.Razor.Test.csproj index 1b3c0be1035..43c247d0a96 100644 --- a/src/Compiler/Microsoft.CodeAnalysis.Razor/test/Microsoft.CodeAnalysis.Razor.Test.csproj +++ b/src/Compiler/Microsoft.CodeAnalysis.Razor/test/Microsoft.CodeAnalysis.Razor.Test.csproj @@ -1,7 +1,7 @@  - $(DefaultNetCoreTargetFrameworks) + $(NetVSAndVSCode) $(TargetFrameworks);$(DefaultNetFxTargetFramework) $(DefaultItemExcludes);TestFiles\**\* true diff --git a/src/Compiler/perf/Microbenchmarks/Microsoft.AspNetCore.Razor.Microbenchmarks.Compiler.csproj b/src/Compiler/perf/Microbenchmarks/Microsoft.AspNetCore.Razor.Microbenchmarks.Compiler.csproj index 897f08cd510..f0b9e4dbc40 100644 --- a/src/Compiler/perf/Microbenchmarks/Microsoft.AspNetCore.Razor.Microbenchmarks.Compiler.csproj +++ b/src/Compiler/perf/Microbenchmarks/Microsoft.AspNetCore.Razor.Microbenchmarks.Compiler.csproj @@ -1,7 +1,7 @@  - $(DefaultNetCoreTargetFrameworks) + $(NetVSAndVSCode) Exe true true diff --git a/src/Compiler/perf/Microsoft.AspNetCore.Razor.Microbenchmarks.Generator/Microsoft.AspNetCore.Razor.Microbenchmarks.Generator.csproj b/src/Compiler/perf/Microsoft.AspNetCore.Razor.Microbenchmarks.Generator/Microsoft.AspNetCore.Razor.Microbenchmarks.Generator.csproj index 501e4975322..0f76248d930 100644 --- a/src/Compiler/perf/Microsoft.AspNetCore.Razor.Microbenchmarks.Generator/Microsoft.AspNetCore.Razor.Microbenchmarks.Generator.csproj +++ b/src/Compiler/perf/Microsoft.AspNetCore.Razor.Microbenchmarks.Generator/Microsoft.AspNetCore.Razor.Microbenchmarks.Generator.csproj @@ -2,7 +2,7 @@ Exe - $(DefaultNetCoreTargetFramework) + $(NetVS) enable enable Debug;Release diff --git a/src/Compiler/test/Microsoft.AspNetCore.Razor.Test.MvcShim.Version1_X/Microsoft.AspNetCore.Razor.Test.MvcShim.Version1_X.Compiler.csproj b/src/Compiler/test/Microsoft.AspNetCore.Razor.Test.MvcShim.Version1_X/Microsoft.AspNetCore.Razor.Test.MvcShim.Version1_X.Compiler.csproj index d2882f3e6f3..480f57774e4 100644 --- a/src/Compiler/test/Microsoft.AspNetCore.Razor.Test.MvcShim.Version1_X/Microsoft.AspNetCore.Razor.Test.MvcShim.Version1_X.Compiler.csproj +++ b/src/Compiler/test/Microsoft.AspNetCore.Razor.Test.MvcShim.Version1_X/Microsoft.AspNetCore.Razor.Test.MvcShim.Version1_X.Compiler.csproj @@ -1,7 +1,7 @@  - $(DefaultNetCoreTargetFrameworks);$(DefaultNetFxTargetFramework) + $(NetVSAndVSCode);$(DefaultNetFxTargetFramework) true diff --git a/src/Compiler/test/Microsoft.AspNetCore.Razor.Test.MvcShim.Version2_X/Microsoft.AspNetCore.Razor.Test.MvcShim.Version2_X.Compiler.csproj b/src/Compiler/test/Microsoft.AspNetCore.Razor.Test.MvcShim.Version2_X/Microsoft.AspNetCore.Razor.Test.MvcShim.Version2_X.Compiler.csproj index d2882f3e6f3..480f57774e4 100644 --- a/src/Compiler/test/Microsoft.AspNetCore.Razor.Test.MvcShim.Version2_X/Microsoft.AspNetCore.Razor.Test.MvcShim.Version2_X.Compiler.csproj +++ b/src/Compiler/test/Microsoft.AspNetCore.Razor.Test.MvcShim.Version2_X/Microsoft.AspNetCore.Razor.Test.MvcShim.Version2_X.Compiler.csproj @@ -1,7 +1,7 @@  - $(DefaultNetCoreTargetFrameworks);$(DefaultNetFxTargetFramework) + $(NetVSAndVSCode);$(DefaultNetFxTargetFramework) true diff --git a/src/Compiler/test/Microsoft.NET.Sdk.Razor.SourceGenerators.Tests/Microsoft.NET.Sdk.Razor.SourceGenerators.Test.csproj b/src/Compiler/test/Microsoft.NET.Sdk.Razor.SourceGenerators.Tests/Microsoft.NET.Sdk.Razor.SourceGenerators.Test.csproj index 581f9841034..5b2d9a3302c 100644 --- a/src/Compiler/test/Microsoft.NET.Sdk.Razor.SourceGenerators.Tests/Microsoft.NET.Sdk.Razor.SourceGenerators.Test.csproj +++ b/src/Compiler/test/Microsoft.NET.Sdk.Razor.SourceGenerators.Tests/Microsoft.NET.Sdk.Razor.SourceGenerators.Test.csproj @@ -5,7 +5,7 @@ - $(DefaultNetCoreTargetFramework) + $(NetVS) testSdkRSG true diff --git a/src/Razor/benchmarks/Microsoft.AspNetCore.Razor.Microbenchmarks/Microsoft.AspNetCore.Razor.Microbenchmarks.csproj b/src/Razor/benchmarks/Microsoft.AspNetCore.Razor.Microbenchmarks/Microsoft.AspNetCore.Razor.Microbenchmarks.csproj index b9777c887f3..ffa10e222fd 100644 --- a/src/Razor/benchmarks/Microsoft.AspNetCore.Razor.Microbenchmarks/Microsoft.AspNetCore.Razor.Microbenchmarks.csproj +++ b/src/Razor/benchmarks/Microsoft.AspNetCore.Razor.Microbenchmarks/Microsoft.AspNetCore.Razor.Microbenchmarks.csproj @@ -1,7 +1,7 @@  - $(DefaultNetCoreTargetFramework);$(DefaultNetFxTargetFramework) + $(NetVS);$(DefaultNetFxTargetFramework) Exe AnyCPU true diff --git a/src/Razor/benchmarks/testapps/LargeProject/LargeProject.csproj b/src/Razor/benchmarks/testapps/LargeProject/LargeProject.csproj index 168d9204944..ed3a22ebd06 100644 --- a/src/Razor/benchmarks/testapps/LargeProject/LargeProject.csproj +++ b/src/Razor/benchmarks/testapps/LargeProject/LargeProject.csproj @@ -1,7 +1,7 @@  - $(DefaultNetCoreTargetFramework) + $(NetVS) enable enable diff --git a/src/Razor/src/Microsoft.AspNetCore.Razor.ExternalAccess.RoslynWorkspace/Microsoft.AspNetCore.Razor.ExternalAccess.RoslynWorkspace.csproj b/src/Razor/src/Microsoft.AspNetCore.Razor.ExternalAccess.RoslynWorkspace/Microsoft.AspNetCore.Razor.ExternalAccess.RoslynWorkspace.csproj index 2dfd37ad90b..3c789a1dd7f 100644 --- a/src/Razor/src/Microsoft.AspNetCore.Razor.ExternalAccess.RoslynWorkspace/Microsoft.AspNetCore.Razor.ExternalAccess.RoslynWorkspace.csproj +++ b/src/Razor/src/Microsoft.AspNetCore.Razor.ExternalAccess.RoslynWorkspace/Microsoft.AspNetCore.Razor.ExternalAccess.RoslynWorkspace.csproj @@ -1,7 +1,7 @@  - $(DefaultNetCoreTargetFramework) + $(NetVSCode) enable enable diff --git a/src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/Microsoft.AspNetCore.Razor.LanguageServer.csproj b/src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/Microsoft.AspNetCore.Razor.LanguageServer.csproj index f6aa7095e36..d61adfbdde5 100644 --- a/src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/Microsoft.AspNetCore.Razor.LanguageServer.csproj +++ b/src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/Microsoft.AspNetCore.Razor.LanguageServer.csproj @@ -1,7 +1,7 @@  - $(DefaultNetCoreTargetFrameworks);$(DefaultNetFxTargetFramework) + $(NetVSAndVSCode);$(DefaultNetFxTargetFramework) Razor is a markup syntax for adding server-side logic to web pages. This package contains the language server library assets. false false diff --git a/src/Razor/src/Microsoft.AspNetCore.Razor.ProjectEngineHost/Microsoft.AspNetCore.Razor.ProjectEngineHost.csproj b/src/Razor/src/Microsoft.AspNetCore.Razor.ProjectEngineHost/Microsoft.AspNetCore.Razor.ProjectEngineHost.csproj index ff110ab5bd9..c875482252d 100644 --- a/src/Razor/src/Microsoft.AspNetCore.Razor.ProjectEngineHost/Microsoft.AspNetCore.Razor.ProjectEngineHost.csproj +++ b/src/Razor/src/Microsoft.AspNetCore.Razor.ProjectEngineHost/Microsoft.AspNetCore.Razor.ProjectEngineHost.csproj @@ -1,7 +1,7 @@  - $(DefaultNetCoreTargetFrameworks);netstandard2.0;$(DefaultNetFxTargetFramework) + $(NetVSAndVSCode);netstandard2.0;$(DefaultNetFxTargetFramework) Razor is a markup syntax for adding server-side logic to web pages. This package contains common assets that are used in the Razor language server and other assemblies. Microsoft.AspNetCore.Razor false diff --git a/src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/Microsoft.CodeAnalysis.Razor.Workspaces.csproj b/src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/Microsoft.CodeAnalysis.Razor.Workspaces.csproj index d74202c9306..f215cb58367 100644 --- a/src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/Microsoft.CodeAnalysis.Razor.Workspaces.csproj +++ b/src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/Microsoft.CodeAnalysis.Razor.Workspaces.csproj @@ -1,7 +1,7 @@  - $(DefaultNetCoreTargetFrameworks);netstandard2.0;$(DefaultNetFxTargetFramework) + $(NetVSAndVSCode);netstandard2.0;$(DefaultNetFxTargetFramework) Razor is a markup syntax for adding server-side logic to web pages. This package contains the Razor design-time infrastructure. false false diff --git a/src/Razor/src/Microsoft.CodeAnalysis.Remote.Razor.CoreComponents/Microsoft.CodeAnalysis.Remote.Razor.CoreComponents.csproj b/src/Razor/src/Microsoft.CodeAnalysis.Remote.Razor.CoreComponents/Microsoft.CodeAnalysis.Remote.Razor.CoreComponents.csproj index 6422f8cc5b6..709694915b4 100644 --- a/src/Razor/src/Microsoft.CodeAnalysis.Remote.Razor.CoreComponents/Microsoft.CodeAnalysis.Remote.Razor.CoreComponents.csproj +++ b/src/Razor/src/Microsoft.CodeAnalysis.Remote.Razor.CoreComponents/Microsoft.CodeAnalysis.Remote.Razor.CoreComponents.csproj @@ -1,7 +1,7 @@  - $(DefaultNetCoreTargetFramework) + $(NetVS) Exe diff --git a/src/Razor/src/Microsoft.CodeAnalysis.Remote.Razor/Microsoft.CodeAnalysis.Remote.Razor.csproj b/src/Razor/src/Microsoft.CodeAnalysis.Remote.Razor/Microsoft.CodeAnalysis.Remote.Razor.csproj index ab7203bd08e..2e4e17b0400 100644 --- a/src/Razor/src/Microsoft.CodeAnalysis.Remote.Razor/Microsoft.CodeAnalysis.Remote.Razor.csproj +++ b/src/Razor/src/Microsoft.CodeAnalysis.Remote.Razor/Microsoft.CodeAnalysis.Remote.Razor.csproj @@ -1,7 +1,7 @@  - $(DefaultNetCoreTargetFramework);netstandard2.0 + $(NetVS);netstandard2.0 Razor is a markup syntax for adding server-side logic to web pages. This package contains the Razor design-time infrastructure. false false diff --git a/src/Razor/src/Microsoft.VisualStudio.DevKit.Razor/Microsoft.VisualStudio.DevKit.Razor.csproj b/src/Razor/src/Microsoft.VisualStudio.DevKit.Razor/Microsoft.VisualStudio.DevKit.Razor.csproj index 29b5acecb67..fb4eaa37e1f 100644 --- a/src/Razor/src/Microsoft.VisualStudio.DevKit.Razor/Microsoft.VisualStudio.DevKit.Razor.csproj +++ b/src/Razor/src/Microsoft.VisualStudio.DevKit.Razor/Microsoft.VisualStudio.DevKit.Razor.csproj @@ -1,7 +1,7 @@  - $(DefaultNetCoreTargetFramework) + $(NetVSCode) Library Razor is a markup syntax for adding server-side logic to web pages. This package contains the language server assets for C# DevKit. false diff --git a/src/Razor/src/rzls/rzls.csproj b/src/Razor/src/rzls/rzls.csproj index 917ff821743..b36f7f8bdd8 100644 --- a/src/Razor/src/rzls/rzls.csproj +++ b/src/Razor/src/rzls/rzls.csproj @@ -1,7 +1,7 @@  - $(DefaultNetCoreTargetFramework) + $(NetVSCode) Exe Razor is a markup syntax for adding server-side logic to web pages. This package contains a Razor language server. diff --git a/src/Razor/test/Microsoft.AspNetCore.Razor.ExternalAccess.RoslynWorkspace.Test/Microsoft.AspNetCore.Razor.ExternalAccess.RoslynWorkspace.Test.csproj b/src/Razor/test/Microsoft.AspNetCore.Razor.ExternalAccess.RoslynWorkspace.Test/Microsoft.AspNetCore.Razor.ExternalAccess.RoslynWorkspace.Test.csproj index 14814afcfa8..3687d7a5987 100644 --- a/src/Razor/test/Microsoft.AspNetCore.Razor.ExternalAccess.RoslynWorkspace.Test/Microsoft.AspNetCore.Razor.ExternalAccess.RoslynWorkspace.Test.csproj +++ b/src/Razor/test/Microsoft.AspNetCore.Razor.ExternalAccess.RoslynWorkspace.Test/Microsoft.AspNetCore.Razor.ExternalAccess.RoslynWorkspace.Test.csproj @@ -1,7 +1,7 @@  - $(DefaultNetCoreTargetFrameworks) + $(NetVSCode) diff --git a/src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/Microsoft.AspNetCore.Razor.LanguageServer.Test.csproj b/src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/Microsoft.AspNetCore.Razor.LanguageServer.Test.csproj index becbc08f45b..eca4bd97717 100644 --- a/src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/Microsoft.AspNetCore.Razor.LanguageServer.Test.csproj +++ b/src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/Microsoft.AspNetCore.Razor.LanguageServer.Test.csproj @@ -1,7 +1,7 @@  - $(DefaultNetCoreTargetFrameworks);$(DefaultNetFxTargetFramework) + $(NetVSAndVSCode);$(DefaultNetFxTargetFramework) $(DefineConstants);GENERATE_BASELINES diff --git a/src/Razor/test/Microsoft.AspNetCore.Razor.ProjectEngineHost.Test/Microsoft.AspNetCore.Razor.ProjectEngineHost.Test.csproj b/src/Razor/test/Microsoft.AspNetCore.Razor.ProjectEngineHost.Test/Microsoft.AspNetCore.Razor.ProjectEngineHost.Test.csproj index 87511a829e7..e0a2313b254 100644 --- a/src/Razor/test/Microsoft.AspNetCore.Razor.ProjectEngineHost.Test/Microsoft.AspNetCore.Razor.ProjectEngineHost.Test.csproj +++ b/src/Razor/test/Microsoft.AspNetCore.Razor.ProjectEngineHost.Test/Microsoft.AspNetCore.Razor.ProjectEngineHost.Test.csproj @@ -1,7 +1,7 @@  - $(DefaultNetCoreTargetFrameworks);$(DefaultNetFxTargetFramework) + $(NetVSAndVSCode);$(DefaultNetFxTargetFramework) $(DefineConstants);GENERATE_JSON_FILES diff --git a/src/Razor/test/Microsoft.AspNetCore.Razor.Test.Common.Tooling/Microsoft.AspNetCore.Razor.Test.Common.Tooling.csproj b/src/Razor/test/Microsoft.AspNetCore.Razor.Test.Common.Tooling/Microsoft.AspNetCore.Razor.Test.Common.Tooling.csproj index e9f9f637775..075d84c692a 100644 --- a/src/Razor/test/Microsoft.AspNetCore.Razor.Test.Common.Tooling/Microsoft.AspNetCore.Razor.Test.Common.Tooling.csproj +++ b/src/Razor/test/Microsoft.AspNetCore.Razor.Test.Common.Tooling/Microsoft.AspNetCore.Razor.Test.Common.Tooling.csproj @@ -1,7 +1,7 @@  - $(DefaultNetCoreTargetFrameworks);$(DefaultNetFxTargetFramework) + $(NetVSAndVSCode);$(DefaultNetFxTargetFramework) false Microsoft.AspNetCore.Razor.Test.Common diff --git a/src/Shared/Microsoft.AspNetCore.Razor.Test.Common/Microsoft.AspNetCore.Razor.Test.Common.csproj b/src/Shared/Microsoft.AspNetCore.Razor.Test.Common/Microsoft.AspNetCore.Razor.Test.Common.csproj index 83a6f29dc8a..b7d19853dc6 100644 --- a/src/Shared/Microsoft.AspNetCore.Razor.Test.Common/Microsoft.AspNetCore.Razor.Test.Common.csproj +++ b/src/Shared/Microsoft.AspNetCore.Razor.Test.Common/Microsoft.AspNetCore.Razor.Test.Common.csproj @@ -1,7 +1,7 @@  - $(DefaultNetCoreTargetFrameworks);$(DefaultNetFxTargetFramework) + $(NetVSAndVSCode);$(DefaultNetFxTargetFramework) $(DefineConstants);GENERATE_BASELINES diff --git a/src/Shared/Microsoft.AspNetCore.Razor.Utilities.Shared.Test/Microsoft.AspNetCore.Razor.Utilities.Shared.Test.csproj b/src/Shared/Microsoft.AspNetCore.Razor.Utilities.Shared.Test/Microsoft.AspNetCore.Razor.Utilities.Shared.Test.csproj index 1f008203c9b..c633da7451d 100644 --- a/src/Shared/Microsoft.AspNetCore.Razor.Utilities.Shared.Test/Microsoft.AspNetCore.Razor.Utilities.Shared.Test.csproj +++ b/src/Shared/Microsoft.AspNetCore.Razor.Utilities.Shared.Test/Microsoft.AspNetCore.Razor.Utilities.Shared.Test.csproj @@ -1,7 +1,7 @@  - $(DefaultNetCoreTargetFrameworks) + $(NetVSAndVSCode) $(TargetFrameworks);$(DefaultNetFxTargetFramework) True false diff --git a/src/Shared/Microsoft.AspNetCore.Razor.Utilities.Shared/Microsoft.AspNetCore.Razor.Utilities.Shared.csproj b/src/Shared/Microsoft.AspNetCore.Razor.Utilities.Shared/Microsoft.AspNetCore.Razor.Utilities.Shared.csproj index 73431d922b3..d7e652d39f1 100644 --- a/src/Shared/Microsoft.AspNetCore.Razor.Utilities.Shared/Microsoft.AspNetCore.Razor.Utilities.Shared.csproj +++ b/src/Shared/Microsoft.AspNetCore.Razor.Utilities.Shared/Microsoft.AspNetCore.Razor.Utilities.Shared.csproj @@ -1,7 +1,7 @@  - $(DefaultNetCoreTargetFrameworks);$(DefaultNetFxTargetFramework);netstandard2.0 + $(NetVSAndVSCode);$(DefaultNetFxTargetFramework);netstandard2.0 Razor is a markup syntax for adding server-side logic to web pages. This package contains the language server library assets. false false From ea1cec218fb108c57046e734821ece0d6dda8f33 Mon Sep 17 00:00:00 2001 From: Andrew Hall Date: Wed, 5 Mar 2025 18:52:13 -0800 Subject: [PATCH 6/8] Fix some missed locations and add the missed targets file --- Directory.Build.targets | 2 +- .../Utilities/StreamExtensions.NetCore.cs | 2 +- src/Razor/test/Directory.Build.props | 2 +- .../RazorTestResources.cs | 5 +++++ 4 files changed, 8 insertions(+), 3 deletions(-) diff --git a/Directory.Build.targets b/Directory.Build.targets index aad3194fb6b..df13c0d1ca8 100644 --- a/Directory.Build.targets +++ b/Directory.Build.targets @@ -69,7 +69,7 @@ If a C# file should only be compiled under NetCore, it can be named with a ".NetCore.cs" extension. Or, the file can be included in a folder called "NetCore" or has a name that ends in "_NetCore". --> - + diff --git a/src/Razor/src/Microsoft.AspNetCore.Razor.ProjectEngineHost/Utilities/StreamExtensions.NetCore.cs b/src/Razor/src/Microsoft.AspNetCore.Razor.ProjectEngineHost/Utilities/StreamExtensions.NetCore.cs index 81abc7a2a16..6e0897eafcc 100644 --- a/src/Razor/src/Microsoft.AspNetCore.Razor.ProjectEngineHost/Utilities/StreamExtensions.NetCore.cs +++ b/src/Razor/src/Microsoft.AspNetCore.Razor.ProjectEngineHost/Utilities/StreamExtensions.NetCore.cs @@ -103,7 +103,7 @@ public static void WriteSize(this Stream stream, int length) public unsafe static int ReadSize(this Stream stream) { Span bytes = stackalloc byte[4]; - stream.Read(bytes); + stream.ReadExactly(bytes); return BitConverter.ToInt32(bytes); } } diff --git a/src/Razor/test/Directory.Build.props b/src/Razor/test/Directory.Build.props index 0b4ec55df46..f67f09af218 100644 --- a/src/Razor/test/Directory.Build.props +++ b/src/Razor/test/Directory.Build.props @@ -3,7 +3,7 @@ true - $(DefaultNetCoreTargetFrameworks) + $(NetVSAndVSCode) $(DeveloperBuildTestTfms) $(StandardTestTfms) net472;$(StandardTestTfms) diff --git a/src/Razor/test/Microsoft.AspNetCore.Razor.Test.Common.Tooling/RazorTestResources.cs b/src/Razor/test/Microsoft.AspNetCore.Razor.Test.Common.Tooling/RazorTestResources.cs index 48ceb0cdb85..f010154b432 100644 --- a/src/Razor/test/Microsoft.AspNetCore.Razor.Test.Common.Tooling/RazorTestResources.cs +++ b/src/Razor/test/Microsoft.AspNetCore.Razor.Test.Common.Tooling/RazorTestResources.cs @@ -69,7 +69,12 @@ public static byte[] GetResourceBytes(string name, string? folder = null) using var stream = GetResourceStream(name, folder); value = new byte[stream.Length]; + +#if NET + stream.ReadExactly(value); +#else stream.Read(value, 0, value.Length); +#endif s_bytesMap.Add(key, value); From 96f3b7e3be7c9f516076f062fbd49e82ef55a791 Mon Sep 17 00:00:00 2001 From: Andrew Hall Date: Thu, 6 Mar 2025 15:15:41 -0800 Subject: [PATCH 7/8] Rename DefaultNetFxTargetFramework to NetFxVS --- Directory.Build.props | 2 +- Directory.Build.targets | 2 +- .../Razor.Diagnostics.Analyzers.Test.csproj | 2 +- ...tCore.Mvc.Razor.Extensions.Version1_X.Test.csproj | 2 +- ...tCore.Mvc.Razor.Extensions.Version2_X.Test.csproj | 2 +- ...osoft.AspNetCore.Mvc.Razor.Extensions.Test.csproj | 2 +- ...soft.AspNetCore.Razor.Language.Legacy.Test.csproj | 2 +- .../Microsoft.AspNetCore.Razor.Language.Test.csproj | 2 +- .../test/Microsoft.CodeAnalysis.Razor.Test.csproj | 2 +- ...ore.Razor.Test.MvcShim.Version1_X.Compiler.csproj | 2 +- ...ore.Razor.Test.MvcShim.Version2_X.Compiler.csproj | 2 +- ...Microsoft.AspNetCore.Razor.Microbenchmarks.csproj | 2 +- ...pNetCore.Razor.ExternalAccess.LegacyEditor.csproj | 4 ++-- .../Microsoft.AspNetCore.Razor.LanguageServer.csproj | 4 ++-- ...crosoft.AspNetCore.Razor.ProjectEngineHost.csproj | 2 +- .../Microsoft.CodeAnalysis.Razor.Workspaces.csproj | 2 +- ...ualStudio.LanguageServer.ContainedLanguage.csproj | 4 ++-- ...rosoft.VisualStudio.LanguageServices.Razor.csproj | 4 ++-- .../Microsoft.VisualStudio.LegacyEditor.Razor.csproj | 2 +- ...t.VisualStudio.RazorExtension.Dependencies.csproj | 4 ++-- .../Microsoft.VisualStudio.RazorExtension.csproj | 12 ++++++------ src/Razor/src/RazorDeployment/RazorDeployment.csproj | 2 +- ...ore.Razor.ExternalAccess.LegacyEditor.Test.csproj | 2 +- ...osoft.AspNetCore.Razor.LanguageServer.Test.csproj | 2 +- ...ft.AspNetCore.Razor.ProjectEngineHost.Test.csproj | 2 +- ...osoft.AspNetCore.Razor.Test.Common.Tooling.csproj | 10 +++++----- ...udio.LanguageServer.ContainedLanguage.Test.csproj | 2 +- ...t.VisualStudio.LanguageServices.Razor.Test.csproj | 2 +- ...osoft.VisualStudio.LegacyEditor.Razor.Test.csproj | 2 +- ...rosoft.VisualStudio.Razor.IntegrationTests.csproj | 4 ++-- .../Microsoft.AspNetCore.Razor.Test.Common.csproj | 2 +- ...oft.AspNetCore.Razor.Utilities.Shared.Test.csproj | 2 +- ...icrosoft.AspNetCore.Razor.Utilities.Shared.csproj | 2 +- 33 files changed, 48 insertions(+), 48 deletions(-) diff --git a/Directory.Build.props b/Directory.Build.props index 4f5cbd0be63..9d706c9cb2e 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -46,7 +46,7 @@ true - net472 + net472 diff --git a/Directory.Build.targets b/Directory.Build.targets index df13c0d1ca8..f2b3447e92a 100644 --- a/Directory.Build.targets +++ b/Directory.Build.targets @@ -54,7 +54,7 @@ If a C# file should only be compiled under NetFx, it can be named with a ".NetFx.cs" extension. Or, the file can be included in a folder called "NetFx" or has a name that ends in "_NetFx". --> - + diff --git a/src/Analyzers/Razor.Diagnostics.Analyzers.Test/Razor.Diagnostics.Analyzers.Test.csproj b/src/Analyzers/Razor.Diagnostics.Analyzers.Test/Razor.Diagnostics.Analyzers.Test.csproj index b2d80d5d9ca..5ae00361e2b 100644 --- a/src/Analyzers/Razor.Diagnostics.Analyzers.Test/Razor.Diagnostics.Analyzers.Test.csproj +++ b/src/Analyzers/Razor.Diagnostics.Analyzers.Test/Razor.Diagnostics.Analyzers.Test.csproj @@ -2,7 +2,7 @@ $(NetVSAndVSCode) - $(TargetFrameworks);$(DefaultNetFxTargetFramework) + $(TargetFrameworks);$(NetFxVS) false diff --git a/src/Compiler/Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X/test/Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X.Test.csproj b/src/Compiler/Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X/test/Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X.Test.csproj index 1bbd1e93456..9d5b17eca94 100644 --- a/src/Compiler/Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X/test/Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X.Test.csproj +++ b/src/Compiler/Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X/test/Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X.Test.csproj @@ -2,7 +2,7 @@ $(NetVSAndVSCode) - $(TargetFrameworks);$(DefaultNetFxTargetFramework) + $(TargetFrameworks);$(NetFxVS) true $(DefaultItemExcludes);TestFiles\** diff --git a/src/Compiler/Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X/test/Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X.Test.csproj b/src/Compiler/Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X/test/Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X.Test.csproj index cfce6b091fb..d3d867a5776 100644 --- a/src/Compiler/Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X/test/Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X.Test.csproj +++ b/src/Compiler/Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X/test/Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X.Test.csproj @@ -2,7 +2,7 @@ $(NetVSAndVSCode) - $(TargetFrameworks);$(DefaultNetFxTargetFramework) + $(TargetFrameworks);$(NetFxVS) true $(DefaultItemExcludes);TestFiles\** diff --git a/src/Compiler/Microsoft.AspNetCore.Mvc.Razor.Extensions/test/Microsoft.AspNetCore.Mvc.Razor.Extensions.Test.csproj b/src/Compiler/Microsoft.AspNetCore.Mvc.Razor.Extensions/test/Microsoft.AspNetCore.Mvc.Razor.Extensions.Test.csproj index 7f257ca6697..f8e6604e891 100644 --- a/src/Compiler/Microsoft.AspNetCore.Mvc.Razor.Extensions/test/Microsoft.AspNetCore.Mvc.Razor.Extensions.Test.csproj +++ b/src/Compiler/Microsoft.AspNetCore.Mvc.Razor.Extensions/test/Microsoft.AspNetCore.Mvc.Razor.Extensions.Test.csproj @@ -2,7 +2,7 @@ $(NetVSAndVSCode) - $(TargetFrameworks);$(DefaultNetFxTargetFramework) + $(TargetFrameworks);$(NetFxVS) true $(DefaultItemExcludes);TestFiles\** diff --git a/src/Compiler/Microsoft.AspNetCore.Razor.Language/legacyTest/Microsoft.AspNetCore.Razor.Language.Legacy.Test.csproj b/src/Compiler/Microsoft.AspNetCore.Razor.Language/legacyTest/Microsoft.AspNetCore.Razor.Language.Legacy.Test.csproj index 4702f6f8c12..773ebc99695 100644 --- a/src/Compiler/Microsoft.AspNetCore.Razor.Language/legacyTest/Microsoft.AspNetCore.Razor.Language.Legacy.Test.csproj +++ b/src/Compiler/Microsoft.AspNetCore.Razor.Language/legacyTest/Microsoft.AspNetCore.Razor.Language.Legacy.Test.csproj @@ -2,7 +2,7 @@ $(NetVSAndVSCode) - $(TargetFrameworks);$(DefaultNetFxTargetFramework) + $(TargetFrameworks);$(NetFxVS) $(DefaultItemExcludes);TestFiles\**\* diff --git a/src/Compiler/Microsoft.AspNetCore.Razor.Language/test/Microsoft.AspNetCore.Razor.Language.Test.csproj b/src/Compiler/Microsoft.AspNetCore.Razor.Language/test/Microsoft.AspNetCore.Razor.Language.Test.csproj index a2cb8de5fb8..3ea62727ad3 100644 --- a/src/Compiler/Microsoft.AspNetCore.Razor.Language/test/Microsoft.AspNetCore.Razor.Language.Test.csproj +++ b/src/Compiler/Microsoft.AspNetCore.Razor.Language/test/Microsoft.AspNetCore.Razor.Language.Test.csproj @@ -2,7 +2,7 @@ $(NetVSAndVSCode) - $(TargetFrameworks);$(DefaultNetFxTargetFramework) + $(TargetFrameworks);$(NetFxVS) $(DefaultItemExcludes);TestFiles\**\* diff --git a/src/Compiler/Microsoft.CodeAnalysis.Razor/test/Microsoft.CodeAnalysis.Razor.Test.csproj b/src/Compiler/Microsoft.CodeAnalysis.Razor/test/Microsoft.CodeAnalysis.Razor.Test.csproj index 43c247d0a96..b9509d75692 100644 --- a/src/Compiler/Microsoft.CodeAnalysis.Razor/test/Microsoft.CodeAnalysis.Razor.Test.csproj +++ b/src/Compiler/Microsoft.CodeAnalysis.Razor/test/Microsoft.CodeAnalysis.Razor.Test.csproj @@ -2,7 +2,7 @@ $(NetVSAndVSCode) - $(TargetFrameworks);$(DefaultNetFxTargetFramework) + $(TargetFrameworks);$(NetFxVS) $(DefaultItemExcludes);TestFiles\**\* true diff --git a/src/Compiler/test/Microsoft.AspNetCore.Razor.Test.MvcShim.Version1_X/Microsoft.AspNetCore.Razor.Test.MvcShim.Version1_X.Compiler.csproj b/src/Compiler/test/Microsoft.AspNetCore.Razor.Test.MvcShim.Version1_X/Microsoft.AspNetCore.Razor.Test.MvcShim.Version1_X.Compiler.csproj index 480f57774e4..726dabfde34 100644 --- a/src/Compiler/test/Microsoft.AspNetCore.Razor.Test.MvcShim.Version1_X/Microsoft.AspNetCore.Razor.Test.MvcShim.Version1_X.Compiler.csproj +++ b/src/Compiler/test/Microsoft.AspNetCore.Razor.Test.MvcShim.Version1_X/Microsoft.AspNetCore.Razor.Test.MvcShim.Version1_X.Compiler.csproj @@ -1,7 +1,7 @@  - $(NetVSAndVSCode);$(DefaultNetFxTargetFramework) + $(NetVSAndVSCode);$(NetFxVS) true diff --git a/src/Compiler/test/Microsoft.AspNetCore.Razor.Test.MvcShim.Version2_X/Microsoft.AspNetCore.Razor.Test.MvcShim.Version2_X.Compiler.csproj b/src/Compiler/test/Microsoft.AspNetCore.Razor.Test.MvcShim.Version2_X/Microsoft.AspNetCore.Razor.Test.MvcShim.Version2_X.Compiler.csproj index 480f57774e4..726dabfde34 100644 --- a/src/Compiler/test/Microsoft.AspNetCore.Razor.Test.MvcShim.Version2_X/Microsoft.AspNetCore.Razor.Test.MvcShim.Version2_X.Compiler.csproj +++ b/src/Compiler/test/Microsoft.AspNetCore.Razor.Test.MvcShim.Version2_X/Microsoft.AspNetCore.Razor.Test.MvcShim.Version2_X.Compiler.csproj @@ -1,7 +1,7 @@  - $(NetVSAndVSCode);$(DefaultNetFxTargetFramework) + $(NetVSAndVSCode);$(NetFxVS) true diff --git a/src/Razor/benchmarks/Microsoft.AspNetCore.Razor.Microbenchmarks/Microsoft.AspNetCore.Razor.Microbenchmarks.csproj b/src/Razor/benchmarks/Microsoft.AspNetCore.Razor.Microbenchmarks/Microsoft.AspNetCore.Razor.Microbenchmarks.csproj index ffa10e222fd..d5341548c84 100644 --- a/src/Razor/benchmarks/Microsoft.AspNetCore.Razor.Microbenchmarks/Microsoft.AspNetCore.Razor.Microbenchmarks.csproj +++ b/src/Razor/benchmarks/Microsoft.AspNetCore.Razor.Microbenchmarks/Microsoft.AspNetCore.Razor.Microbenchmarks.csproj @@ -1,7 +1,7 @@  - $(NetVS);$(DefaultNetFxTargetFramework) + $(NetVS);$(NetFxVS) Exe AnyCPU true diff --git a/src/Razor/src/Microsoft.AspNetCore.Razor.ExternalAccess.LegacyEditor/Microsoft.AspNetCore.Razor.ExternalAccess.LegacyEditor.csproj b/src/Razor/src/Microsoft.AspNetCore.Razor.ExternalAccess.LegacyEditor/Microsoft.AspNetCore.Razor.ExternalAccess.LegacyEditor.csproj index ac43fb99fcb..a610f847609 100644 --- a/src/Razor/src/Microsoft.AspNetCore.Razor.ExternalAccess.LegacyEditor/Microsoft.AspNetCore.Razor.ExternalAccess.LegacyEditor.csproj +++ b/src/Razor/src/Microsoft.AspNetCore.Razor.ExternalAccess.LegacyEditor/Microsoft.AspNetCore.Razor.ExternalAccess.LegacyEditor.csproj @@ -1,7 +1,7 @@  - $(DefaultNetFxTargetFramework) + $(NetFxVS) enable enable true @@ -12,7 +12,7 @@ - + diff --git a/src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/Microsoft.AspNetCore.Razor.LanguageServer.csproj b/src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/Microsoft.AspNetCore.Razor.LanguageServer.csproj index d61adfbdde5..48fa67bf964 100644 --- a/src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/Microsoft.AspNetCore.Razor.LanguageServer.csproj +++ b/src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/Microsoft.AspNetCore.Razor.LanguageServer.csproj @@ -1,7 +1,7 @@  - $(NetVSAndVSCode);$(DefaultNetFxTargetFramework) + $(NetVSAndVSCode);$(NetFxVS) Razor is a markup syntax for adding server-side logic to web pages. This package contains the language server library assets. false false @@ -25,7 +25,7 @@ - + - + diff --git a/src/Razor/src/Microsoft.VisualStudio.LanguageServices.Razor/Microsoft.VisualStudio.LanguageServices.Razor.csproj b/src/Razor/src/Microsoft.VisualStudio.LanguageServices.Razor/Microsoft.VisualStudio.LanguageServices.Razor.csproj index ac250cee175..2fd3b3b3c69 100644 --- a/src/Razor/src/Microsoft.VisualStudio.LanguageServices.Razor/Microsoft.VisualStudio.LanguageServices.Razor.csproj +++ b/src/Razor/src/Microsoft.VisualStudio.LanguageServices.Razor/Microsoft.VisualStudio.LanguageServices.Razor.csproj @@ -1,7 +1,7 @@  - $(DefaultNetFxTargetFramework) + $(NetFxVS) Razor is a markup syntax for adding server-side logic to web pages. This package contains the Razor design-time infrastructure for Visual Studio. false $(PkgMicrosoft_NET_Sdk_Razor)\build\netstandard2.0\Rules\ @@ -30,7 +30,7 @@ - + - $(DefaultNetFxTargetFramework) + $(NetFxVS) RoslynDev @@ -43,7 +43,7 @@ - + diff --git a/src/Razor/src/Microsoft.VisualStudio.RazorExtension/Microsoft.VisualStudio.RazorExtension.csproj b/src/Razor/src/Microsoft.VisualStudio.RazorExtension/Microsoft.VisualStudio.RazorExtension.csproj index 810b344b3e0..1b4a46e16d8 100644 --- a/src/Razor/src/Microsoft.VisualStudio.RazorExtension/Microsoft.VisualStudio.RazorExtension.csproj +++ b/src/Razor/src/Microsoft.VisualStudio.RazorExtension/Microsoft.VisualStudio.RazorExtension.csproj @@ -1,6 +1,6 @@  - $(DefaultNetFxTargetFramework) + $(NetFxVS) RoslynDev @@ -164,20 +164,20 @@ - TargetFramework=$(DefaultNetFxTargetFramework) + TargetFramework=$(NetFxVS) - TargetFramework=$(DefaultNetFxTargetFramework) + TargetFramework=$(NetFxVS) - TargetFramework=$(DefaultNetFxTargetFramework) + TargetFramework=$(NetFxVS) - TargetFramework=$(DefaultNetFxTargetFramework) + TargetFramework=$(NetFxVS) @@ -208,7 +208,7 @@ - + - $(DefaultNetFxTargetFramework) + $(NetFxVS) RoslynDev diff --git a/src/Razor/test/Microsoft.AspNetCore.Razor.ExternalAccess.LegacyEditor.Test/Microsoft.AspNetCore.Razor.ExternalAccess.LegacyEditor.Test.csproj b/src/Razor/test/Microsoft.AspNetCore.Razor.ExternalAccess.LegacyEditor.Test/Microsoft.AspNetCore.Razor.ExternalAccess.LegacyEditor.Test.csproj index d7e7c685f78..db8e4cd6c04 100644 --- a/src/Razor/test/Microsoft.AspNetCore.Razor.ExternalAccess.LegacyEditor.Test/Microsoft.AspNetCore.Razor.ExternalAccess.LegacyEditor.Test.csproj +++ b/src/Razor/test/Microsoft.AspNetCore.Razor.ExternalAccess.LegacyEditor.Test/Microsoft.AspNetCore.Razor.ExternalAccess.LegacyEditor.Test.csproj @@ -1,7 +1,7 @@  - $(DefaultNetFxTargetFramework) + $(NetFxVS) diff --git a/src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/Microsoft.AspNetCore.Razor.LanguageServer.Test.csproj b/src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/Microsoft.AspNetCore.Razor.LanguageServer.Test.csproj index eca4bd97717..1a77b7246fb 100644 --- a/src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/Microsoft.AspNetCore.Razor.LanguageServer.Test.csproj +++ b/src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/Microsoft.AspNetCore.Razor.LanguageServer.Test.csproj @@ -1,7 +1,7 @@  - $(NetVSAndVSCode);$(DefaultNetFxTargetFramework) + $(NetVSAndVSCode);$(NetFxVS) $(DefineConstants);GENERATE_BASELINES diff --git a/src/Razor/test/Microsoft.AspNetCore.Razor.ProjectEngineHost.Test/Microsoft.AspNetCore.Razor.ProjectEngineHost.Test.csproj b/src/Razor/test/Microsoft.AspNetCore.Razor.ProjectEngineHost.Test/Microsoft.AspNetCore.Razor.ProjectEngineHost.Test.csproj index e0a2313b254..593c8ee8041 100644 --- a/src/Razor/test/Microsoft.AspNetCore.Razor.ProjectEngineHost.Test/Microsoft.AspNetCore.Razor.ProjectEngineHost.Test.csproj +++ b/src/Razor/test/Microsoft.AspNetCore.Razor.ProjectEngineHost.Test/Microsoft.AspNetCore.Razor.ProjectEngineHost.Test.csproj @@ -1,7 +1,7 @@  - $(NetVSAndVSCode);$(DefaultNetFxTargetFramework) + $(NetVSAndVSCode);$(NetFxVS) $(DefineConstants);GENERATE_JSON_FILES diff --git a/src/Razor/test/Microsoft.AspNetCore.Razor.Test.Common.Tooling/Microsoft.AspNetCore.Razor.Test.Common.Tooling.csproj b/src/Razor/test/Microsoft.AspNetCore.Razor.Test.Common.Tooling/Microsoft.AspNetCore.Razor.Test.Common.Tooling.csproj index 075d84c692a..f8ed32bdeb1 100644 --- a/src/Razor/test/Microsoft.AspNetCore.Razor.Test.Common.Tooling/Microsoft.AspNetCore.Razor.Test.Common.Tooling.csproj +++ b/src/Razor/test/Microsoft.AspNetCore.Razor.Test.Common.Tooling/Microsoft.AspNetCore.Razor.Test.Common.Tooling.csproj @@ -1,7 +1,7 @@  - $(NetVSAndVSCode);$(DefaultNetFxTargetFramework) + $(NetVSAndVSCode);$(NetFxVS) false Microsoft.AspNetCore.Razor.Test.Common @@ -11,7 +11,7 @@ - $(DefineConstants);JSONSERIALIZATION_PROJECTSYSTEM + $(DefineConstants);JSONSERIALIZATION_PROJECTSYSTEM @@ -29,7 +29,7 @@ - + @@ -65,7 +65,7 @@ - + @@ -87,6 +87,6 @@ - + diff --git a/src/Razor/test/Microsoft.VisualStudio.LanguageServer.ContainedLanguage.Test/Microsoft.VisualStudio.LanguageServer.ContainedLanguage.Test.csproj b/src/Razor/test/Microsoft.VisualStudio.LanguageServer.ContainedLanguage.Test/Microsoft.VisualStudio.LanguageServer.ContainedLanguage.Test.csproj index 3c89a6a9ed9..3c2a5347481 100644 --- a/src/Razor/test/Microsoft.VisualStudio.LanguageServer.ContainedLanguage.Test/Microsoft.VisualStudio.LanguageServer.ContainedLanguage.Test.csproj +++ b/src/Razor/test/Microsoft.VisualStudio.LanguageServer.ContainedLanguage.Test/Microsoft.VisualStudio.LanguageServer.ContainedLanguage.Test.csproj @@ -1,7 +1,7 @@  - $(DefaultNetFxTargetFramework) + $(NetFxVS) diff --git a/src/Razor/test/Microsoft.VisualStudio.LanguageServices.Razor.Test/Microsoft.VisualStudio.LanguageServices.Razor.Test.csproj b/src/Razor/test/Microsoft.VisualStudio.LanguageServices.Razor.Test/Microsoft.VisualStudio.LanguageServices.Razor.Test.csproj index fd54e585914..ca641dc30fa 100644 --- a/src/Razor/test/Microsoft.VisualStudio.LanguageServices.Razor.Test/Microsoft.VisualStudio.LanguageServices.Razor.Test.csproj +++ b/src/Razor/test/Microsoft.VisualStudio.LanguageServices.Razor.Test/Microsoft.VisualStudio.LanguageServices.Razor.Test.csproj @@ -1,7 +1,7 @@  - $(DefaultNetFxTargetFramework) + $(NetFxVS) true diff --git a/src/Razor/test/Microsoft.VisualStudio.LegacyEditor.Razor.Test/Microsoft.VisualStudio.LegacyEditor.Razor.Test.csproj b/src/Razor/test/Microsoft.VisualStudio.LegacyEditor.Razor.Test/Microsoft.VisualStudio.LegacyEditor.Razor.Test.csproj index 5280ced71d1..3127d897c99 100644 --- a/src/Razor/test/Microsoft.VisualStudio.LegacyEditor.Razor.Test/Microsoft.VisualStudio.LegacyEditor.Razor.Test.csproj +++ b/src/Razor/test/Microsoft.VisualStudio.LegacyEditor.Razor.Test/Microsoft.VisualStudio.LegacyEditor.Razor.Test.csproj @@ -1,7 +1,7 @@  - $(DefaultNetFxTargetFramework) + $(NetFxVS) true Microsoft.VisualStudio.LegacyEditor.Razor diff --git a/src/Razor/test/Microsoft.VisualStudio.Razor.IntegrationTests/Microsoft.VisualStudio.Razor.IntegrationTests.csproj b/src/Razor/test/Microsoft.VisualStudio.Razor.IntegrationTests/Microsoft.VisualStudio.Razor.IntegrationTests.csproj index a86f4cba7b0..a8cc354b824 100644 --- a/src/Razor/test/Microsoft.VisualStudio.Razor.IntegrationTests/Microsoft.VisualStudio.Razor.IntegrationTests.csproj +++ b/src/Razor/test/Microsoft.VisualStudio.Razor.IntegrationTests/Microsoft.VisualStudio.Razor.IntegrationTests.csproj @@ -1,6 +1,6 @@  - $(DefaultNetFxTargetFramework) + $(NetFxVS) enable Library Microsoft.VisualStudio.Razor.IntegrationTests @@ -41,7 +41,7 @@ - + diff --git a/src/Shared/Microsoft.AspNetCore.Razor.Test.Common/Microsoft.AspNetCore.Razor.Test.Common.csproj b/src/Shared/Microsoft.AspNetCore.Razor.Test.Common/Microsoft.AspNetCore.Razor.Test.Common.csproj index b7d19853dc6..68caa198787 100644 --- a/src/Shared/Microsoft.AspNetCore.Razor.Test.Common/Microsoft.AspNetCore.Razor.Test.Common.csproj +++ b/src/Shared/Microsoft.AspNetCore.Razor.Test.Common/Microsoft.AspNetCore.Razor.Test.Common.csproj @@ -1,7 +1,7 @@  - $(NetVSAndVSCode);$(DefaultNetFxTargetFramework) + $(NetVSAndVSCode);$(NetFxVS) $(DefineConstants);GENERATE_BASELINES diff --git a/src/Shared/Microsoft.AspNetCore.Razor.Utilities.Shared.Test/Microsoft.AspNetCore.Razor.Utilities.Shared.Test.csproj b/src/Shared/Microsoft.AspNetCore.Razor.Utilities.Shared.Test/Microsoft.AspNetCore.Razor.Utilities.Shared.Test.csproj index c633da7451d..f08cb047c73 100644 --- a/src/Shared/Microsoft.AspNetCore.Razor.Utilities.Shared.Test/Microsoft.AspNetCore.Razor.Utilities.Shared.Test.csproj +++ b/src/Shared/Microsoft.AspNetCore.Razor.Utilities.Shared.Test/Microsoft.AspNetCore.Razor.Utilities.Shared.Test.csproj @@ -2,7 +2,7 @@ $(NetVSAndVSCode) - $(TargetFrameworks);$(DefaultNetFxTargetFramework) + $(TargetFrameworks);$(NetFxVS) True false diff --git a/src/Shared/Microsoft.AspNetCore.Razor.Utilities.Shared/Microsoft.AspNetCore.Razor.Utilities.Shared.csproj b/src/Shared/Microsoft.AspNetCore.Razor.Utilities.Shared/Microsoft.AspNetCore.Razor.Utilities.Shared.csproj index d7e652d39f1..774a214dbc8 100644 --- a/src/Shared/Microsoft.AspNetCore.Razor.Utilities.Shared/Microsoft.AspNetCore.Razor.Utilities.Shared.csproj +++ b/src/Shared/Microsoft.AspNetCore.Razor.Utilities.Shared/Microsoft.AspNetCore.Razor.Utilities.Shared.csproj @@ -1,7 +1,7 @@  - $(NetVSAndVSCode);$(DefaultNetFxTargetFramework);netstandard2.0 + $(NetVSAndVSCode);$(NetFxVS);netstandard2.0 Razor is a markup syntax for adding server-side logic to web pages. This package contains the language server library assets. false false From 072381f3ac4ec88652e1e670645fea24f132db39 Mon Sep 17 00:00:00 2001 From: Andrew Hall Date: Thu, 6 Mar 2025 15:32:44 -0800 Subject: [PATCH 8/8] Make editing values easier to find --- Directory.Build.props | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/Directory.Build.props b/Directory.Build.props index 9d706c9cb2e..f4b69f8ffd5 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -47,6 +47,9 @@ true net472 + net8.0 + net9.0 + $(NetVS);$(NetVSCode) @@ -80,17 +83,6 @@ $(NetVS);$(NetVSCode) - - - - - net8.0 - net9.0 - $(NetVS);$(NetVSCode) - -