Further .NET 9.0 SDK updates (#2266)

* Use 9.0 on integration test CI stage
* fix some additional diagnostics that have appeared recently
* Update AsyncRx.NET to .NET 9.0 SDK
* Fix bizarre errors about HttpResponse causing Ix build to fail

Author: idg10

.editorconfig

@@ -258,4 +258,10 @@ csharp_space_between_square_brackets = false
 dotnet_diagnostic.IDE0290.severity = none
 
 # Namespace style.
-csharp_style_namespace_declarations = block_scoped
+csharp_style_namespace_declarations = block_scoped
+dotnet_diagnostic.IDE0290.severity = none
+
+# Target-typed new expressions
+# We will probably adopt these at some point, but for some reason the IDE only just started complaining about them,
+# and I don't want to deal with all these while in the middle of the Slight Deunification.
+dotnet_diagnostic.IDE0090.severity = none

Ix.NET/Source/System.Interactive.Async.Tests/System/Linq/AsyncEnumerableExTests.cs

@@ -63,7 +63,7 @@ protected async Task SequenceIdentity<T>(IAsyncEnumerable<T> enumerable)
             var res1 = await enumerable.ToListAsync();
             var res2 = await enumerable.ToListAsync();
 
-            res1.Should().BeEquivalentTo(res2);
+            Assert.Equivalent(res1, res2, strict: true);
         }
     }
 }

Ix.NET/Source/System.Linq.Async.Tests/System/Linq/AsyncEnumerableTests.cs

@@ -62,7 +62,7 @@ protected async Task SequenceIdentity<T>(IAsyncEnumerable<T> enumerable)
             var res1 = await enumerable.ToListAsync();
             var res2 = await enumerable.ToListAsync();
 
-            res1.Should().BeEquivalentTo(res2);
+            Assert.Equivalent(res1, res2, strict: true);
         }
 
         protected static IAsyncEnumerable<TValue> Throw<TValue>(Exception exception)

Rx.NET/Source/CodeCoverage.runsettings

@@ -5,7 +5,8 @@
     Workaround for failure to run tests on .NET FX on v3.3.1 MSTest packages
   -->
   <RunConfiguration>  
-    <DisableAppDomain>True</DisableAppDomain>   
+    <DisableAppDomain>True</DisableAppDomain>
+    <ExecutionThreadApartmentState>STA</ExecutionThreadApartmentState>
   </RunConfiguration>
 
   <DataCollectionRunSettings>

Rx.NET/Source/Directory.build.props

@@ -32,11 +32,6 @@
   <ItemGroup>
     <PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="All"/>
 
-    <!--
-    Nerdbank.GitVersioning 3.6.128 injects a reference to a .proj file that doesn't work inside the
-    UWP test runner project. We don't ship that as a NuGet package, so it doesn't matter what its
-    version number is.
-    -->
     <PackageReference
       Include="Nerdbank.GitVersioning"
       Version="3.8.118"
@@ -119,9 +114,10 @@
               [.. x]. To me, this is less readable, and it doesn't improve performance, as far as we know.
 
     CA1510 - use ArgumentNullException.ThrowIf (not available on all targets)
+    CA1512 - use ArgumentOutOfRangeException.ThrowIfXxx (not available on all targets)
     CA1513 - use ObjectDisposedException.ThrowIf (not available on all targets)
     -->
-    <NoWarn>$(NoWarn);CA1001;CA2213;CA1510;CA1513;IDE0028;IDE0056;IDE0057;IDE0130;IDE0290;IDE0305;IDE0306</NoWarn>
+    <NoWarn>$(NoWarn);CA1001;CA2213;CA1510;CA1512;CA1513;IDE0028;IDE0056;IDE0057;IDE0130;IDE0290;IDE0305;IDE0306</NoWarn>
   </PropertyGroup>
 
   <ItemGroup>

Rx.NET/Source/Directory.build.targets

@@ -5,7 +5,7 @@
   <PropertyGroup>  
     <Product>$(AssemblyName) ($(TargetFramework))</Product>
   </PropertyGroup>
-    
+
   <PropertyGroup Condition="'$(TargetFramework)' == 'net472'">
     <DefineConstants>$(DefineConstants);HAS_WINFORMS;HAS_WPF;HAS_WINRT;HAS_DISPATCHER;HAS_REMOTING;DESKTOPCLR;NO_NULLABLE_ATTRIBUTES</DefineConstants>
   </PropertyGroup>

Rx.NET/Source/benchmarks/Benchmarks.System.Reactive/Program.cs

@@ -6,6 +6,10 @@
 using System.Reactive.Linq;
 using BenchmarkDotNet.Running;
 
+using Microsoft.VisualStudio.TestTools.UnitTesting;
+
+[assembly:DoNotParallelize] // Not really a test project, but the build tools think we are, and complain if we don't state our parallelization policy.
+
 namespace Benchmarks.System.Reactive
 {
     internal class Program

Rx.NET/Source/tests/Tests.System.Reactive.Uwp.DeviceRunner/Tests.System.Reactive.Uwp.DeviceRunner.csproj

@@ -147,6 +147,18 @@
     </PackageReference>
     <PackageReference Include="xunit.assert" Version="2.8.0" />
   </ItemGroup>
+  <ItemGroup>
+    <!--
+    Nerdbank.GitVersioning 3.6.128 injects a reference to a .proj file that doesn't work inside the
+    UWP test runner project. We don't ship that as a NuGet package, so it doesn't matter what its
+    version number is.
+    However, this doesn't seem to work. And excluding this project in the Directory.Build.props file
+    where we add this reference in the first place also doesn't work. I think this is coming in
+    transitively. So we need to work out exactly how .nuget\packages\nerdbank.gitversioning\3.6.143\build\PrivateP2PCaching.proj
+    is getting included, and work out how to stop that.
+    -->
+    <PackageReference Remove="Nerdbank.GitVersioning" />
+  </ItemGroup>
   <ItemGroup>
     <ApplicationDefinition Include="App.xaml">
       <Generator>MSBuild:Compile</Generator>

Rx.NET/Source/tests/Tests.System.Reactive/TestConfiguration.cs

@@ -0,0 +1,7 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT License.
+// See the LICENSE file in the project root for more information. 
+
+using Microsoft.VisualStudio.TestTools.UnitTesting;
+
+[assembly:Parallelize]

Rx.NET/Source/tests/Tests.System.Reactive/Tests.System.Reactive.csproj

@@ -41,4 +41,11 @@
     <ProjectReference Include="..\..\src\Microsoft.Reactive.Testing\Microsoft.Reactive.Testing.csproj" />
   </ItemGroup>
 
+  <ItemGroup>
+    <PackageReference Update="coverlet.collector" Version="6.0.2">
+      <PrivateAssets>all</PrivateAssets>
+      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+    </PackageReference>
+  </ItemGroup>
+
 </Project>