Skip to content

CA1041 performance #6143

Open
Open
@Youssef1313

Description

Seeing the following in a binlog:

image

Looks like this is a very simple analyzer, but is somewhat slow. The analyzer registers symbol actions for named types, methods, fields, properties, and events.

So I assume this is alone too much work.

The analyzer should use IAttributeOperation when it's added back (but the analyzer will not work for people consuming a compiler without this IOp), or register a syntax action for AttributeSyntax.

Yes we try to avoid syntax analysis in many cases, but I think for this one we might see a good performance gain.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugThe product is not behaving according to its current intended designPerformanceIndicates a performance problemhelp wantedThe issue is up-for-grabs, and can be claimed by commenting

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions