React to breaking api change #7589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
approved these changes
Feb 27, 2025
JoeRobich
approved these changes
Feb 27, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7589 +/- ##
=======================================
Coverage 96.54% 96.54%
=======================================
Files 1457 1457
Lines 352893 352893
Branches 11487 11486 -1
=======================================
+ Hits 340704 340712 +8
+ Misses 9270 9263 -7
+ Partials 2919 2918 -1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7588
The issue here is that we remove the implicit conversions that allowed
SyntaxList<SyntaxNode>to convert to something likeSyntaxList<ArgumentSyntax>. Updating the code to just make a strongly typed list in the first place now.