From 5f1603dd814e545ffc256491a372ac44e1dec583 Mon Sep 17 00:00:00 2001 From: Victor Z Date: Mon, 27 Nov 2017 23:00:15 +0300 Subject: [PATCH] Updated documentation comments. --- .../CSharpQualifyMemberAccessDiagnosticAnalyzer.cs | 4 +++- .../VisualBasicQualifyMemberAccessDiagnosticAnalyzer.vb | 3 ++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/Features/CSharp/Portable/QualifyMemberAccess/CSharpQualifyMemberAccessDiagnosticAnalyzer.cs b/src/Features/CSharp/Portable/QualifyMemberAccess/CSharpQualifyMemberAccessDiagnosticAnalyzer.cs index 5febbd2c5c1e5..8172276d2cc7b 100644 --- a/src/Features/CSharp/Portable/QualifyMemberAccess/CSharpQualifyMemberAccessDiagnosticAnalyzer.cs +++ b/src/Features/CSharp/Portable/QualifyMemberAccess/CSharpQualifyMemberAccessDiagnosticAnalyzer.cs @@ -16,7 +16,9 @@ protected override string GetLanguageName() protected override bool IsAlreadyQualifiedMemberAccess(SyntaxNode node) => node.IsKind(SyntaxKind.ThisExpression); - // If the member is already qualified with `base.`, it cannot be further qualified. + // If the member is already qualified with `base.`, + // or member is in object initialization context, + // or member in property or field initialization, it cannot be qualified. protected override bool CanMemberAccessBeQualified(ISymbol containingSymbol, SyntaxNode node) => !(node.IsKind(SyntaxKind.BaseExpression) || node.Parent.Parent.IsKind(SyntaxKind.ObjectInitializerExpression) || diff --git a/src/Features/VisualBasic/Portable/Diagnostics/Analyzers/VisualBasicQualifyMemberAccessDiagnosticAnalyzer.vb b/src/Features/VisualBasic/Portable/Diagnostics/Analyzers/VisualBasicQualifyMemberAccessDiagnosticAnalyzer.vb index 2b07c7c55827e..e6aaea65ff37e 100644 --- a/src/Features/VisualBasic/Portable/Diagnostics/Analyzers/VisualBasicQualifyMemberAccessDiagnosticAnalyzer.vb +++ b/src/Features/VisualBasic/Portable/Diagnostics/Analyzers/VisualBasicQualifyMemberAccessDiagnosticAnalyzer.vb @@ -17,7 +17,8 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.QualifyMemberAccess End Function Protected Overrides Function CanMemberAccessBeQualified(containingSymbol As ISymbol, node As SyntaxNode) As Boolean - ' If the member is already qualified with `MyBase.`, or `MyClass.`, it cannot be further qualified. + ' If the member is already qualified with `MyBase.`, or `MyClass.`, + ' or member is in object initialization context, it cannot be qualified. Return Not (node.IsKind(SyntaxKind.MyBaseExpression) OrElse node.IsKind(SyntaxKind.MyClassExpression) OrElse node.IsKind(SyntaxKind.ObjectCreationExpression)) End Function End Class