Quick fix for ! nullable operator

[clairernovotny]

.NET Core 3 Preview 2

I think it'd help a lot of if Roslyn quick-fix offered to suggest the ! post-fix operator in addition to the pragmas. It would help discoverability of this new language feature and might even be the default?

Today, it offers the pragmas:

This is cleaner:

[jasonmalinowski]

@mavasani Adding the "proper" fix is easy enough -- is there a way to mark the fix as "better" than the suppression (since it's literally a suppression itself!) and not suggest the other stuff?

[mavasani]

@jasonmalinowski Yes, that should be possible by either tweaking PragmWarningCodeAction to special case these diagnostics OR changing the logic here to register a different code action instead of PragmaWarningCodeAction for these diagnostics (IMO, the latter is a better approach).

[jasonmalinowski]

@mavasani But in either case we have to tinker in some core code to add an exception versus some nicer way of saying it? It just feels hacky but I get it.

[mavasani]

some nicer way of saying it?

I don't know of any other way based on the current suppression fixer code.