Poor error recovery when declaring a pointer to an array type

[YairHalberstadt]

Version Used: master

Steps to Reproduce:

using System.Collections.Generic;

class C
{
    unsafe void M1()
    {
        int[] *y;
        List<int> *z;
    }
}

https://sharplab.io/#v2:EYLgtghgzgLgpgJwDQxASwDYB8ACAGAAhwEYAWAbgFgAoGnAJgIGEaBvGgzggVwDsoIAMzhFSBALLEAFAEoOXdtS7KCaXjADaAXQIAqAJ5UlKzgBk0sADxqYAPj0AvI8oC+NF0A=

Expected Behavior:

Following errors are produced:

error CS0208: Cannot take the address of, get the size of, or declare a pointer to a managed type ('int[]')

error CS0208: Cannot take the address of, get the size of, or declare a pointer to a managed type ('List')

Actual Behavior:

Following errors are produced:

error CS1001: Identifier expected
error CS1002: ; expected
error CS0103: The name 'y' does not exist in the current context
error CS0201: Only assignment, call, increment, decrement, await, and new object expressions can be used as a statement
error CS0208: Cannot take the address of, get the size of, or declare a pointer to a managed type ('List')

[YairHalberstadt]

@gafter
In this commit you explicitly exclude parsing an array type as a pointer:
0bee025

On this line:
0bee025#diff-ac2b4121f27df06f497115cc68277654R6236

case SyntaxKind.AsteriskToken when type.Kind != SyntaxKind.ArrayType:

Yet all the unit tests pass when you remove this check. Is there any reason for it?

[CyrusNajmabadi]

You have to be careful in the case where the * might actually be needed for an arithmetic expression. So, if you changed this, you'd need to do a lot of analysis and test verification to ensure that in other places where ScanType is called, this didn't end up regressing something.