[DRAFT] Rename - add conflicting member name message #81658
Conversation
| /// Checks if the proposed replacement text conflicts with an existing declaration. | ||
| /// Returns true if there is a conflict, along with an error message. | ||
| /// </summary> | ||
| bool CheckDeclarationConflict(string replacementText, [NotNullWhen(true)] out string? message); |
There was a problem hiding this comment.
- why not just have this return a
string?as the result type? - why do we need a special entrypoint here? Specifically, it's unclear how this differs from information in IInlineRenameLocationSet. like IInlineRenameLocationSet.IInlineRenameReplacementInfo, and whatnot.
Do we not already ahve mechanisms to report conflicts? Why a special new one?
|
Needs some tests... |
|
/pr-val |
|
Failed to trigger the pipeline. Please check the workflow logs for details. |
|
/pr-val |
|
Failed to trigger the pipeline. Please check the workflow logs for details. |
|
/pr-val |
|
Failed to trigger the pipeline. Please check the workflow logs for details. |
|
/pr-val |
|
Pipeline triggered by @akhera99 Parameters:
|
|
/dart |
|
Pipeline triggered by @akhera99 Parameters:
|
|
/pr-val |
|
You do not have permission to trigger this workflow without specifying a commit hash. Please use the format |
|
Failed to trigger the pipeline. Please check the workflow logs for details. |
|
/pr-val |
|
You do not have permission to trigger this workflow. Only Microsoft employees who are contributors to the roslyn repository can run pipelines. |
|
Failed to trigger the pipeline. Please check the workflow logs for details. |
|
/pr-val 520b5ce |
|
You do not have permission to trigger this workflow. Only Microsoft employees who are contributors to the roslyn repository can run pipelines. |
|
Failed to trigger the pipeline. Please check the workflow logs for details. |
|
/pr-val 520b5ce |
|
Pipeline triggered by @akhera99 Parameters:
|
|
/pr-val |
|
You do not have permission to trigger this workflow. Only Microsoft employees who are contributors to the roslyn repository can run pipelines. |
|
Failed to trigger the pipeline. Please check the workflow logs for details. |
|
/pr-val |
|
Pipeline triggered by @ToddGrun Parameters:
|
|
/pr-val |
|
Failed to trigger the pipeline. Please check the workflow logs for details. |
|
/pr-val |
|
Pipeline triggered by @akhera99 Parameters:
|
4 participants
Draft to test workflow. (created with github copilot CLI)