Merge 'main' into Unions #81909
Merged
Merge 'main' into Unions #81909
+33,381
−6,123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otnet#81606) Error CS9293 was too generic when extension parameters were referenced from static members, giving "Cannot use extension parameter in this context" without explaining the static/instance mismatch. **Before**: "Cannot use extension parameter 'object o' in this context." **After**: "Static members cannot refer to extension parameter 'o'. Use an instance member instead." --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: Fred Silberberg <[email protected]>
[main] Update dependencies from dotnet/arcade
Closes dotnet#67153. The assert was uncommented already in the original fix (dotnet#67157), but then it got commented again via automatic code flow (dotnet#67507).
Migrates https://github.com/microsoft/vs-extension-testing into Roslyn. Reduces infrastructure pain for a repo we own that is majorly used just by Roslyn / Razor. This does not enable CI to run integration tests on dev18, will tackle that in a followup. However I did verify that at least some of the tests pass on dev18 with this locally. Support for testing VS versions below dev18 has also been removed. Older versions of the packages can be used if testing old VS versions is required. Should be reviewed starting at 6220e53 Everything else is the history from vs-extension-testing.
Part of dotnet/razor#8541 Needed so we can rename the .razor file when the user renames the component type name from a C# file.
Make and use a builder for DeclarationTable edits to reduce allocations from creating intermediary DeclarationTable and repeated modifications to an underlying ImmutableDictionary. Insertion PR: https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/695154 PIT results: <img width="1426" height="180" alt="image" src="https://github.com/user-attachments/assets/1e1618f4-e014-4cc9-b38a-5e025b64d75f" /> Allocations in VS under SyntaxAndDeclarationManager.CreateState from ScrollingAndTyping test, Typing scenario: *** Before *** <img width="1279" height="465" alt="image" src="https://github.com/user-attachments/assets/f69039fd-725a-4334-bd77-0192103f4e19" /> *** After *** <img width="1292" height="482" alt="image" src="https://github.com/user-attachments/assets/1d877d76-b6c1-4d57-95a1-a70999e9cd43" />
This reverts commit 3482fc7.
This reverts commit 3482fc7. Caused image load regression https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/695919
Fixes microsoft/vscode-dotnettools#2629 I could not get a test working for this, I don't fully understand all of the machinery here. The Razor file was always coming back as a misc file even after being added to a real project?
…ith values for constants of other types. (dotnet#81794) Fixes dotnet#81784
- Implicit capabilities are already added by watch: dotnet/sdk#52069 - dotnet#36061 no longer repros - the diagnostics are deduplicated if necessary. Avoid reporting hidden and info diagnostics to reduce log noise.
A couple were missing part of the URL. In addition, draft-v9 will soon be the default branch, and a couple clauses moved.
…plicit on the pipeline that started (dotnet#81905)
Before: <img width="571" height="228" alt="image" src="https://github.com/user-attachments/assets/f6d8e12d-3a75-4dcd-b959-1c07b1fa74fa" /> After: <img width="571" height="228" alt="image" src="https://github.com/user-attachments/assets/51bf7c5f-cdb2-4fcb-8ece-3fa148667437" />
Contributor
Author
|
@dotnet/roslyn-compiler Need a sign-off on a merge PR |
333fred
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trivial merges only.