From 4ba9ecaabd4d5c87c776a030eafdac0bae0512cf Mon Sep 17 00:00:00 2001 From: Dan Moseley Date: Fri, 5 Jun 2020 11:06:25 -0700 Subject: [PATCH] SafeProcessHandle.Unix: fix missing DangerousRelease (#37412) (#37446) Because the SafeProcessHandle was not owned, ReleaseHandle was not called, causing the wrapped SafeWaitHandle to never release its resources. Co-authored-by: Tom Deseyn --- .../src/Microsoft/Win32/SafeHandles/SafeProcessHandle.Unix.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libraries/System.Diagnostics.Process/src/Microsoft/Win32/SafeHandles/SafeProcessHandle.Unix.cs b/src/libraries/System.Diagnostics.Process/src/Microsoft/Win32/SafeHandles/SafeProcessHandle.Unix.cs index 798e8f23d305c3..3eec27d88268d7 100644 --- a/src/libraries/System.Diagnostics.Process/src/Microsoft/Win32/SafeHandles/SafeProcessHandle.Unix.cs +++ b/src/libraries/System.Diagnostics.Process/src/Microsoft/Win32/SafeHandles/SafeProcessHandle.Unix.cs @@ -28,7 +28,7 @@ public sealed partial class SafeProcessHandle : SafeHandleZeroOrMinusOneIsInvali private readonly bool _releaseRef; internal SafeProcessHandle(int processId, SafeWaitHandle handle) : - this(handle.DangerousGetHandle(), ownsHandle: false) + this(handle.DangerousGetHandle(), ownsHandle: true) { ProcessId = processId; _handle = handle;