Skip to content

Expose No-Op Logger Scope Provider and Scope #109082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Expose No-Op Logger Scope Provider and Scope #109082

wants to merge 4 commits into from

Conversation

Foxtrek64
Copy link
Contributor

Fixes #108993

This PR moves NullExternalLoggingProvider and NullScope from the common directory to be first class members of the Microsoft.Extensions.Logging library and changes their accessibility to public.

I would like guidance on how to handle the ref library - do I need to generate those myself (and if so, how?) or are these generated automatically?

@MihaZupan
Copy link
Member

I would like guidance on how to handle the ref library - do I need to generate those myself (and if so, how?) or are these generated automatically?

See https://github.com/dotnet/runtime/blob/main/docs/coding-guidelines/updating-ref-source.md

@MihaZupan
Copy link
Member

MihaZupan commented Oct 21, 2024 •
edited
Loading

Note that the API proposal in #108993 has not been approved yet.

Changes to the public API have to go through the API review process first.

@Foxtrek64
Copy link
Contributor Author

Note that the API proposal in #108993 has not been approved yet.

Changes to the public API have to go through the API review process first.

This is true. I felt this was a simple enough change where having an implementation proposal wasn't too much of an ask. I'll close this PR until it's gone through the review.

@Foxtrek64 Foxtrek64 closed this Oct 21, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Oct 21, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-extensions-logging
See info in area-owners.md if you want to be subscribed.

This was referenced Oct 21, 2024
Open
Open
Open
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
area-Extensions-Logging community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[API Proposal]: Expose NullExternalScopeProvider and NullScope
2 participants
@Foxtrek64 @MihaZupan