IOptionsMonitor.Current always go though ConcurrentDictionary getter - perf?

[petrroll]

OptionsMonitor<T>.Current is not a field, it invokes a get on ConcurrentDictionary. In some codebases this can be used a lot. Sure, caching the current value is possible but the API surface doesn't make it obvious that it should be done.

I understand it's for simplicity allowing the same codepath to be used for named Config values as well as the default named string.Empty (which this property getter accesses) but it might be worth it to special case for the most common scenario and cache current value in a normal field so that access is essentially free (and inlinable and all that).

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/area-extensions-options
See info in area-owners.md if you want to be subscribed.

[davidfowl]

Do you have a performance profile show where this ends up being a problem? We can optimize but is there a real problem or just browsing the implementation?

[petrroll]

@davidfowl I completely missed the reply, apologies. It was mainly triggered by checking the implementation when we were migrating from custom runtime config solution to IConfiguration. But no, checking right now, we don't see it in perf traces much less see it as problem.

Feel free to close.