MetadataLoadContext assembly binding behavior is documented incorrectly

[reflectronic]

When MetadataLoadContext is resolving an assembly and its MetadataAssemblyResolver returns null, it throws an exception with this message:

runtime/src/libraries/System.Reflection.MetadataLoadContext/src/Resources/Strings.resx

Line 181 in a49ed69

<value>Could not find assembly '{0}'. Either explicitly load this assembly using a method such as LoadFromAssemblyPath() or use a MetadataAssemblyResolver that returns a valid assembly.</value>

The message suggests that 'pre-loading' the assembly with LoadFromAssemblyPath will populate the MetadataLoadContext's assembly binding cache.

The API documentation for the LoadFrom methods also suggests this is the case:

MetadataLoadContext.LoadFromAssemblyPath
Loads an assembly from a specific path on the disk and binds its assembly name to it in the MetadataLoadContext.

But these methods do not do this:

runtime/src/libraries/System.Reflection.MetadataLoadContext/src/System/Reflection/MetadataLoadContext.Loading.cs

Lines 47 to 49 in a49ed69

	// We do not add to the _binds list because the binding list is only for assemblies that have been resolved through
	// the Resolve method. This allows the resolver to have complete control over selecting the appropriate assembly
	// based on Version, CultureName and PublicKeyToken.

It looks like this behavior was changed, but the documentation and exception message was not updated: 2ef74f6#diff-7a38392b94b0c17ee62172e5b642b77f0b3a1bb8d79a6488d24f1729345c46fbL49

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

[ericstj]

@reflectronic would you like to propose an update to the documentation?