JIT: make non-null assertions about all indir addr types #113772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of just GC types. This removes some gratuitous diffs when escape analysis can retype a ref or byref to long. Also remove obsolete (?) block for TYP_LONG assertions.
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (1)
- src/coreclr/jit/assertionprop.cpp: Language not supported
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
|
@EgorBo PTAL Some diffs expected -- null checks removed (improvements), large constants propped (regressions). |
|
Let's see the diffs, last time I tried, it was mostly just a TP regression. Perhaps, things changed since then |
I will need something like this to avoid regressions when more escape analysis comes online. |
EgorBo
approved these changes
Mar 21, 2025
|
Not sure what to make of the failures yet. arm64 seems like a CI issue, arm ..?? |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of just GC types. This removes some gratuitous diffs when escape analysis can retype a ref or byref to long.
Also remove obsolete (?) block for TYP_LONG assertions.