Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try fixing api compat by adding api that uses PbeParameters #113993

Closed
wants to merge 22 commits into from
Closed

Try fixing api compat by adding api that uses PbeParameters #113993

wants to merge 22 commits into from

Conversation

PranavSenthilnathan
Copy link
Member

No description provided.

PranavSenthilnathan and others added 21 commits March 17, 2025 18:17
@PranavSenthilnathan
Scaffold SLH-DSA based on ML-DSA
1d83720
@PranavSenthilnathan
Update APIs to match shape from GH issue
5330029
@PranavSenthilnathan
Fix file name capitalization
952b27d
@PranavSenthilnathan
Revert to old structure
7875e96
@PranavSenthilnathan
fix csproj style
332d0ea
@PranavSenthilnathan
WIP
faa30a0
@PranavSenthilnathan
merge
8e9b634
@PranavSenthilnathan
Add tests
19cb2b5
@PranavSenthilnathan
Add more tests and change plaform support checks
1f0ec13
@PranavSenthilnathan
Merge branch 'main' of https://github.com/dotnet/runtime into pqc-tests
ad8973f
@PranavSenthilnathan
Fix exception ordering and some other PR feedback
7073dbe
@PranavSenthilnathan @bartonjs
Comments in test
dc04eff 
Co-authored-by: Jeremy Barton <[email protected]>
@PranavSenthilnathan
Make assert message clearer
71d5bf7
@PranavSenthilnathan
Get SLH-DSA components building with Microsoft.Bcl.Cryptography
b7d5008
@PranavSenthilnathan @bartonjs
Apply suggestions from code review
8e10a5b 
Co-authored-by: Jeremy Barton <[email protected]>
@PranavSenthilnathan
PR suggestions
5702861
@PranavSenthilnathan
type forwarding
3fa7fef
@vcsjones @PranavSenthilnathan
Output PbeParameters and friends
c9caf52
@vcsjones @PranavSenthilnathan
Add forward for .NET, too
b4700cd
@vcsjones @PranavSenthilnathan
merge
211d174
@PranavSenthilnathan
remove ifdef for pbeparams
cca7311
@PranavSenthilnathan PranavSenthilnathan added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) area-System.Security labels Mar 28, 2025
@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

@PranavSenthilnathan
Copy link
Member Author

didn't work

This was referenced Mar 28, 2025
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

@PranavSenthilnathan PranavSenthilnathan

Labels
area-System.Security new-api-needs-documentation NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PranavSenthilnathan @vcsjones