-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Closed
Milestone
Description
The SVE2 Math APIs don't quite match the reviews.
Reviews:
Differences:
- The args for
AddCarryWideningEvenandAddCarryWideningOddshould be changed fromop1,op2,op3toleft,right,carry AddWideningEvenOdd(left, right)=>AddWideningEvenOdd(leftEven, rightOdd)DotProductRotateComplex()andDotProductRotateComplexBySelectedIndex(), the argsop1,op2,op3should beaddend,left,rightAddSaturate()andSubtractSaturate()are declared aspublic static new. This should bepublic static- The args for
SubtractWideningEvenOdd()should be changed fromleft,righttoleftEven, rightOdd - The args for
SubtractWideningOddEven()should be changed fromleft,righttoleftOdd, rightEven - The args for
SubtractBorrowWideningOdd()andSubtractBorrowWideningEven()should be changed fromop1,op2,op3toleft,right,borrow - The args for
InterleavingXorEvenOdd()should be changed fromodd,left,righttoodd,leftEven,rightOdd - The args for
InterleavingXorOddEven()should be changed fromeven,left,righttoeven,leftOdd,rightEven - The args for
AddSaturateRotateComplex()should be changed fromop1,op2,rotationtoleft,right,rotation - The args for
MultiplyAddRoundedDoublingSaturateHighRotateComplex()should be changed fromop1,op2,op3,rotationtoaddend,left,right,rotation - The args for
MultiplyAddRoundedDoublingSaturateHighRotateComplexBySelectedScalar()should be changed fromop1,op2,op3,rotationtoaddend,left,right,rightIndex,rotation
These will require a breaking change issue raised once implemented:
AddSaturateWithUnsignedAddend()andAddSaturateWithSignedAddend()should be renamed toAddSaturate()to match the existingAddSaturate()function.- Dependant on the result of [API Proposal]: SVE2 Add extra parameter to ConvertToSingleOdd APIs #122031, there will need to be an extra parameter
evenadded toConvertToSingleOddRoundToOdd().
Nothing to do:
ShiftLeftLogicalWideningEven()andShiftLeftLogicalWideningOdd()was reviewed in both [API Proposal]: Arm64: FEAT_SVE2: bitwise #94015 (withcountfor arg2) and [API Proposal]: Arm64: FEAT_SVE2: bit manipulate #94020 (withshiftAmountfor arg2). It shouldn't really have been in the second set. Given that all other shift APIs usecountthen we should stick with that. Therefore nothing needs changing for this issue.