Skip to content

SVE2: Fixup SVE2 Math/bitmanipulate/FP APIs #121961

@a74nh

Description

@a74nh

The SVE2 Math APIs don't quite match the reviews.

Reviews:

Differences:

  • The args for AddCarryWideningEven and AddCarryWideningOdd should be changed from op1,op2,op3 to left,right,carry
  • AddWideningEvenOdd(left, right) => AddWideningEvenOdd(leftEven, rightOdd)
  • DotProductRotateComplex() and DotProductRotateComplexBySelectedIndex(), the args op1,op2,op3 should be addend,left,right
  • AddSaturate() and SubtractSaturate() are declared as public static new. This should be public static
  • The args for SubtractWideningEvenOdd() should be changed from left,right to leftEven, rightOdd
  • The args for SubtractWideningOddEven() should be changed from left,right to leftOdd, rightEven
  • The args for SubtractBorrowWideningOdd() and SubtractBorrowWideningEven() should be changed from op1,op2,op3 to left,right,borrow
  • The args for InterleavingXorEvenOdd() should be changed from odd,left,right to odd,leftEven,rightOdd
  • The args for InterleavingXorOddEven() should be changed from even,left,right to even,leftOdd,rightEven
  • The args for AddSaturateRotateComplex() should be changed from op1,op2,rotation to left,right,rotation
  • The args for MultiplyAddRoundedDoublingSaturateHighRotateComplex() should be changed from op1,op2,op3,rotation to addend,left,right,rotation
  • The args for MultiplyAddRoundedDoublingSaturateHighRotateComplexBySelectedScalar() should be changed from op1,op2,op3,rotation to addend,left,right,rightIndex,rotation

These will require a breaking change issue raised once implemented:

Nothing to do:

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions