XDocument does not format (pretty-print), not on Save, not with XmlWriter

[carlo-cs]

Description

I'm using the following code for formatting:

					var xdoc = XDocument.Parse( content );
					if ( xdoc.Root is not null ) {
						// ... custom code
						var sb = new StringBuilder();
						var settings = new XmlWriterSettings {
							Indent = true,
							IndentChars = "\t",
							OmitXmlDeclaration = true,
							NewLineOnAttributes = false,
							Encoding = Encoding.UTF8,
							WriteEndDocumentOnClose = true,
							NewLineChars = CS.CrLf,
							NewLineHandling = NewLineHandling.Replace
						};
						using ( var writer = XmlWriter.Create( sb, settings ) ) {
							xdoc.Save( writer );
						}
						content = sb.ToString();
					}
					content = StructureCheck.FixXmlToHtml( content );

The result, in 'content', is not formatted!
It contains strings like the following:
"  

"

So it is not formatted at all.

Before using the shown code, I also used "xdoc.ToString()", with the same, bad results.

Kind regards
Carlo

Reproduction Steps

See above.

Expected behavior

There should be a formatted, indented output, like:

<table class="page_table">
	<tbody>
		<tr>
			<td>
				&nbsp;
				<br />
				per E-Mail: {$Contact_Email}
			</td>
		</tr>
		<tr><td>&nbsp;</td></tr>
		<tr><td align="right">{$Date_Long} {$User_Code}&nbsp;</td></tr>
		<tr><td>&nbsp;</td></tr>
		<tr><td>&nbsp;</td></tr>
		<tr><td>&nbsp;</td></tr>
	</tbody>
</table>

Actual behavior

Flat output, like:

"  

"

Regression?

No response

Known Workarounds

None

Configuration

Console Application

DotNET Framework 9.0, on Windows Server.

Microsoft Windows [Version 10.0.20348.4405]

Microsoft Visual Studio Community 2022 (64-bit)
Version 17.14.19

Other information

No response

[JuergenAuer]

Hi @carlo-cs

what's your input XmlDocument?

It contains strings like the following:

This may be element content of the XmlDocument, so this is possible.

Edit: What is

StructureCheck.FixXmlToHtml

doing? If the output is html, may be that method removes all formatting \t etc.

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/area-system-xml
See info in area-owners.md if you want to be subscribed.

[carlo-cs]

The input is like the shown output, but flat, without indentation and line breaks. The expected outcome is formatted XML. The input basically is HTML markup, but formatted according to XML rules.

[JuergenAuer]

What's the output before this line:

Console.WriteLine(content);
content = StructureCheck.FixXmlToHtml( content );

This isn't a NET-method, so I don't know what this method is doing.

Html doesn't require \t etc., so this method may be the problem.

[carlo-cs]

it is making the XML compatible again with HTML. I.e. It converts XML to HTML.
But the problem already is invisible in the "content = sb.ToString();" line.