Skip to content

Fix and enable the PatternsDataSet_GenerateInputsWithNonBacktracking_MatchWithAllEngines test #79373

Open
@stephentoub

Description

@stephentoub

#79364 added a new test that iterates through all of the patterns we have in our patterns database and for each:

  • uses the NonBacktracking engine's SampleMatches function to generate inputs that match the pattern
  • calls IsMatch with each of those inputs on a Regex created for that pattern/option with each of our engines

The test is still disabled, however, as there's a variety of work required to get it "production ready":

  • SampleMatches ends up asserting on some patterns and hanging on others. This is likely one or more bugs in the SampleMatches implementation.
  • The test takes a really long time to execute.
  • It's only currently able to validate inputs expected to match. We also want to validate inputs expected to not match.
  • It's possible for some patterns it could generate inputs that take too long to process. We'll want to explore using timeouts.

cc: @olsaarik, @veanes

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions