Wrong "workload not found" message

[rmarinho]

Describe the bug

When trying to build a project without any workloads for .NET Multi-platform App UI (MAUI) , the build process fails with an error related to "maui-tizen" even though it is not required for the current project.

To Reproduce

• Create a new project in .NET MAUI that does not require maui-tizen workload.
• Attempt to build the project without maui workload installed
• Observe that the build process fails with an error related to "maui-tizen" even though it is not necessary for the project.

repo: https://github.com/rmarinho/DotNetTestTizen

Exceptions (if any)

To build this project, the following workloads must be installed: maui-tizen
To install these workloads, run the following command: dotnet workload restore

binlog : test-2.binlog.zip

Expected Result:
The build process should throw a error saying maui workload needs to be installed.

Further technical details

• running on macOS Monterey

 Version:   7.0.202
 Commit:    6c74320bc3

Runtime Environment:
 OS Name:     Mac OS X
 OS Version:  12.6
 OS Platform: Darwin
 RID:         osx.12-x64
 Base Path:   /Users/runner/hostedtoolcache/dotnet/sdk/7.0.202/

Host:
  Version:      7.0.4
  Architecture: x64
  Commit:       0a396acafe

.NET SDKs installed:
  7.0.202 [/Users/runner/hostedtoolcache/dotnet/sdk]

.NET runtimes installed:
  Microsoft.AspNetCore.App 7.0.4 [/Users/runner/hostedtoolcache/dotnet/shared/Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 7.0.4 [/Users/runner/hostedtoolcache/dotnet/shared/Microsoft.NETCore.App]

Other architectures found:
  None

Environment variables:
  DOTNET_ROOT       [/Users/runner/hostedtoolcache/dotnet]

global.json file:
  /Users/runner/work/1/s/global.json

Learn more:
  https://aka.ms/dotnet/info

Download .NET:
  https://aka.ms/dotnet/download

[marcpopMSFT]

From the binlog, there are two packs identified as missing: Microsoft.Maui.Sdk.net7 and Microsoft.Maui.Resizetizer.Sdk. Our logic here tries to map the pack onto the first workload it finds that requires these packs which happens to be maui-tizen. @jonathanpeppers can the workloads be reordered in the workload manifest so that a different one ends up being the one reported or should we try to have a more limited list of which we'd report (which would be a bit hacky)

[jonathanpeppers]

@marcpopMSFT I believe maui-tizen is listed somewhere in the middle:

https://github.com/dotnet/maui/blob/c7b7636310da0c5ce7785abeb31d97827cd131bb/src/Workload/Microsoft.NET.Sdk.Maui/WorkloadManifest.in.json#L16

If you have a suggestion like "put it first" or "put it last", @rmarinho should give it a try. You can edit the file locally at:

C:\Program Files\dotnet\sdk-manifests\7.0.100\microsoft.net.sdk.maui\WorkloadManifest.json

[marcpopMSFT]

@dsplaisted should we have more predictable code in the sdk or just rely on the order? @jonathanpeppers , I think putting it last should mean it's not the one listed if this particular issue is hit. I'd put them in the order you'd want them to be listed in the case of an error like this. Of course, I'm assuming that the order in the manifest impacts this.

[dsplaisted]

We try to suggest the "best" workload to install that will satisfy the packs that are needed to build the project. We define "best" as "requiring the fewest additional workload packs to be installed". So probably in this case installing the Tizen workload would result in installing fewer additional packs than the maui workload, and both would satisfy the requirements.

Or there could be a bug in the code. The code is here: https://github.com/dotnet/sdk/blob/main/src/Resolvers/Microsoft.NET.Sdk.WorkloadManifestReader/WorkloadSuggestionFinder.cs

[rmarinho]

What i don't understand is that if i m not building for that workload, why would it throw?! if i just need Microsoft.Maui.Sdk.net7 and Microsoft.Maui.Resizetizer.Sdk for the other workloads that i specify on my csproj.