.NET 8 RC2 does not honor ignore-failed-sources flag when running dotnet tool install

[aaronwjha]

When installing dotnet tools with a configured nuget source that fails to load, the --ignore-failed-sources flag is not honored.

Description

PS C:\Users\***\source\repos\jhld_reporting_templates> dotnet tool install JackHenry.Report.Fake --add-source "c:\Users\***\downloads" --global --ignore-failed-sources --verbosity diag 
[NuGet Manager] [Info]   GET https://api.nuget.org/v3/registration5-gz-semver2/jackhenry.report.fake/index.json
[NuGet Manager] [Info]   NotFound https://api.nuget.org/v3/registration5-gz-semver2/jackhenry.report.fake/index.json 61ms
[NuGet Manager] [Warning] The plugin credential provider could not acquire credentials. Authentication may require manual action. Consider re-running the command with --interactive for `dotnet`, /p:NuGetInteractive="true" for MSBuild or removing the -NonInteractive switch for `NuGet`
[NuGet Manager] [Warning] The plugin credential provider could not acquire credentials. Authentication may require manual action. Consider re-running the command with --interactive for `dotnet`, /p:NuGetInteractive="true" for MSBuild or removing the -NonInteractive switch for `NuGet`
[NuGet Manager] [Info]   GET https://***.com/artifactory/api/nuget/v3/nuget/FindPackagesById()?id='jackhenry.report.fake'&semVerLevel=2.0.0
[NuGet Manager] [Info]   Unauthorized https://***.com/artifactory/api/nuget/v3/nuget/FindPackagesById()?id='jackhenry.report.fake'&semVerLevel=2.0.0 107ms
Unhandled exception: NuGet.Protocol.Core.Types.FatalProtocolException: Unable to load the service index for source https://pkgs.dev.azure.com/*****/nuget/v3/index.json.
 ---> System.Net.Http.HttpRequestException: Response status code does not indicate success: 401 (Unauthorized).
   at System.Net.Http.HttpResponseMessage.EnsureSuccessStatusCode()
   at NuGet.Protocol.HttpSource.<>c__DisplayClass15_0`1.<<GetAsync>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at NuGet.Common.ConcurrencyUtilities.ExecuteWithFileLockedAsync[T](String filePath, Func`2 action, CancellationToken token)
   at NuGet.Common.ConcurrencyUtilities.ExecuteWithFileLockedAsync[T](String filePath, Func`2 action, CancellationToken token)
   at NuGet.Protocol.HttpSource.GetAsync[T](HttpSourceCachedRequest request, Func`2 processAsync, ILogger log, CancellationToken token)     
   at NuGet.Protocol.ServiceIndexResourceV3Provider.GetServiceIndexResourceV3(SourceRepository source, DateTime utcNow, ILogger log, CancellationToken token)
   --- End of inner exception stack trace ---
   at NuGet.Protocol.ServiceIndexResourceV3Provider.GetServiceIndexResourceV3(SourceRepository source, DateTime utcNow, ILogger log, CancellationToken token)
   at NuGet.Protocol.ServiceIndexResourceV3Provider.TryCreate(SourceRepository source, CancellationToken token)
   at NuGet.Protocol.Core.Types.SourceRepository.GetResourceAsync[T](CancellationToken token)
   at NuGet.Protocol.PackageMetadataResourceV3Provider.TryCreate(SourceRepository source, CancellationToken token)
   at NuGet.Protocol.Core.Types.SourceRepository.GetResourceAsync[T](CancellationToken token)
   at Microsoft.DotNet.Cli.NuGetPackageDownloader.NuGetPackageDownloader.GetPackageMetadataAsync(PackageSource source, String packageIdentifier, Boolean includePrerelease, CancellationToken cancellationToken)
   at Microsoft.DotNet.Cli.NuGetPackageDownloader.NuGetPackageDownloader.GetMatchingVersionInternalAsync(String packageIdentifier, IEnumerable`1 packageSources, VersionRange versionRange, CancellationToken cancellationToken)
   at Microsoft.DotNet.Cli.NuGetPackageDownloader.NuGetPackageDownloader.GetBestPackageVersionAsync(PackageId packageId, VersionRange versionRange, PackageSourceLocation packageSourceLocation)
   at Microsoft.DotNet.Cli.ToolPackage.ToolPackageDownloader.<>c__DisplayClass8_0.<InstallPackage>b__0()
   at Microsoft.DotNet.Cli.TransactionalAction.Run[T](Func`1 action, Action commit, Action rollback)
   at Microsoft.DotNet.Tools.Tool.Install.ToolInstallGlobalOrToolPathCommand.Execute()
   at System.CommandLine.Invocation.InvocationPipeline.Invoke(ParseResult parseResult)
   at Microsoft.DotNet.Cli.Program.ProcessArgs(String[] args, TimeSpan startupTime, ITelemetry telemetryClient)

Configuration

.NET 8 RC2
Windows 10 Ent, x64

Regression?

This works properly with .NET 7

[michaelgsharp]

@dsplaisted

[dsplaisted]

@JL03-Yue This is probably because the RestoreActionConfig isn't being created correctly based on the command line options. I think we recently looked at another similar bug with the NoCache option.

[frederikstonge]

Still an issue with 8.0.100 release.

[ricardoMTC]

I normally would use the --ignore-failed-sources but I'm also getting some errors upon using it. Also using 8.0.100

[ChristoWolf]

Hi!

Chiming in to say that I am also observing the same issue.

[PaulVrugt]

same here, any workaround?

This issue is breaking our build pipeline, so we are unable to migrate to .net 8 SDK

[ChristoWolf]

@PaulVrugt: I think a work-around would be to create a basic Nuget.Config file only containing the nuget.org feed and to pass this then to the command.

[PaulVrugt]

@ChristoWolf yes thank you, I found a similar workaround

[ChristoWolf]

I also had time now to try out this work-around, works fine.
Still, it would be great if this issue would be resolved as soon as possible.

[marci4]

Any update on this issue?

Is there a way on how we can speed up the process here?

[hannahbellelee]

I tend to think this is an issue unrelated to .NET8 as a whole. I have been getting failures on dotnet tool install before I installed .NET8.. It first started showing up in Visual Studio Code in my powershell terminal, so I thought it was something specifically related to VSCode, but when I opened a terminal or a powershell window outside of VSCode Id get the same thing....And always with the telerik nuget package....And what I am installing has nothing to do with the telerik nuget package.

I have been using a small workaround for months, because I thought this would get fixed eventually. So what I have to do is open:

C:\Users\dev007\AppData\Roaming\NuGet\NuGet.Config

And comment out the telerik key( I have 9 other keys in there and none of them cause an error except the telerik one):

<!-- <add key="Telerik NuGet" value="https://nuget.telerik.com/v3/index.json" /> -->

Save the file, then rerun

[dev007]$ dotnet tool install -g SOME_PACKAGE_TO_INSTALL

The install worked perfectly:

but now the Nuget Source is not available in Visual Studio, so I have to open the file back up and uncomment it then save the file again...