The Microsoft.NET.ILLink.Analyzers package has no stable version

[acarrazzoni-qontigo]

At my employer we disable nuget.org and use internal nuget feeds instead, also we set the RuntimeFrameworkVersion property on all of our solutions. When I try to build after updating to the NET 8 SDK, some of our projects try to pull the Microsoft.NET.ILLink.Analyzers package. If I try to add that package to our feeds and try to build again I get an error saying that the Microsoft.NET.ILLink.Analyzers package is a pre-release package and that should enable support for pre-release nuget packages, which we shouldn't need to do to build code using a stable NET SDK.

Please publish a stable version of the Microsoft.NET.ILLink.Analyzers package.

[mungojam]

We're hitting the same and I think it's because the version has a - instead of a +:

https://www.nuget.org/packages/Microsoft.NET.ILLink.Analyzers/

Thanks for creating this issue! We believe this issue is related to NuGet tooling, which is maintained by the NuGet team. Thus, we closed this one and encourage you to raise this issue in the NuGet repository instead. Don’t forget to check out NuGet’s contributing guide before submitting an issue!

If you believe this issue was closed out of error, please comment to let us know.

Happy Coding!

@dotnet/illink-contrib a new issue has been filed in the ILLink area, please triage

[baronfel]

Fixed the label and reopened the issue.

[sbomer]

When targeting net8.0, the analyzers are taken from https://www.nuget.org/packages/Microsoft.NET.ILLink.Tasks/8.0.0, but when targeting net7.0 and below we use that analyzer package. To fix this we'll need to service the net7.0 bits to change the package version. This wasn't an issue with the .NET 7 SDK because there the analyzers were bundled with the SDK.

[sbomer]

I can get errors like the ones you described by targeting net7.0 and setting RuntimeFrameworkVersion to 7.0.0:

warning NU1603: aot-ver depends on Microsoft.NET.ILLink.Tasks (>= 7.0.0) but Microsoft.NET.ILLink.Tasks 7.0.0 was not found. An approximate best match of Microsoft.NET.ILLink.Tasks 8.0.0 was resolved.
error NU1103: Unable to find a stable package Microsoft.NET.ILLink.Analyzers with version (>= 7.0.0)
error NU1103:   - Found 4 version(s) in nuget [ Nearest version: 7.0.100-1.23211.1 ]

This actually won't be fixed just by releasing a stable version - the problem is that RuntimeFrameworkVersion overrides the version of the Microsoft.NET.ILLink.Analyzers version, but that version doesn't exist since the .NET 7 analyzer package isn't using the same version numbers as runtime.

To fix this we would need to align the analyzer versions with dotnet/runtime versions, or prevent RuntimeFrameworkVersion from applying to the Microsoft.NET.ILLink.Analyzers. I think it generally makes sense for RuntimeFrameworkVersion to apply to the ILLink packages, because they are supposed to version with runtime. However, because they shipped from a separate repo in .NET 7 (github.com/dotnet/linker), there's no guarantee that every runtime release has a matching version of the ILLink packages in 7. We could try to manually keep the versions in sync (so for each .NET 7 servicing release, make sure we update dotnet/linker's 7.0 version to match the dotnet/runtime version).

In the meantime, as a workaround you can define the PackageReferences yourself so that their versions don't get overridden by RuntimeFrameworkVersion. This gets the version number from the KnownILLinkPack matching the TargetFramework, which is where the version normally comes from when you don't set RuntimeFrameworkVersion:

  <PropertyGroup>
    <ILLinkPackVersion>@(KnownILLinkPack->WithMetadataValue('TargetFramework', '$(TargetFramework)')->Metadata('ILLinkPackVersion'))</ILLinkPackVersion>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="Microsoft.NET.ILLink.Tasks" Version="$(ILLinkPackVersion)" />
    <PackageReference Include="Microsoft.NET.ILLink.Analyzers" Version="$(ILLinkPackVersion)" />
  </ItemGroup>

[mungojam]

@sbomer

To fix this we would need to align the analyzer versions with dotnet/runtime versions

Are you sure? All it is asking for in the message is:

A stable version
(>= 7.0.0)

Not a specific version.